fixing object conversion

Also adding tests, so this doesn't happen again

Author: FriedrichWeinmann

PSModuleDevelopment/PSModuleDevelopment.psd1

@@ -5,7 +5,7 @@
 
 	# Version number of this module.
 
-	ModuleVersion = '2.2.12.171'
+	ModuleVersion = '2.2.12.172'
 
   # ID used to uniquely identify this module
 	GUID = '37dd5fce-e7b5-4d57-ac37-832055ce49d6'
@@ -29,7 +29,7 @@
 	# this module
 	RequiredModules	       = @(
 		@{ ModuleName = 'PSFramework'; ModuleVersion = '1.12.346' }
-		@{ ModuleName = 'string'; ModuleVersion = '1.1.3' }
+		@{ ModuleName = 'string'; ModuleVersion = '1.1.5' }
 	)
 
 	# Assemblies that must be loaded prior to importing this module

PSModuleDevelopment/bin/PSModuleDevelopment.dll

@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.2.12.172 (2024-10-06)
+
++ Fix: Invoke-PSMDTemplate - On WinPS, script-logic on templates is not executed
+
 ## 2.2.12.171 (2024-10-04)
 
 + Upd: Raised PSFramework dependency due to critical security update

PSModuleDevelopment/bin/PSModuleDevelopment.pdb

@@ -0,0 +1,35 @@
+Describe "Verifying templating component" {
+	BeforeAll {
+		$tmpFolder = New-PSFTempDirectory -Name Template -ModuleName PSModuleDevelopment
+		$resourcePath = Resolve-PSFPath -Path "$PSScriptRoot\..\resources"
+		$templateName = 'TestTemplate-{0}' -f (Get-Random)
+	}
+	AfterAll {
+		Write-Host "Path: $resourcePath"
+		Remove-PSFTempItem -Name Template -ModuleName PSModuleDevelopment
+	}
+
+	It "Should Record the template correctly" {
+		{ New-PSMDTemplate -TemplateName $templateName -FilePath "$resourcePath\þnameþ.txt" -EnableException -ErrorAction Stop } | Should -Not -Throw
+		$templateInfo = Get-PSMDTemplate -TemplateName $templateName
+		$templateRaw = Import-PSFClixml -Path $templateInfo.Path
+		$template = [PSModuleDevelopment.Template.Template]$templateRaw
+		$template.Name | Should -Be $templateName
+		$template.Parameters.Count | Should -Be 1
+		$template.Scripts.Count | Should -Be 1
+		$template.Scripts.Values.ScriptBlock | Should -BeOfType ([scriptblock])
+	}
+
+	It "Should Invoke the template correctly" {
+		{ Invoke-PSMDTemplate -TemplateName $templateName -OutPath $tmpFolder -Name Test -EnableException } | Should -Not -Throw
+		$content = Get-Content -Path "$tmpFolder\Test.txt" -ErrorAction Stop
+		$values = $content | ConvertFrom-StringData -ErrorAction Stop
+		$values.Name | Should -Be Test
+		$values.Value | Should -Be '123'
+	}
+
+	It "Should Remove the template correctly" {
+		{ Remove-PSMDTemplate -TemplateName $templateName -EnableException -Confirm:$false } | Should -Not -Throw
+		Get-PSMDTemplate -TemplateName $templateName | Should -BeNullOrEmpty
+	}
+}

PSModuleDevelopment/bin/PSModuleDevelopment.xml

@@ -0,0 +1,2 @@
+Name = þnameþ
+Value = þ{ "123" }þ

PSModuleDevelopment/changelog.md

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Types>
   <!-- PSModuleDevelopment.Template.ParameterScript -->
-  <Type>
+  <!-- <Type>
     <Name>Deserialized.PSModuleDevelopment.Template.ParameterScript</Name>
     <Members>
       <MemberSet>
@@ -33,7 +33,7 @@
     <TypeConverter>
       <TypeName>PSFramework.Serialization.SerializationTypeConverter</TypeName>
     </TypeConverter>
-  </Type>
+  </Type> -->
 
   <!-- PSModuleDevelopment.Template.Template -->
   <Type>

PSModuleDevelopment/tests/functions/Templates.Tests.ps1

@@ -122,14 +122,14 @@ public Template(PSObject Item)
                 Description = Item.GetValue<string>("Description");
                 Author = Item.GetValue<string>("Author");
                 CreatedOn = Item.GetValue<DateTime>("CreatedOn");
-                foreach (object item in Item.GetValue<ArrayList>("Tags"))
+                foreach (object item in Item.GetValues("Tags"))
                     Tags.Add((string)item);
-                foreach (object item in Item.GetValue<ArrayList>("Parameters"))
+                foreach (object item in Item.GetValues("Parameters"))
                     Parameters.Add((string)item);
-                foreach (KeyValuePair<string, ParameterScript> entry in Item.GetDictionary<ParameterScript>("Scripts"))
+                foreach (KeyValuePair<string, ParameterScript> entry in Item.GetParameterScriptDictionary("Scripts"))
                     Scripts[entry.Key] =entry.Value;
                 // Parameters2 not used
-                foreach (object item in Item.GetValue<ArrayList>("Children"))
+                foreach (object item in Item.GetValues("Children"))
                     Children.Add(TemplateHost.GetTemplateItem(item));
 
                 Generation = Item.GetValue<int>("Generation");

PSModuleDevelopment/tests/resources/þnameþ.txt

@@ -1,4 +1,5 @@
-using System;
+using PSModuleDevelopment.Template;
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
@@ -26,19 +27,36 @@ public static T GetValue<T>(this PSObject PSObject, string Name)
             return (T)value.BaseObject;
         }
 
+        /// <summary>
+        /// Get the Values!
+        /// Always as an arraylist, empty if null
+        /// </summary>
+        /// <param name="PSObject">The object to extend</param>
+        /// <param name="Name">>The name of the property that has the values</param>
+        /// <returns>The values</returns>
+        public static ArrayList GetValues(this PSObject PSObject, string Name)
+        {
+            if (null == PSObject.Properties[Name].Value)
+                return new ArrayList();
+            PSObject value = PSObject.AsPSObject(PSObject.Properties[Name].Value);
+            if (null == value.BaseObject)
+                return new ArrayList();
+            return (ArrayList)value.BaseObject;
+        }
+
         /// <summary>
         /// Get a hashtable value!
         /// </summary>
         /// <typeparam name="T">The type of the values in hashtable</typeparam>
         /// <param name="PSObject">The object to extend</param>
         /// <param name="Name">The name of the property that has the hashtable</param>
         /// <returns>The hashtable!</returns>
-        public static Dictionary<string, T> GetDictionary<T>(this PSObject PSObject, string Name)
+        public static Dictionary<string, ParameterScript> GetParameterScriptDictionary(this PSObject PSObject, string Name)
         {
             Hashtable temp = PSObject.GetValue<Hashtable>(Name);
-            Dictionary<string, T> result = new Dictionary<string, T>();
+            Dictionary<string, ParameterScript> result = new Dictionary<string, ParameterScript>();
             foreach (DictionaryEntry pair in temp)
-                result[(string)pair.Key] = (T)pair.Value;
+                result[(string)pair.Key] = new ParameterScript((PSObject)pair.Value);
 
             return result;
         }