help fix semantic prompt - clean up foundry agents

Author: marktayl1

src/backend/sql_agents/semantic_verifier/prompt.txt

@@ -7,21 +7,18 @@
 - Do not hallucinate or assume any functionality that is not explicitly mentioned in the queries.
 - Avoid using any first person language in any of the output.
 - You are allowed to make common sense assumptions about the data and return types.
-- Your final answer should be a JSON with the following fields: 'analysis', 'judgement', 'differences'.
-- If the scripts are not semantically equivalent, judgement would be 'Semantically Not Equivalent' and list the differences in the 'differences' field.
+- If the scripts are not semantically equivalent, judgement would be 'Semantically Not Equivalent' and the differences would be listed in the 'differences' field.
 - If the scripts are semantically equivalent, judgement would be 'Semantically Equivalent' and the differences filed would be an empty list.
 
-# Output structure description
-Your final answer should **strictly** adhere to the following JSON structure:
+# Output
+Return a JSON object with keys ‘analysis’, ‘judgement’, ‘differences’, and ‘summary’ containing the results of your analysis.
+Do not include any metadata, schema descriptions, or commentary—only output the JSON result.
+Your final output should be a JSON object like:
 {
-  "analysis": "Here, you should provide a brief analysis of the source and target queries and the differences you found.",
-  "judgement": "Semantically Equivalent/Semantically Not Equivalent",
-  "differences": [
-    "Description of the difference 1",
-    "Description of the difference 2",
-    <...>
-  ]
-  "summary": "A one sentence description about your activities."
+  "analysis": "Brief analysis of the queries.",
+  "judgement": "Semantically Equivalent or Semantically Not Equivalent",
+  "differences": ["Difference 1", "Difference 2"],
+  "summary": "One sentence summary of your analysis."
 }
 
 Source Query:

src/backend/sql_agents_start.py

@@ -85,12 +85,13 @@
 class SqlAgents:
     """Class to setup the SQL agents for migration."""
 
-    agent_fixer = None
-    agent_migrator = None
-    agent_picker = None
-    agent_syntax_checker = None
+    agent_fixer: AzureAIAgent = None
+    agent_migrator: AzureAIAgent = None
+    agent_picker: AzureAIAgent = None
+    agent_syntax_checker: AzureAIAgent = None
     selection_function = None
     termination_function = None
+    agent_config: AgentBaseConfig = None
 
     def __init__(self):
         pass
@@ -101,6 +102,7 @@ async def create(cls, config: AgentBaseConfig):
         Required as init cannot be async"""
         self = cls()  # Create an instance
         try:
+            self.agent_config = config
             self.agent_fixer = await setup_fixer_agent(config)
             self.agent_migrator = await setup_migrator_agent(config)
             self.agent_picker = await setup_picker_agent(config)
@@ -132,19 +134,25 @@ def agents(self):
             self.agent_fixer,
         ]
 
+    async def delete_agents(self):
+        """cleans up the agents"""
+        try:
+            for agent in self.agents:
+                await self.agent_config.ai_project_client.agents.delete_agent(agent.id)
+        except Exception as exc:
+            logger.error("Error deleting agents: %s", exc)
+
 
 async def convert(
     source_script,
     file: FileRecord,
     batch_service: BatchService,
+    sql_agents: SqlAgents,
     agent_config: AgentBaseConfig,
 ) -> str:
     """setup agents, selection and termination."""
     logger.info("Migrating query: %s\n", source_script)
 
-    # setup the agents
-    sql_agents = await SqlAgents.create(agent_config)
-
     history_reducer = ChatHistoryTruncationReducer(
         target_count=2
     )  # keep only the last two messages
@@ -428,6 +436,9 @@ async def invoke_semantic_verifier(
         async for response in agent_semantic_verifier.invoke(messages=[user_message]):
             return response.content
 
+        # Clean up the agent
+        await config.ai_project_client.agents.delete_agent(agent_semantic_verifier.id)
+
     # Handle this as an exception from the Sematic Verifier is a warning
     except Exception as exc:
         logger.error(
@@ -465,11 +476,14 @@ async def process_batch_async(
             AzureAIAgent.create_client(credential=creds) as client,
         ):
 
-            # setup all agent settings per batch
+            # setup all agent settings and agents per batch
             agent_config = AgentBaseConfig(
                 project_client=client, sql_from=convert_from, sql_to=convert_to
             )
 
+            # setup the agents
+            sql_agents = await SqlAgents.create(agent_config)
+
             # Walk through each file name and retrieve it from blob storage
             # Send file to the agents for processing
             # Send status update to the client of type in progress, completed, or failed
@@ -519,7 +533,11 @@ async def process_batch_async(
 
                     # Convert the file
                     converted_query = await convert(
-                        sql_in_file, file_record, batch_service, agent_config
+                        sql_in_file,
+                        file_record,
+                        batch_service,
+                        sql_agents,
+                        agent_config,
                     )
                     if converted_query:
                         # Add RAI disclaimer to the converted query - split this into a function
@@ -548,6 +566,9 @@ async def process_batch_async(
                     # insert data base write to file record stating invalid file
                     await process_error(exc, file_record, batch_service)
 
+            # Cleanup the agents
+            await sql_agents.delete_agents()
+
         try:
             await batch_service.batch_files_final_update(batch_id)
         except Exception as exc: