fix(osu!ppy): add missing strings && change getStrings in presence.ts (#9325)

Author: skullysmods

websites/O/osu ppy/metadata.json

@@ -38,7 +38,7 @@
     "zh-tw": "節奏躍然指上！遊戲模式來自「押忍！戰鬥應援團」、「精英節拍特工」、太鼓的以及 osu! 原創的模式。包含一個功能齊全的譜面編輯器。"
   },
   "url": "osu.ppy.sh",
-  "version": "2.1.5",
+  "version": "2.1.6",
   "logo": "https://cdn.rcd.gg/PreMiD/websites/O/osu%20ppy/assets/logo.png",
   "thumbnail": "https://cdn.rcd.gg/PreMiD/websites/O/osu%20ppy/assets/thumbnail.png",
   "color": "#FF66AA",

websites/O/osu ppy/osu!ppy.json

@@ -1,36 +1,84 @@
 {
-  "osu!ppy.beatmapListing": {
+  "osu!ppy.accountSettings": {
+    "description": "Displayed when editing their account settings",
+    "message": "Changing account settings..."
+  },
+  "osu!ppy.beatMapListing": {
     "description": "Displayed when viewing all beatmaps.",
-    "message": "Viewing beatmap listings"
+    "message": "Beatmap Listings"
   },
-  "osu!ppy.beatmapLooking": {
+  "osu!ppy.beatMapLooking": {
     "description": "Displayed when looking at a beatmap.",
-    "message": "Looking at beatmap"
+    "message": "Looking at the beatmap"
   },
-  "osu!ppy.beatmapPacks": {
+  "osu!ppy.beatMapPacks": {
     "description": "Displayed when viewing all beatmap packs.",
-    "message": "Viewing beatmap packs"
-  },
-  "osu!ppy.beatmapRankings": {
-    "description": "Displayed when viewing Kudosu Rankings.",
-    "message": "Viewing kudosu rankings"
+    "message": "Beatmap Packs"
   },
   "osu!ppy.buttonViewBeatmap": {
     "description": "Displayed for a button to redirect to the beatmap page.",
     "message": "View Beatmap"
   },
+  "osu!ppy.changelog": {
+    "description": "Displayed when viewing changelog",
+    "message": "Changelog"
+  },
+  "osu!ppy.chatting": {
+    "description": "Displayed when chatting",
+    "message": "Chatting..."
+  },
+  "osu!ppy.contests": {
+    "description": "Displayed when browsing contests",
+    "message": "Contests"
+  },
   "osu!ppy.countryRankings": {
     "description": "Country rankings {0} = gamemode. E.g. Country Rankings [osu!]",
     "message": "Country rankings [{0}]"
   },
+  "osu!ppy.featuredArtists": {
+    "description": "Displayed when browsing featured Artists",
+    "message": "Featured Artists"
+  },
   "osu!ppy.for": {
     "description": "{0} = country/for All, {1} = gamemode. E.g. Performance Rankings (for All) [osu!]",
     "message": "(for {0}) [{1}]"
   },
+  "osu!ppy.forums": {
+    "description": "{0} = Forum Name. E.g. Forums Gameplay & Ranking",
+    "message": "Forums {0}"
+  },
+  "osu!ppy.friendList": {
+    "description": "Displayed when viewing their friend list",
+    "message": "Their Friend List"
+  },
+  "osu!ppy.kudosuRankings": {
+    "description": "Displayed when viewing Kudosu Rankings.",
+    "message": "The Kudosu Rankings"
+  },
+  "osu!ppy.livestreams": {
+    "description": "Displayed when browsing livestreams",
+    "message": "Livestreams"
+  },
+  "osu!ppy.osuStore": {
+    "description": "Displayed when browsing the Osu! Store",
+    "message": "The osu! Store"
+  },
+  "osu!ppy.otherProfile": {
+    "description": "{0} = Profile Name. E.g. Looking at OsuPlayer1's Profile",
+    "message": "Looking at {0}'s Profile"
+  },
   "osu!ppy.performanceRankings": {
     "description": "Displayed when viewing the performance rankings.",
     "message": "Performance rankings"
   },
+  "osu!ppy.rank": {
+    "description": "{0} = User Rank. E.g. Rank #1",
+    "message": "Rank {0}"
+  },
+  "osu!ppy.readingForum": {
+    "description": "Displayed when reading Forum",
+    "message": "Reading a Forum Post"
+  },
   "osu!ppy.scoreRankings": {
     "description": "{0} = gamemode. E.g. Score Rankings [osu!]",
     "message": "Score rankings [{0}]"
@@ -43,8 +91,20 @@
     "description": "Displayed when viewing the support page.",
     "message": "Ways to support osu!ppy"
   },
-  "osu!ppy.wikiMainPage": {
-    "description": "Displayed when viewing the wiki main page.",
-    "message": "Wiki main page"
+  "osu!ppy.theirProfile": {
+    "description": "{0} = User Name E.g. Looking at OsuPlayer1's Profile (Their Own)",
+    "message": "Looking at {0}'s Profile (Their Own)"
+  },
+  "osu!ppy.tournaments": {
+    "description": "Displayed when browsing tournaments",
+    "message": "Tournaments"
+  },
+  "osu!ppy.unsupportedPage": {
+    "description": "Displayed when viewing an unsupported page",
+    "message": "An Unsupported Page"
+  },
+  "osu!ppy.watchLists": {
+    "description": "Displayed when viewing their watchlists",
+    "message": "Their Watchlists"
   }
 }

websites/O/osu ppy/presence.ts

@@ -44,32 +44,20 @@ async function getStrings() {
       tournaments: 'osu!ppy.tournaments',
       unsupportedPage: 'osu!ppy.unsupportedPage',
       viewing: 'general.viewing',
-      viewingForum: 'osu!ppy.viewingForum',
       viewingHome: 'general.viewHome',
       watchLists: 'osu!ppy.watchLists',
       wikiMainPage: 'general.wikiMainPage',
     },
-    await presence.getSetting<string>('lang').catch(() => 'en'),
   )
 }
 
-let strings: Awaited<ReturnType<typeof getStrings>>
-let oldLang: string | null = null
-
 presence.on('UpdateData', async () => {
   const presenceData: PresenceData = {
     largeImageKey: 'https://cdn.rcd.gg/PreMiD/websites/O/osu%20ppy/assets/logo.png',
   }
-  const [buttons, newLang] = await Promise.all([
-    presence.getSetting<boolean>('buttons'),
-    presence.getSetting<string>('lang'),
-  ])
+  const buttons = presence.getSetting<boolean>('buttons')
   const { pathname, href } = document.location
-
-  if (oldLang !== newLang) {
-    oldLang = newLang
-    strings = await getStrings()
-  }
+  const strings = await getStrings()
 
   if (pathname === '/home') {
     const inputSelected = document.querySelector<HTMLInputElement>('[type="search"]')
@@ -273,7 +261,7 @@ presence.on('UpdateData', async () => {
       presenceData.state = selected.textContent
       presenceData.smallImageKey = Assets.Reading
     }
-    else if (pathname.includes('/Main_Page')) {
+    else if (pathname.includes('/Main_page')) {
       presenceData.details = strings.reading
       presenceData.state = strings.wikiMainPage
       presenceData.smallImageKey = Assets.Reading