Skip to content

Commit 37f0889

Browse files
committed
flow: fix metadata deps
- Add explicit Makefile deps for stage SDC side-effects (2_1_floorplan.sdc, 5_1_grt.sdc).\n- Enforce metadata ordering so metadata-check waits for metadata-generate and finish.
1 parent 4e2de98 commit 37f0889

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

flow/Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,9 @@ $(RESULTS_DIR)/1_synth.sdc: $(RESULTS_DIR)/1_synth.odb
401401

402402
$(eval $(call do-step,2_1_floorplan,$(RESULTS_DIR)/1_synth.odb $(RESULTS_DIR)/1_synth.sdc $(TECH_LEF) $(SC_LEF) $(ADDITIONAL_LEFS) $(FOOTPRINT) $(SIG_MAP_FILE) $(FOOTPRINT_TCL) $(LIB_FILES) $(IO_CONSTRAINTS),floorplan))
403403

404+
# The floorplan step writes the stage SDC as a side effect.
405+
$(RESULTS_DIR)/2_1_floorplan.sdc: $(RESULTS_DIR)/2_1_floorplan.odb
406+
404407
$(eval $(call do-copy,2_floorplan,2_1_floorplan.sdc,,.sdc))
405408

406409
# STEP 2: Macro Placement
@@ -540,6 +543,9 @@ grt: $(RESULTS_DIR)/5_1_grt.odb
540543
#-------------------------------------------------------------------------------
541544
$(eval $(call do-step,5_1_grt,$(RESULTS_DIR)/4_cts.odb $(FASTROUTE_TCL) $(PRE_GLOBAL_ROUTE_TCL),global_route))
542545

546+
# The global route step writes the stage SDC as a side effect.
547+
$(RESULTS_DIR)/5_1_grt.sdc: $(RESULTS_DIR)/5_1_grt.odb
548+
543549
# STEP 2: Run detailed route
544550
#-------------------------------------------------------------------------------
545551
$(eval $(call do-step,5_2_route,$(RESULTS_DIR)/5_1_grt.odb,detail_route))

flow/util/utils.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
metadata: finish metadata-generate metadata-check
55

66
.PHONY: metadata-generate
7-
metadata-generate:
7+
metadata-generate: finish
88
mkdir -p $(REPORTS_DIR)
99
echo $(DESIGN_DIR) > $(REPORTS_DIR)/design-dir.txt
1010
$(PYTHON_EXE) $(UTILS_DIR)/genMetrics.py -d $(DESIGN_NICKNAME) \
@@ -19,7 +19,7 @@ metadata-generate:
1919
export RULES_JSON ?= $(DESIGN_DIR)/rules-$(FLOW_VARIANT).json
2020

2121
.PHONY: metadata-check
22-
metadata-check:
22+
metadata-check: metadata-generate
2323
$(PYTHON_EXE) $(UTILS_DIR)/checkMetadata.py \
2424
-m $(REPORTS_DIR)/metadata.json \
2525
-r $(RULES_JSON) 2>&1 \

0 commit comments

Comments
 (0)