Skip to content

Commit 52b92f6

Browse files
authored
Merge pull request #412 from PrestaShop/useNightlyBuild
Fixed PHP 7.4 image generation
2 parents db56ae0 + b9848d9 commit 52b92f6

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

base/generate_tags.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ generate_image()
4141
s/{PHP_TAG}/'"${version}"'/
4242
' Dockerfile.model > images/$folder/Dockerfile
4343

44-
if [[ $version = *"7.1"* || $version = *"7.2"* || $version = *"7.3"* || $version = *"7.4"* ]]; then
44+
if [[ $version = *"7.1"* || $version = *"7.2"* || $version = *"7.3"* ]]; then
4545
local before='RUN docker-php-ext-configure gd --with-freetype=\/usr\/include\/ --with-jpeg=\/usr\/include\/ --with-webp=\/usr\/include'
4646
local after='# PHP < 7.4 have an old syntax to install GD. See https:\/\/github.com\/docker-library\/php\/issues\/912\nRUN docker-php-ext-configure gd --with-freetype-dir=\/usr\/include\/ --with-jpeg-dir=\/usr\/include\/ --with-webp-dir=\/usr\/include'
4747

base/images/7.4-apache/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ RUN apt-get update \
4040
libonig-dev
4141

4242
RUN rm -rf /var/lib/apt/lists/*
43-
# PHP < 7.4 have an old syntax to install GD. See https://github.com/docker-library/php/issues/912
44-
RUN docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/ --with-webp-dir=/usr/include
43+
RUN docker-php-ext-configure gd --with-freetype=/usr/include/ --with-jpeg=/usr/include/ --with-webp=/usr/include
4544
RUN docker-php-ext-install iconv intl pdo_mysql mbstring soap gd zip bcmath
4645

4746
RUN docker-php-source extract \

base/images/7.4-fpm/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ RUN apt-get update \
4040
libonig-dev
4141

4242
RUN rm -rf /var/lib/apt/lists/*
43-
# PHP < 7.4 have an old syntax to install GD. See https://github.com/docker-library/php/issues/912
44-
RUN docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/ --with-webp-dir=/usr/include
43+
RUN docker-php-ext-configure gd --with-freetype=/usr/include/ --with-jpeg=/usr/include/ --with-webp=/usr/include
4544
RUN docker-php-ext-install iconv intl pdo_mysql mbstring soap gd zip bcmath
4645

4746
RUN docker-php-source extract \

0 commit comments

Comments
 (0)