Merge pull request #655 from mattgoud/update-for-node-iron-lts

chore(deps): upgrade some packages (test for node 20)

Author: jolelievre

.github/workflows/build.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup node env
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Install dependencies
         run: npm ci
@@ -52,7 +52,7 @@ jobs:
           rm webpack.config.js
 
       - name: Create & Upload artifact
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
             name: ${{ github.event.repository.name }}
             path: ./
@@ -62,7 +62,7 @@ jobs:
       if: github.event_name == 'push' && github.event.ref == 'refs/heads/master'
       steps:
           - name: Download artifact
-            uses: actions/download-artifact@v1
+            uses: actions/download-artifact@v4
             with:
                 name: ${{ github.event.repository.name }}
 

.github/workflows/cd.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node: [16]
+        node: [20]
 
     steps:
       - name: Checkout

.github/workflows/lint.yml

@@ -10,7 +10,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Lint scss
         run: npm ci && npm run scss-lint
@@ -23,7 +23,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Lint js
         run: touch ./webpack/.env && npm ci && npm run lint

.github/workflows/tests.yml

@@ -6,7 +6,7 @@ jobs:
     name: Run unit tests
     strategy:
       matrix:
-        js: [ '16' ]
+        js: [ '20' ]
     steps:
       - name: Setup Node
         uses: actions/setup-node@v3

.github/workflows/typecheck.yml

@@ -10,7 +10,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Build and check types
         run: touch ./webpack/.env && npm ci && npm run build

.stylelintrc

@@ -4,14 +4,14 @@
   ],
   "customSyntax": "postcss-scss",
   "rules": {
+    "selector-id-pattern": null,
     "selector-max-id": null,
     "selector-max-class": null,
     "selector-max-type": null,
     "selector-max-compound-selectors": null,
     "selector-no-qualifying-type": null,
     "selector-max-combinators": null,
     "selector-class-pattern": null,
-    "selector-descendant-combinator-no-non-space": null,
     "function-disallowed-list": null,
     "scss/dollar-variable-default": null,
     "property-disallowed-list": null

README.md

@@ -9,7 +9,7 @@ This is a PrestaShop's theme we are working on. Please, if you work on this them
 
 ## How to build assets
 
-Same as the PrestaShop project, you need at least **NodeJS 16.x** and **NPM 8** in order to build the project.
+Same as the PrestaShop project, you need at least **NodeJS 20.x** and **NPM 8** in order to build the project.
 
 First you need to install every node module: