chore: fix eslint errors, unset stylint rule selector-id-pattern, update node version for CI, downgrade typescript version (for eslint compatibility)

Author: mattgoud

.github/workflows/build.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup node env
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Install dependencies
         run: npm ci

.github/workflows/cd.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node: [16]
+        node: [20]
 
     steps:
       - name: Checkout

.github/workflows/lint.yml

@@ -10,7 +10,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Lint scss
         run: npm ci && npm run scss-lint
@@ -23,7 +23,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Lint js
         run: touch ./webpack/.env && npm ci && npm run lint

.github/workflows/tests.yml

@@ -6,7 +6,7 @@ jobs:
     name: Run unit tests
     strategy:
       matrix:
-        js: [ '16' ]
+        js: [ '20' ]
     steps:
       - name: Setup Node
         uses: actions/setup-node@v3

.github/workflows/typecheck.yml

@@ -10,7 +10,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Build and check types
         run: touch ./webpack/.env && npm ci && npm run build

.stylelintrc

@@ -4,14 +4,14 @@
   ],
   "customSyntax": "postcss-scss",
   "rules": {
+    "selector-id-pattern": null,
     "selector-max-id": null,
     "selector-max-class": null,
     "selector-max-type": null,
     "selector-max-compound-selectors": null,
     "selector-no-qualifying-type": null,
     "selector-max-combinators": null,
     "selector-class-pattern": null,
-    "selector-descendant-combinator-no-non-space": null,
     "function-disallowed-list": null,
     "scss/dollar-variable-default": null,
     "property-disallowed-list": null

package-lock.json

@@ -68,7 +68,7 @@
     "stylelint": "^14.16.1",
     "stylelint-config-prestashop": "^1.0.7",
     "ts-jest": "^29.2.5",
-    "typescript": "^5.6.2",
+    "typescript": "~5.5.4",
     "webpack": "^5.95.0",
     "webpack-bundle-analyzer": "^4.10.2",
     "webpack-cli": "^5.1.4",

package.json

@@ -165,6 +165,7 @@ const usePasswordPolicy = (selector: string): PasswordPolicyReturn => {
           try {
             return JSON.parse(content);
           } catch (error) {
+            console.error(error);
             return false;
           }
         })(hintElement.innerHTML);

src/js/components/usePasswordPolicy.ts

@@ -217,7 +217,7 @@ const mockedResponse = (ok: boolean, hasError?: boolean, qty?: string): jest.Moc
   return mockedFetch;
 };
 
-const debounceTimeout = async () => new Promise((fn) => setTimeout(fn, Quantify.delay));
+const debounceTimeout = async () => new Promise((fn) => { setTimeout(fn, Quantify.delay); });
 
 const getHTMLElement = <Type extends HTMLElement>(selector: string, parent?: Type): Type => {
   const parentElement = parent ?? document;