Merge pull request #832 from tblivet/fix/qa-review

Small fixes related to the global Hummingbird theme QA review

Author: tblivet

modules/ps_mainmenu/ps_mainmenu.tpl

@@ -66,7 +66,6 @@
           <div 
             class="submenu__right-items" 
             role="tabpanel"
-            aria-hidden="{if $smarty.foreach.node.first}false{else}true{/if}"
             data-ps-ref="desktop-submenu-right-items"
             {if $node.children|count}
               id="submenu_{$node.label|lower|classname}_{$node.depth}_{$node.page_identifier}"

src/scss/prestashop/components/customer/_customer-account-menu.scss

@@ -70,13 +70,11 @@ $component-name: account-menu;
     }
   }
 
-  @include media-breakpoint-up(md) {
+  @include media-breakpoint-up(lg) {
     &__back {
       display: none;
     }
-  }
 
-  @include media-breakpoint-up(lg) {
     &--main {
       grid-template-columns: repeat(3, minmax(0, 1fr));
 

templates/_partials/notifications.tpl

@@ -59,7 +59,7 @@
 
     {if $notifications.info}
       {block name='notifications_info'}
-        <div class="alert alert-info alert-dismissible" role="status" tabindex="0">
+        <div class="alert alert-info alert-dismissible" role="alert" tabindex="0">
           {if $notifications.info|count > 1}
             <ul class="mb-0">
               {foreach $notifications.info as $notif}

templates/catalog/_partials/customization-modal.tpl

@@ -33,7 +33,6 @@
                   "id"=>$image_modal_id,
                   "title"=>$field.label,
                   "image_url"=>$field.image.large.url,
-                  "image_info"=>getimagesize($field.image.large.url),
                   "back_id"=>$customization_modal_id
                 ]
               }

templates/catalog/_partials/product-customization-modal.tpl

@@ -44,7 +44,6 @@
                       "id"=>$image_modal_id,
                       "title"=>$field.label,
                       "image_url"=>$field.image.large.url,
-                      "image_info"=>getimagesize($field.image.large.url),
                       "back_id"=>$customization_modal_id
                     ]
                   }

templates/checkout/_partials/steps/personal-information.tpl

@@ -88,11 +88,11 @@
     </ul>
 
     <div class="tab-content" id="personal-information-tabs-content">
-      <div class="tab-pane fade{if !$show_login_form} show active{/if}" id="checkout-guest-form" aria-labelledby="checkout-guest-form" role="tabpanel" {if $show_login_form}aria-hidden="true"{/if}>
+      <div class="tab-pane fade{if !$show_login_form} show active{/if}" id="checkout-guest-form" aria-labelledby="checkout-guest-form" role="tabpanel">
         {render file='checkout/_partials/customer-form.tpl' ui=$register_form guest_allowed=$guest_allowed}
       </div>
 
-      <div class="tab-pane fade{if $show_login_form} show active{/if}" id="checkout-login-form" aria-labelledby="checkout-login-form" role="tabpanel" {if !$show_login_form}aria-hidden="true"{/if}>
+      <div class="tab-pane fade{if $show_login_form} show active{/if}" id="checkout-login-form" aria-labelledby="checkout-login-form" role="tabpanel">
         {render file='checkout/_partials/login-form.tpl' ui=$login_form}
       </div>
     </div>