Fix review

Author: nicosomb

src/ApiPlatform/Resources/Discount/DiscountType.php

@@ -31,14 +31,14 @@
         new CQRSGetCollection(
             uriTemplate: '/discount-types',
             CQRSQuery: GetDiscountTypes::class,
-            scopes: [],
+            scopes: ['discount_read'],
             CQRSQueryMapping: [],
             ApiResourceMapping: [
                 '[type]' => '[type]',
                 '[localizedNames]' => '[names]',
                 '[localizedDescriptions]' => '[descriptions]',
-                '[isCore]' => '[isCore]',
-                '[active]' => '[active]',
+                '[core]' => '[core]',
+                '[enabled]' => '[enabled]',
             ],
         ),
     ],
@@ -57,7 +57,7 @@ class DiscountType
     #[LocalizedValue]
     public array $descriptions;
 
-    public bool $isCore;
+    public bool $core;
 
-    public bool $active;
+    public bool $enabled;
 }

tests/Integration/ApiPlatform/DiscountTypeEndpointTest.php

@@ -0,0 +1,71 @@
+<?php
+/**
+ * Copyright since 2007 PrestaShop SA and Contributors
+ * PrestaShop is an International Registered Trademark & Property of PrestaShop SA
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Academic Free License version 3.0
+ * that is bundled with this package in the file LICENSE.md.
+ * It is also available through the world-wide-web at this URL:
+ * https://opensource.org/licenses/AFL-3.0
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@prestashop.com so we can send you a copy immediately.
+ *
+ * @author    PrestaShop SA and Contributors <contact@prestashop.com>
+ * @copyright Since 2007 PrestaShop SA and Contributors
+ * @license   https://opensource.org/licenses/AFL-3.0 Academic Free License version 3.0
+ */
+
+namespace PsApiResourcesTest\Integration\ApiPlatform;
+
+class DiscountTypeEndpointTest extends ApiTestCase
+{
+    public static function setUpBeforeClass(): void
+    {
+        parent::setUpBeforeClass();
+        self::createApiClient();
+    }
+
+    public static function getProtectedEndpoints(): iterable
+    {
+        // The endpoint doesn't require any scope but you still need to be logged (have a valid token)
+        yield 'get endpoint' => [
+            'GET',
+            '/discount-types',
+        ];
+    }
+
+    public function testGetDiscountTypes(): void
+    {
+        $discountTypes = $this->listDiscountTypes();
+
+        $this->assertGreaterThanOrEqual(1, count($discountTypes));
+
+        if (count($discountTypes) > 0) {
+            $firstType = $discountTypes[0];
+            $this->assertArrayHasKey('discountTypeId', $firstType);
+            $this->assertArrayHasKey('type', $firstType);
+            $this->assertArrayHasKey('names', $firstType);
+            $this->assertArrayHasKey('descriptions', $firstType);
+            $this->assertArrayHasKey('isCore', $firstType);
+            $this->assertArrayHasKey('active', $firstType);
+        }
+    }
+
+    private function listDiscountTypes(): array
+    {
+        $bearerToken = $this->getBearerToken();
+        $response = static::createClient()->request('GET', '/discount-types', [
+            'auth_bearer' => $bearerToken,
+        ]);
+        self::assertResponseStatusCodeSame(200);
+
+        $decodedResponse = json_decode($response->getContent(), true);
+        $this->assertNotFalse($decodedResponse);
+        $this->assertIsArray($decodedResponse);
+
+        return $decodedResponse;
+    }
+}