[Bug]: Improper enforcement of fields on POST v1/communities #268
Description
Checked Existing
- I have checked the repository for duplicate issues.
What happened?
When creating a subcommunity via a game that only sends the "name" form param, the server gives a BAD_PARAMS error, and when adding the "icon" param manually, not having an "app_data" or "description" param causes the request to error even though they are optional server-side
What did you expect to happen?
The subcommunity to be created as expected
Steps to reproduce?
No response
Other relevant information. (OPTIONAL)
When creating a user subcommunity, the olv api can send up to five form params (including one that goes unused):
- name (internally a 128 length wchar string, presumably including null termination, likely required)
- icon (internally a byte array pointer with a length limit of 65580, presumably including any non-pixel data, not required)
- description (internally a 256 length wchar string, presumably including null termination, not required)
- app_data (internally a uchar pointer with a length limit of 1024, including null terminator, not required)
- search_key (up to five, not sure exactly the implementation details of it, seemingly unused, not required)
From viewing the subcommunity creation request that Super Smash Bros. for Wii U sends, only a name gets sent, and nothing else, but looking at the code for UploadCommunityDataParam in nn_olv.rpl, the name being set is seemingly not even enforced when adding the form params, but it might be enforced in some later function call or just by the server itself, so it's probably safe to assume that a name is required
In terms of default icon, I think just a copy of the parent community would be the best assumption