[Feature]: Data sanity checks on posts.

[shoginyan]

Checked Existing

• I have checked the repository for duplicate issues.

What feature do you want to see added?

Only allow characters that are on the 3ds/wiiu keyboard and reject a post if it does not meet that requirement.

Why do you want to have this feature?

So people that hit the api cant make posts with these unique characters.

Any other details to share? (OPTIONAL)

No response

[jonbarrow]

I'm approving this, since it's a good idea on paper. But it's something we need to be really careful about otherwise we could lock people out of their native languages if we don't account for all characters in all character sets

[ashquarky]

Worth noting that we do have the following regex:

juxtaposition/apps/juxtaposition-ui/src/util.ts

Lines 123 to 126 in 2ecd2b3

	// TODO - This doesn't belong here, just hacking it in. Gonna redo this whole server anyway so fuck it
	export function getInvalidPostRegex(): RegExp {
	return /[^\p{L}\p{P}\d\n\r$^¨←→↑↓√¦⇒⇔¤¢€£¥™©®+×÷=±∞˘˙¸˛˜°¹²³♭♪¬¯¼½¾♡♥●◆■▲▼☆★♀♂<> ]/gu;
	}

juxtaposition/apps/miiverse-api/src/util.ts

Lines 41 to 44 in 2ecd2b3

	// TODO - This doesn't really belong here
	export function getInvalidPostRegex(): RegExp {
	return /[^\p{L}\p{P}\d\n\r$^¨←→↑↓√¦⇒⇔¤¢€£¥™©®+×÷=±∞˘˙¸˛˜°¹²³♭♪¬¯¼½¾♡♥●◆■▲▼☆★♀♂<> ]/gu;
	}

This does not appear to accurately reflect what is possible to type on a Wii U or 3DS keyboard, however.

[jonbarrow]

Worth noting that we do have the following regex:

juxtaposition/apps/juxtaposition-ui/src/util.ts

Lines 123 to 126 in 2ecd2b3

	// TODO - This doesn't belong here, just hacking it in. Gonna redo this whole server anyway so fuck it
	export function getInvalidPostRegex(): RegExp {
	return /[^\p{L}\p{P}\d\n\r$^¨←→↑↓√¦⇒⇔¤¢€£¥™©®+×÷=±∞˘˙¸˛˜°¹²³♭♪¬¯¼½¾♡♥●◆■▲▼☆★♀♂<> ]/gu;
	}

juxtaposition/apps/miiverse-api/src/util.ts

Lines 41 to 44 in 2ecd2b3

	// TODO - This doesn't really belong here
	export function getInvalidPostRegex(): RegExp {
	return /[^\p{L}\p{P}\d\n\r$^¨←→↑↓√¦⇒⇔¤¢€£¥™©®+×÷=±∞˘˙¸˛˜°¹²³♭♪¬¯¼½¾♡♥●◆■▲▼☆★♀♂<> ]/gu;
	}

This does not appear to accurately reflect what is possible to type on a Wii U or 3DS keyboard, however.

I know it exists, but like you said it doesn't cover the correct range and has been the source of complaints in the past. I did "improve" that regex a couple years ago, by adding support for multiple languages through \p{L}\p{P}, but that was only to solve the issue of people with non-English keyboards being blocked and is likely too overzealous with what it allows