[Feature]: Make it includeable from other projects

[Milk-Cool]

Checked Existing

• I have checked the repository for duplicate issues.

What feature do you want to see added?

Basically what the title says -- i want to include it in my project but it gives me this error:

Why do you want to have this feature?

because i want to include it in my own project

Any other details to share? (OPTIONAL)

No response

[jonbarrow]

Did you install it? It says it can't be found, which tells me that you didn't install/import it correctly

[Milk-Cool]

hi!

sorry for not updating the issue, but i had to include a postinstall script in my project's package.json to make it work. i'll provide the script in a comment below (sorry, i'm on mobile)

[Milk-Cool]

https://github.com/Milk-Cool/WaraWaraPlazaWeb/blob/main/package.json#L8

    "postinstall": "cd node_modules/@pretendonetwork/mii-js && npm i --include=dev && npx tsc && npx tsc-alias && npm run copy-files && cd ../../..",

[Milk-Cool]

and as far as i remember, i did something like npm i git+blahblahblah, so if the solution is to provide pre-compiled js files, it would be better to provide them on npm to keep the github repo clean

[jonbarrow]

Our account server also uses this library, installed from GitHub, without any issue and without any hacks like you have https://github.com/PretendoNetwork/account/blob/89243ea6863ca18ddea44d66d8992a804ee5a14f/package.json#L48

I'm not sure what the issue is tbh, going to tag @mrjvs and @binaryoverload to see if they have any ideas?

It should be noted though that this library will eventually be deprecated in favor of PretendoNetwork/nintendo-file-formats#2

[binaryoverload]

We're actually kinda lucky the account server works, as this package isn't properly set up for use in other projects (i.e. doesn't have a published npm package). The current version has also been written in TypeScript, which is why you're having to build it @Milk-Cool

The account server uses a version https://github.com/PretendoNetwork/mii-js/tree/5d8eb8013514a13b0df6eb4a5bfd8b5a63fb9861 (resolved in the package-lock.json) that was in JS, not in TS

To fix this in the package.json, you can pin on a version: github:PretendoNetwork/mii-js#5d8eb8013514a13b0df6eb4a5bfd8b5a63fb9861 I believe

[Milk-Cool]

oh alright! thanks for the answers, i'll close the issue now