Skip to content

Commit 0e53e7f

Browse files
samsjasami jaghouar
andauthored
fix logging (#1605)
Co-authored-by: sami jaghouar <[email protected]>
1 parent b214a45 commit 0e53e7f

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/prime_rl/utils/logger.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,13 @@ def setup_logger(log_level: str, log_file: Path | None = None, append: bool = Fa
6767
extra={},
6868
)
6969

70-
# Install console handler
71-
logger.add(sys.stdout, format=format, level=log_level.upper(), colorize=True)
72-
73-
# If specified, install file handler
70+
# If log_file is specified, write only to file (used by workers); otherwise write to stdout
7471
if log_file is not None:
7572
if not append and log_file.exists():
7673
log_file.unlink()
77-
logger.add(log_file, format=format, level=log_level.upper(), colorize=True)
74+
logger.add(log_file, format=format, level=log_level.upper(), colorize=False)
75+
else:
76+
logger.add(sys.stdout, format=format, level=log_level.upper(), colorize=True)
7877

7978
# Disable critical logging
8079
logger.critical = lambda _: None

0 commit comments

Comments
 (0)