Skip to content

Commit ff11125

Browse files
committed
minor
1 parent d15010b commit ff11125

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

verifiers/envs/environment.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,7 +1030,9 @@ async def evaluate(
10301030
save_results: bool = False,
10311031
save_every: int = -1,
10321032
independent_scoring: bool = False,
1033+
on_start: StartCallback | None = None,
10331034
on_progress: ProgressCallback | None = None,
1035+
on_log: LogCallback | None = None,
10341036
**kwargs,
10351037
) -> GenerateOutputs:
10361038
"""
@@ -1050,7 +1052,9 @@ async def evaluate(
10501052
save_results=save_results,
10511053
save_every=save_every,
10521054
independent_scoring=independent_scoring,
1055+
on_start=on_start,
10531056
on_progress=on_progress,
1057+
on_log=on_log,
10541058
**kwargs,
10551059
)
10561060

verifiers/types.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,6 @@
4949
GroupRewardFunc = Callable[..., list[float] | Awaitable[list[float]]]
5050
RewardFunc = IndividualRewardFunc | GroupRewardFunc
5151

52-
# callbacks for evals
53-
StartCallback = Callable[[int], None] # receives actual total count
54-
# ProgressCallback receives (all_states_finished, new_states_from_await)
55-
ProgressCallback = Callable[["list[State]", "list[State]"], None]
56-
LogCallback = Callable[[str], None]
57-
5852

5953
class TrajectoryStepTokens(TypedDict):
6054
prompt_ids: list[int]
@@ -145,6 +139,11 @@ def get(self, key: str, default: Any = None) -> Any:
145139
# oai tools
146140
JsonPrimitive = Literal["string", "number", "integer", "boolean", "array", "object"]
147141

142+
# callbacks
143+
StartCallback = Callable[[int], None] # total rollouts
144+
ProgressCallback = Callable[[list[State], list[State]], None] # all_states, new_states
145+
LogCallback = Callable[[str], None] # log messages
146+
148147

149148
class GenerateMetadata(TypedDict):
150149
"""Pydantic model for generation metadata."""

0 commit comments

Comments
 (0)