mb_convert_encoding can output false (#115)

Author: PrinsFrank

.typos.toml

@@ -7,5 +7,6 @@ ignore-hidden = false
 [default.extend-words]
 "flate" = "flate"
 "fo" = "fo"
+"hel" = "hel"
 "paeth" = "paeth"
 "parms" = "parms"

src/Document/Dictionary/DictionaryValue/Date/DateValue.php

@@ -35,7 +35,7 @@ public static function fromValue(string $valueString): ?self {
 
         if (!str_starts_with($valueString, 'D:')) {
             $valueString = mb_convert_encoding($valueString, 'UTF-8', 'UTF-16');
-            if (!str_starts_with($valueString, 'D:')) {
+            if ($valueString === false || !str_starts_with($valueString, 'D:')) {
                 return null;
             }
         }

tests/Unit/Document/Text/ContentStreamParserTest.php

@@ -158,21 +158,21 @@ public function testParseWithMultibyteEscapedStringLiteralDelimiterInStringLiter
                 (new TextObject())
                     ->addContentStreamCommand(new ContentStreamCommand(TextShowingOperator::SHOW, '(Hel' . chr(233) . '\)lo)'))
             ),
-            ContentStreamParser::parse('BT (Hel' . chr(233) .'\)lo) Tj ET')
+            ContentStreamParser::parse('BT (Hel' . chr(233) . '\)lo) Tj ET')
         );
         static::assertEquals(
             new ContentStream(
                 (new TextObject())
                     ->addContentStreamCommand(new ContentStreamCommand(TextShowingOperator::SHOW, '(Hel' . chr(233) . chr(108) . '\)lo)'))
             ),
-            ContentStreamParser::parse('BT (Hel' . chr(233) . chr(108) .'\)lo) Tj ET')
+            ContentStreamParser::parse('BT (Hel' . chr(233) . chr(108) . '\)lo) Tj ET')
         );
         static::assertEquals(
             new ContentStream(
                 (new TextObject())
                     ->addContentStreamCommand(new ContentStreamCommand(TextShowingOperator::SHOW, '(Hel' . chr(233) . chr(108) . chr(58) . '\)lo)'))
             ),
-            ContentStreamParser::parse('BT (Hel' . chr(233) . chr(108) . chr(58) .'\)lo) Tj ET')
+            ContentStreamParser::parse('BT (Hel' . chr(233) . chr(108) . chr(58) . '\)lo) Tj ET')
         );
     }
 

tests/Unit/Document/Text/Encoding/WinAnsiTest.php

@@ -10,6 +10,7 @@
 class WinAnsiTest extends TestCase {
     public function testToUnicode(): void {
         $string = mb_convert_encoding('transakèní', 'Windows-1252');
+        static::assertNotFalse($string);
         static::assertEquals('transakèní', WinAnsi::textToUnicode($string));
     }