Skip to content

Commit 44b33c7

Browse files
committed
workflows: fix quoting
1 parent 02dd119 commit 44b33c7

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

.github/AGENTS.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
minecraft-data-generator extracts and generates Minecraft server-side data for multiple Minecraft versions via a Fabric mod that hooks into the vanilla Minecraft server.
2-
This data that is generated is then stored inside the https://github.com/PrismarineJS/minecraft-data repo, a cross language repo holding minecraft data on blocks, items and more.
2+
This generated data is then stored inside the https://github.com/PrismarineJS/minecraft-data repo, a cross language repo holding minecraft data on blocks, items and more.
33

44
There is a different mod for each Minecraft version this repo supports, under the `mc/<version>` folder.
55
Each version has a Gradle project at `:mc:<version>` and generating the data is done by running the Gradle task:
@@ -12,7 +12,7 @@ Generated data ends up under `mc/<version>/run/server/minecraft-data` in the rep
1212
- mc/ — per-Minecraft-version directories of OUR extractor code (e.g. `mc/1.21.8`)
1313
- versions.json — canonical JSON array of versions that are supported (i.e. there are folders in mc/ for it)
1414
- mc-source/<version> — (External) minecraft java edition code for relevant version with Mojang mappings that you can reference for changes.
15-
* we store the last 2 most recent versions in the folder to save space, but if you need more versions you can do `git fetch origin client1.21.3 && git switch client1.21.3`
15+
* we store the last 2 most recent versions in the folder to save space, but if you need more versions you can do `cd mc-source/1.21.3 && git fetch origin client1.21.3 && git switch client1.21.3` (as these folders are a repo cloned with specific branches)
1616
* there is a .diff file in mc-source/ like `1.21.7_to_1.21.8.diff` that contains result of `git diff --no-index old new` that you can reference for changes (note it's typically large)
1717
* Since our generator is using Mojang mappings, the API naming is the same.
1818
- README.md — info how to set up
@@ -26,7 +26,7 @@ As explained in the README.md, there is an auto update workflow that typically c
2626
These PRs are simply copying old version code into new, so there may be changes and other code fixes needed to support the new version. It's your
2727
job to help plug the gaps by making these changes until the build passes for the given version.
2828
It's also possible that there maybe missing or broken generated data even if the build is passing: in these cases, listen to the user's request
29-
and figure out how to replicate, debug and fix the issues in data generation that may be a logical issue over a syntax one.
29+
and figure out how to replicate, debug and fix the logical issues in data generation.
3030

3131
## Troubleshooting
3232

@@ -36,17 +36,16 @@ generator code.
3636

3737
Sometimes, some APIs might change inside the mc code and make the data that the current code extracts no longer
3838
valid. In these cases, do your best to conform the new data to the old structure even if it feels wrong. If you
39-
can't, for example, let's say something about effects are removed from the game. But our data gen still expects it.
39+
can't, for example, let's say something about effects are removed from the game--but our data gen still expects it.
4040
What to do? You should set the data to null, and inform the user about the issue -- perhaps a schema change is needed.
41-
You can propose a new schema to the user (so that the relevant changes can be made to minecraft-data) and if
42-
user confirms, you'd update the generator to output in that new schema.
41+
You can propose a new schema to the user (so that the relevant changes can be made to minecraft-data) and if the user confirms, you'd update the generator to output in that new schema.
4342

4443
### Steps
4544
- Reproduce the problem locally inside the container and run the generator task.
4645
- Example run command: `./gradlew :mc:1.21.6:runServer --stacktrace`
4746
- See if the problem exists on an older version -- if so inform the user, otherwise compare logs and code
4847
- Inspect diffs in `mc-source/` to correlate Mojang API changes.
49-
- See [mc-source/](mc-source/)
48+
- See mc-source/
5049
- Validate generated output at `mc/<version>/run/server/minecraft-data` to make sure all files are there
5150

5251
---

.github/commands/setupCopilot.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ async function main () {
6767
try {
6868
fs.appendFileSync(ghOut, `success_versions=${JSON.stringify(successes)}\n`)
6969
fs.appendFileSync(ghOut, `failed_versions=${JSON.stringify(failures)}\n`)
70-
fs.appendFileSync(ghOut, `latest_version=${JSON.stringify(latestVersion)}\n`)
71-
fs.appendFileSync(ghOut, `second_latest_version=${JSON.stringify(secondLatestVersion)}\n`)
70+
fs.appendFileSync(ghOut, `latest_version=${latestVersion}\n`)
71+
fs.appendFileSync(ghOut, `second_latest_version=${secondLatestVersion}\n`)
7272
} catch (e) {
7373
console.warn('Could not write to GITHUB_OUTPUT:', e && e.message)
7474
}

0 commit comments

Comments
 (0)