Fix incorrect skyColor in BiomesDataGenerator

[SuperGamerTron]

Incorrect color format was causing the color property in biomes.json to be negative as seen here: https://github.com/PrismarineJS/minecraft-data/blob/15a9880b4b06118ccbdc4f20463582a8410b3295/data/pc/1.21.11/biomes.json

[extremeheat]

You are clamping the number. How does this fix? What is in those upper bits? The only way I can see an overflow is if the color is i64

[SuperGamerTron]

Minecraft now represents colors in json as RGB hex values, which is converted to an opaque/transparent ARGB value before read/write in the codec, so we have to run the transparency operation to get the accurate color.

[extremeheat]

What I mean is that your change doesn't make sense even with RGBA. That's still i32. And I don't see why we shouldn't include alpha channel for color if it's included in vanilla as part of data. Question is, is it overflowing? Because it shouldn't

[extremeheat]

Actually the problem looks to be the cast to integer. That's clamping to a u32 value into signed i32. So seems the fix should be to not do the cast

[SuperGamerTron]

Sorry, I didn't explain it well. There's no overflow and the value is already an i32. It works like this:

// from json
String hexColor = "#6eb1ff";

// read
int rgb = (int) HexFormat.fromHexDigitsToLong(hexColor, 1, hexColor.length()); // 7254527
int argb = rgb | -16777216; // -9522689

// write
rgb = argb & 16777215; // 7254527
hexColor = "#" + HexFormat.of().toHexDigits((long) rgb, 6); // #6eb1ff

https://github.com/extremeheat/extracted_minecraft_data/blob/client1.21.11/client/net/minecraft/world/attribute/EnvironmentAttributes.java#L23
https://github.com/extremeheat/extracted_minecraft_data/blob/client1.21.11/client/net/minecraft/world/attribute/AttributeTypes.java#L21
https://github.com/extremeheat/extracted_minecraft_data/blob/client1.21.11/client/net/minecraft/util/ExtraCodecs.java#L517
https://github.com/extremeheat/extracted_minecraft_data/blob/client1.21.11/client/net/minecraft/util/ExtraCodecs.java#L136-L158
https://github.com/extremeheat/extracted_minecraft_data/blob/client1.21.11/client/net/minecraft/util/ARGB.java#L151-L157

[Copilot]

Pull request overview

This PR fixes incorrect negative color values in biomes.json for Minecraft 1.21.11 by properly masking the sky color to RGB format. The issue arose because Minecraft 1.21.11 changed the API from biome.getSkyColor() to EnvironmentAttributes.SKY_COLOR, and the new API returns integers that include alpha channel bits which need to be masked off.

Changes:

• Applies & 0xFFFFFF mask to skyColor value to strip alpha channel and ensure only RGB components remain

[extremeheat]

I see, thanks for the codelinks. Seems like there is no alpha value for the colors in the data beyond added at runtime