Fix client.end() (#1376)

Author: h5mcbox

src/createServer.js

@@ -46,7 +46,6 @@ function createServer (options = {}) {
   server.onlineModeExceptions = Object.create(null)
   server.favicon = favicon
   server.options = options
-  server._supportFeature = mcData.supportFeature
   options.registryCodec = options.registryCodec || mcData.registryCodec || mcData.loginPacket?.dimensionCodec
 
   // The RSA keypair can take some time to generate

src/server.js

@@ -29,7 +29,7 @@ class Server extends EventEmitter {
       client._end = client.end
       client.end = function end (endReason, fullReason) {
         if (client.state === states.PLAY) {
-          fullReason ||= this._supportFeature('chatPacketsUseNbtComponents')
+          fullReason ||= client._supportFeature('chatPacketsUseNbtComponents')
             ? nbt.comp({ text: nbt.string(endReason) })
             : JSON.stringify({ text: endReason })
           client.write('kick_disconnect', { reason: fullReason })

src/server/handshake.js

@@ -9,15 +9,20 @@ module.exports = function (client, server, { version, fallbackVersion }) {
     client.protocolVersion = packet.protocolVersion
 
     if (version === false) {
-      if (require('minecraft-data')(client.protocolVersion)) {
+      const mcData = require('minecraft-data')(client.protocolVersion)
+      if (mcData) {
         client.version = client.protocolVersion
+        client._supportFeature = mcData.supportFeature
+        client._hasBundlePacket = mcData.supportFeature('hasBundlePacket')
       } else {
         let fallback
         if (fallbackVersion !== undefined) {
           fallback = require('minecraft-data')(fallbackVersion)
         }
         if (fallback) {
           client.version = fallback.version.version
+          client._supportFeature = fallback.supportFeature
+          client._hasBundlePacket = fallback.supportFeature('hasBundlePacket')
         } else {
           client.end('Protocol version ' + client.protocolVersion + ' is not supported')
         }