From 29d11d3dfd14a9b17b869d748576ab82ea27d63b Mon Sep 17 00:00:00 2001 From: SuperGamerTron Date: Tue, 25 Mar 2025 22:11:22 -0600 Subject: [PATCH 1/2] Use new mcdata --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2c80125a..c0ba5431 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,5 +56,6 @@ jobs: distribution: 'adopt' - name: Install dependencies run: npm install + - run: cd node_modules/minecraft-data && mv minecraft-data minecraft-data-old && git clone --depth 1 https://github.com/SuperGamerTron/minecraft-data -b consistent-entity-metadata && node bin/generate_data.js - name: Run tests run: npm run mochaTest -- -g ${{ matrix.mcVersion }}v From 1f3a7686c38031248d430cbdf0d0c1634adcf8c5 Mon Sep 17 00:00:00 2001 From: SuperGamerTron Date: Tue, 25 Mar 2025 22:39:23 -0600 Subject: [PATCH 2/2] Replace feature check with version >= 1.9 check --- test/packetTest.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/packetTest.js b/test/packetTest.js index 7f89b95f..625ad134 100644 --- a/test/packetTest.js +++ b/test/packetTest.js @@ -363,7 +363,7 @@ for (const supportedVersion of mc.supportedVersions) { before(async function () { PORT = await getPort() server = new Server(version.minecraftVersion) - if (mcData.supportFeature('mcDataHasEntityMetadata')) { + if (mcData.version['>=']('1.9')) { values.entityMetadata[0].type = 'byte' } else { values.entityMetadata[0].type = 0