Skip to content

Commit aff7133

Browse files
jrtc27Priyanshu3820
authored andcommitted
[test][Support] Disable SignalsTest.PrintsSymbolizerMarkup (llvm#168974)
This test checks that DSOMarkupPrinter::printDSOMarkup prints the module and segment mappings, but that is only done if we can determine the GNU build ID for the given object, and in many environments that is not enabled by default (e.g. the FreeBSD Clang driver never enables it, and various other Clang drivers only do so when ENABLE_LINKER_BUILD_ID is opted into at configure time). GCC tends to enable it by default, and many distributions enable it for Clang, so this has gone unnoticed for a while, but this test has been failing on FreeBSD since its creation. Fixes: 22b9404 ("Optionally print symbolizer markup backtraces.") See: llvm#168891
1 parent 40aa7fc commit aff7133

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

llvm/unittests/Support/SignalsTest.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ using testing::Not;
3232
#if defined(HAVE_BACKTRACE) && ENABLE_BACKTRACES && \
3333
(defined(__linux__) || defined(__FreeBSD__) || \
3434
defined(__FreeBSD_kernel__) || defined(__NetBSD__))
35+
// Test relies on the binary this test is linked into having a GNU build ID
36+
// note, which is not universally enabled by default (even when using Clang).
37+
// Disable until we can reliably detect whether this is the case and skip it if
38+
// not. See https://github.com/llvm/llvm-project/issues/168891.
39+
#if 0
3540
TEST(SignalsTest, PrintsSymbolizerMarkup) {
3641
auto Exit =
3742
make_scope_exit([]() { unsetenv("LLVM_ENABLE_SYMBOLIZER_MARKUP"); });
@@ -51,6 +56,7 @@ TEST(SignalsTest, PrintsSymbolizerMarkup) {
5156
// Backtrace line
5257
EXPECT_THAT(Res, MatchesRegex(".*" TAG_BEGIN "bt:0:" P_REGEX ".*"));
5358
}
59+
#endif
5460

5561
TEST(SignalsTest, SymbolizerMarkupDisabled) {
5662
auto Exit = make_scope_exit([]() { unsetenv("LLVM_DISABLE_SYMBOLIZATION"); });

0 commit comments

Comments
 (0)