Enhance Makefile and version settings for build-time injection

Author: poupas

farcaster-go/Makefile

@@ -4,8 +4,9 @@ PLATFORMS=linux/arm64,linux/amd64
 VER_MAJOR=$(shell echo ${VERSION} | awk -F'.' '{print $$1}')
 VER_MINOR=$(shell echo ${VERSION} | awk -F'.' '{print $$2}')
 
+COMMIT=$(shell git rev-parse --short HEAD)
 COMPAT_IMAGE=${NAME}-linux-compat
-LDFLAGS=-ldflags "-X main.Version=v${VERSION}"
+LDFLAGS=-ldflags "-X probely.com/farcaster/settings.Version=${VERSION} -X probely.com/farcaster/settings.Commit=${COMMIT}"
 GOFILES := $(shell find . -name '*.go')
 
 .DEFAULT_GOAL: $(NAME)
@@ -19,12 +20,6 @@ fmt:
 vet: fmt
 	go vet ./...
 
-version: check-env
-	@echo '// This file was auto-generated by "make version". Do not change it directly!' > settings/version.go
-	@echo >> settings/version.go
-	@echo 'package settings' >> settings/version.go
-	@echo 'const Version = "${VERSION}"' >> settings/version.go
-
 linux-compat: linux-compat-build linux-compat-extract
 
 linux-compat-build:
@@ -38,15 +33,15 @@ linux-compat-extract: linux-compat-build
 	done
 	docker rm ${NAME}-tmp-container
 
-windows: version
+windows:
 	GOOS=windows GOARCH=amd64 go build ${LDFLAGS} -o bin/${NAME}-windows-amd64.exe
 	GOOS=windows GOARCH=arm64 go build ${LDFLAGS} -o bin/${NAME}-windows-arm64.exe
 
-linux: version
+linux:
 	GOOS=linux GOARCH=amd64 go build ${LDFLAGS} -o bin/${NAME}-linux-amd64
 	GOOS=linux GOARCH=arm64 go build ${LDFLAGS} -o bin/${NAME}-linux-arm64
 
-darwin: version
+darwin:
 	GOOS=darwin GOARCH=amd64 go build ${LDFLAGS} -o bin/${NAME}-darwin-amd64
 	GOOS=darwin GOARCH=arm64 go build ${LDFLAGS} -o bin/${NAME}-darwin-arm64
 
@@ -76,5 +71,5 @@ endif
 	@# VERSION must be a valid semver
 	@echo ${VERSION} | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+$$' || (echo "VERSION must be a valid semver" && exit 1)
 
-.PHONY: version windows linux linux-compat linux-compat-build linux-compat-extract darwin lint
-.PHONY: docker docker-clean docker-prepare version
+.PHONY: windows linux linux-compat linux-compat-build linux-compat-extract darwin lint
+.PHONY: docker docker-clean docker-prepare

farcaster-go/settings/version.go

@@ -1,4 +1,12 @@
 // This file was auto-generated by "make version". Do not change it directly!
 
 package settings
-const Version = "0.0.0"
+
+// Version and Commit are injected at build time via linker flags.
+var (
+	// Version holds the semantic version of the build (e.g. "1.2.3").
+	Version string = "dev"
+
+	// Commit is the short git commit hash corresponding to this build.
+	Commit string = "none"
+)