Skip to content

Commit 7bcc233

Browse files
committed
Fix stale doc example and only check HTTP(S)_PROXY in hasProxyEnv
1 parent 7cd64ff commit 7bcc233

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

farcaster-go/cmd/farcasterd/root.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ func getToken(token string) string {
226226
}
227227

228228
func hasProxyEnv() bool {
229-
for _, k := range []string{"HTTP_PROXY", "http_proxy", "HTTPS_PROXY", "https_proxy", "NO_PROXY", "no_proxy"} {
229+
for _, k := range []string{"HTTP_PROXY", "http_proxy", "HTTPS_PROXY", "https_proxy"} {
230230
if os.Getenv(k) != "" {
231231
return true
232232
}

farcaster-go/dialers/dialers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type ProxyFunc func(addr string) (*url.URL, error)
4545
//
4646
// Example usage:
4747
//
48-
// dialer := dialers.NewTCPProxyDialer(30 * time.Second)
48+
// dialer := dialers.NewTCPProxyDialer(30 * time.Second, log)
4949
// conn, err := dialer.Dial("tcp", "example.com:443")
5050
type TCPProxyDialer struct {
5151
timeout time.Duration

0 commit comments

Comments
 (0)