fix: Update condition to check for empty element in BpmnDocument

caleeli · caleeli · commit 37d3273ef4e8 · 2025-10-02T20:08:55.000-04:00
diff --git a/src/ProcessMaker/Nayra/Storage/BpmnDocument.php b/src/ProcessMaker/Nayra/Storage/BpmnDocument.php
@@ -712,7 +712,7 @@ public function getElementInstanceById($id)
                 ? $element->getBpmnElementInstance()
                 : null
             );
-        if ($this->bpmnElements[$id] === null && $element === null) {
+        if ($this->bpmnElements[$id] === null && empty($element)) {
             throw new ElementNotFoundException($id);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -712,7 +712,7 @@ public function getElementInstanceById($id)`
`712`	`712`	`? $element->getBpmnElementInstance()`
`713`	`713`	`: null`
`714`	`714`	`);`
`715`		`- if ($this->bpmnElements[$id] === null && $element === null) {`
	`715`	`+ if ($this->bpmnElements[$id] === null && empty($element)) {`
`716`	`716`	`throw new ElementNotFoundException($id);`
`717`	`717`	`}`
`718`	`718`