test: add unit coverage for call activity merge helpers

Author: eiresendez

ProcessMaker/Models/CallActivity.php

@@ -116,7 +116,7 @@ protected function completeSubprocess(TokenInterface $token, ExecutionInstanceIn
     /**
      * Decide which data from the subprocess should be merged based on updated keys.
      */
-    private function resolveUpdatedData($store, array $allData): array
+    protected function resolveUpdatedData($store, array $allData): array
     {
         $updatedKeys = method_exists($store, 'getUpdated')
             ? $store->getUpdated()
@@ -138,7 +138,7 @@ private function resolveUpdatedData($store, array $allData): array
     /**
      * Merge keys that exist only in the subprocess data.
      */
-    private function mergeNewKeys(array $data, array $allData, array $parentData): array
+    protected function mergeNewKeys(array $data, array $allData, array $parentData): array
     {
         $newKeys = array_diff(array_keys($allData), array_keys($parentData));
         if (empty($newKeys)) {
@@ -151,7 +151,7 @@ private function mergeNewKeys(array $data, array $allData, array $parentData): a
     /**
      * Merge keys that changed in the subprocess but may not have been tracked.
      */
-    private function mergeChangedKeys(array $data, array $allData, array $parentData): array
+    protected function mergeChangedKeys(array $data, array $allData, array $parentData): array
     {
         $changedKeys = [];
         foreach ($allData as $key => $value) {

tests/unit/ProcessMaker/Models/CallActivityMergeTest.php

@@ -0,0 +1,104 @@
+<?php
+
+namespace Tests\Unit\ProcessMaker\Models;
+
+use PHPUnit\Framework\TestCase;
+use ProcessMaker\Models\CallActivity;
+
+class CallActivityMergeTest extends TestCase
+{
+    private function callActivity(): CallActivity
+    {
+        return new class extends CallActivity {
+            public function callResolveUpdatedData($store, array $allData): array
+            {
+                return $this->resolveUpdatedData($store, $allData);
+            }
+
+            public function callMergeNewKeys(array $data, array $allData, array $parentData): array
+            {
+                return $this->mergeNewKeys($data, $allData, $parentData);
+            }
+
+            public function callMergeChangedKeys(array $data, array $allData, array $parentData): array
+            {
+                return $this->mergeChangedKeys($data, $allData, $parentData);
+            }
+        };
+    }
+
+    public function testResolveUpdatedDataReturnsAllWhenUpdatedIsNull(): void
+    {
+        $store = new class {
+            public function getUpdated()
+            {
+                return null;
+            }
+        };
+
+        $callActivity = $this->callActivity();
+        $all = ['a' => 1, 'b' => 2];
+
+        $result = $callActivity->callResolveUpdatedData($store, $all);
+
+        $this->assertSame($all, $result);
+    }
+
+    public function testResolveUpdatedDataReturnsEmptyWhenUpdatedIsEmptyArray(): void
+    {
+        $store = new class {
+            public function getUpdated(): array
+            {
+                return [];
+            }
+        };
+
+        $callActivity = $this->callActivity();
+        $all = ['a' => 1, 'b' => 2];
+
+        $result = $callActivity->callResolveUpdatedData($store, $all);
+
+        $this->assertSame([], $result);
+    }
+
+    public function testResolveUpdatedDataReturnsOnlyUpdatedKeys(): void
+    {
+        $store = new class {
+            public function getUpdated(): array
+            {
+                return ['b'];
+            }
+        };
+
+        $callActivity = $this->callActivity();
+        $all = ['a' => 1, 'b' => 2, 'c' => 3];
+
+        $result = $callActivity->callResolveUpdatedData($store, $all);
+
+        $this->assertSame(['b' => 2], $result);
+    }
+
+    public function testMergeNewKeysAddsKeysAbsentInParent(): void
+    {
+        $callActivity = $this->callActivity();
+        $data = ['a' => 1];
+        $all = ['a' => 1, 'b' => 2, 'c' => 3];
+        $parent = ['a' => 1];
+
+        $result = $callActivity->callMergeNewKeys($data, $all, $parent);
+
+        $this->assertSame(['a' => 1, 'b' => 2, 'c' => 3], $result);
+    }
+
+    public function testMergeChangedKeysAddsDifferencesNotTracked(): void
+    {
+        $callActivity = $this->callActivity();
+        $data = ['a' => 1]; // already tracked
+        $all = ['a' => 1, 'b' => 99, 'c' => 'new'];
+        $parent = ['a' => 1, 'b' => 2, 'c' => 'old'];
+
+        $result = $callActivity->callMergeChangedKeys($data, $all, $parent);
+
+        $this->assertSame(['a' => 1, 'b' => 99, 'c' => 'new'], $result);
+    }
+}