-
Notifications
You must be signed in to change notification settings - Fork 246
Pull Request Review and Follow up
boliviacoca edited this page Jan 5, 2022
·
3 revisions
Each Developer is responsible for his/her item until merged, so each developer would:
- Assign related PR(s) to a teammate(s), depending on complexity more than 1 reviewer should be assigned, assignations should be done in GIT and announced in The Slack channel.
- Follow up on the review, making sure the PR has been reviewed. Sending reminders to the reviewers as needed.
- Once PR is approved/Reviewed, assign Ryan as reviewer in GIT and let him know is ready for Final review in the slack channel.
In order to keep balance: To perform at least a code review daily would be ideal.
PRs would need to be merged by Friday 14:00 PM BOT, 10 AM Las Vegas, so we do not impact build preparation.