Merge pull request #1788 from ProcessMaker/bugfix/FOUR-21691

FOUR-21691:The values set by calcs in a select list(drop-down) lost after refresh the page

Author: ryancooley

src/components/inspector/options-list.vue

@@ -549,12 +549,19 @@ export default {
       }
       this.optionsList = [];
       const that = this;
-      jsonList.forEach (item => {
-        that.optionsList.push({
-          [that.keyField]: item[that.keyField],
-          [that.valueField]: item[that.valueField],
-          [that.ariaLabelField]: item[that.ariaLabelField]
-        });
+      jsonList.forEach((item) => {
+        if (that.renderAs === "checkbox") {
+          that.optionsList.push({
+            [that.keyField]: item[that.keyField],
+            [that.valueField]: item[that.valueField],
+            [that.ariaLabelField]: item[that.ariaLabelField]
+          });
+        } else {
+          that.optionsList.push({
+            [that.keyField]: item[that.keyField],
+            [that.valueField]: item[that.valueField]
+          });
+        }
       });
       this.jsonError = '';
     },
@@ -582,7 +589,9 @@ export default {
       this.editIndex = index;
       this.optionContent = this.optionsList[index][this.valueField];
       this.optionValue = this.optionsList[index][this.keyField];
-      this.optionAriaLabel = this.optionsList[index][this.ariaLabelField];
+      if (this.renderAs === "checkbox") {
+        this.optionAriaLabel = this.optionsList[index][this.ariaLabelField];
+      }
       this.optionError = '';
     },
     showAddOption() {
@@ -602,22 +611,28 @@ export default {
           this.optionError = 'An item with the same key already exists';
           return;
         }
-        this.optionsList.push(
-          {
+        if (this.renderAs === "checkbox") {
+          this.optionsList.push({
             [this.valueField]: this.optionContent,
             [this.keyField]: this.optionValue,
-            [this.ariaLabelField]: this.optionAriaLabel,
-          }
-        );
-      }
-      else {
+            [this.ariaLabelField]: this.optionAriaLabel
+          });
+        } else {
+          this.optionsList.push({
+            [this.valueField]: this.optionContent,
+            [this.keyField]: this.optionValue
+          });
+        }
+      } else {
         if (this.optionsList.find((item, index) => { return item[that.keyField] === this.optionValue && index !== this.editIndex ; })) {
           this.optionError = 'An item with the same key already exists';
           return;
         }
         this.optionsList[this.editIndex][this.keyField] = this.optionValue;
         this.optionsList[this.editIndex][this.valueField] = this.optionContent;
-        this.optionsList[this.editIndex][this.ariaLabelField] = this.optionAriaLabel;
+        if (this.renderAs === "checkbox") {
+          this.optionsList[this.editIndex][this.ariaLabelField] = this.optionAriaLabel;
+        }
       }
 
       this.jsonData = JSON.stringify(this.optionsList);

tests/e2e/specs/FormSelectList.spec.js

@@ -348,23 +348,23 @@ describe("Form Select List", () => {
     cy.get("[data-cy=inspector-edit-json]").click();
 
     cy.assertComponentValueAsJson('[data-cy="inspector-monaco-json"]', [
-      { content: "one", value: "one", ariaLabel: "" }
+      { content: "one", value: "one" }
     ]);
 
     cy.setVueComponentValue(
       '[data-cy="inspector-monaco-json"]',
       JSON.stringify([
-        { content: "one", value: "one", ariaLabel: "" },
-        { content: "two", value: "two", ariaLabel: "" }
+        { content: "one", value: "one" },
+        { content: "two", value: "two" }
       ])
     );
     cy.get("[data-cy=inspector-monaco-json-expand]").click();
     cy.setVueComponentValue(
       '[data-cy="inspector-monaco-json-expanded"]',
       JSON.stringify(
         [
-          { content: "one", value: "one", ariaLabel: "" },
-          { content: "two", value: "two", ariaLabel: "" }
+          { content: "one", value: "one" },
+          { content: "two", value: "two" }
         ],
         null,
         2