Skip to content

Commit f5e515d

Browse files
authored
Merge pull request #1884 from ProcessMaker/FOUR-28401
FOUR-28401 Issue Identified with Parallel Task Redirect Behavior
2 parents 278aeb6 + 8b9c9f9 commit f5e515d

File tree

5 files changed

+20
-9
lines changed

5 files changed

+20
-9
lines changed

src/components/task.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,11 @@ export default {
887887
* @param {Object} data - The event data containing the tokenId of the task.
888888
*/
889889
async handleRedirectToTask(data) {
890-
if (data?.params[0]?.tokenId) {
890+
if (
891+
(data?.params[0]?.tokenId &&
892+
this.task.user?.id === data.params[0]?.userId) ||
893+
this.task.elementDestination?.type === 'taskSource'
894+
) {
891895
this.loadingTask = true;
892896
// Check if interstitial tasks are allowed for this task.
893897
if (this.task && !(this.task.allow_interstitial || this.isSameUser(this.task, data))) {

tests/e2e/specs/ComplexScreen.spec.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -761,9 +761,15 @@ describe("Complex screen", () => {
761761
cy.get("[data-cy=preview-content] [name=form_checkbox_6]").should(
762762
"be.checked"
763763
);
764-
cy.get("[data-cy=preview-content] [name=form_select_list_3]").eq(1).click();
765-
cy.get("[data-cy=preview-content] [name=form_select_list_4]").eq(1).click(); // Select b
766-
cy.get("[data-cy=preview-content] [name=form_select_list_4]").eq(2).click(); // Select c
764+
cy.get(
765+
'[data-cy=preview-content] [id^="form_select_list_3-b-"]'
766+
).click();
767+
cy.get(
768+
'[data-cy=preview-content] [id^="form_select_list_4-b-"]'
769+
).click(); // Select b
770+
cy.get(
771+
'[data-cy=preview-content] [id^="form_select_list_4-c-"]'
772+
).click(); // Select c
767773
// record list - complete new fields
768774
cy.get(
769775
"[data-cy=preview-content] [data-cy=screen-field-form_record_list_1] [data-cy=edit-row]"

tests/e2e/specs/SelectListWatcher.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ describe("SelectList - Watcher", () => {
5151

5252
// Select "John" option in radio buttons "form_select_list_2"
5353
cy.get(
54-
"[data-cy=preview-content] [name=form_select_list_2][value=John]"
54+
'[data-cy=preview-content] [id^="form_select_list_2-John-"]'
5555
).click();
5656

5757
// Select "Mary" option in select list "form_select_list_3"
@@ -78,7 +78,7 @@ describe("SelectList - Watcher", () => {
7878

7979
// Select "John" option in radio buttons "form_select_list_2"
8080
cy.get(
81-
"[data-cy=preview-content] [name=form_select_list_2][value=John]"
81+
'[data-cy=preview-content] [id^="form_select_list_2-John-"]'
8282
).click();
8383

8484
// Select "Mary" option in select list "form_select_list_3"

tests/e2e/specs/SingleSelectWithInvalidValue.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ describe("single select with invalid initial value", () => {
2323
cy.setPreviewDataInput({ person: [] });
2424
cy.get("[data-cy=mode-preview]").click();
2525

26-
cy.get("[data-cy=preview-content] [name=person]").eq(0).click();
27-
cy.get("[data-cy=preview-content] [name=person]").eq(1).click();
28-
cy.get("[data-cy=preview-content] [name=person]").eq(0).click();
26+
cy.get('[data-cy=preview-content] [id^="person-one-"]').click();
27+
cy.get('[data-cy=preview-content] [id^="person-two-"]').click();
28+
cy.get('[data-cy=preview-content] [id^="person-one-"]').click();
2929

3030
// Check the data of the screen
3131
cy.assertPreviewData({

tests/e2e/specs/Task.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -916,6 +916,7 @@ describe("Task component", () => {
916916
completed_at: moment().toISOString(),
917917
due_at: moment().add(1, "day").toISOString(),
918918
user: {
919+
id: 1,
919920
avatar: "",
920921
fullname: "Assigned User"
921922
},

0 commit comments

Comments
 (0)