Cast subject page to a Title if it isn't one (#827)

* Cast subject page to a Title if it isn't one

This fixes "TypeError: Maps\MapsFactory::newSemanticGeoJsonStore(): Argument #2 ($subjectPage) must be of type MediaWiki\Title\Title, MediaWiki\Page\PageIdentityValue given"
Raise MW requirement to 1.41.

* Raise MW requirement to 1.43

1.40-1.42 have been EOL for a while.
Also remove redundant PHP requirement, since MW 1.43 requires PHP 8.

* Only run CI on MW 1.43, 1.44 and master

Author: SomeMWDev

.github/workflows/ci.yml

@@ -14,21 +14,12 @@ jobs:
     strategy:
       matrix:
         include:
-          - mw: 'REL1_40'
-            php: 7.4
-            experimental: false
-          - mw: 'REL1_40'
-            php: 8.0
-            experimental: false
-          - mw: 'REL1_41'
-            php: 8.1
-            experimental: false
-          - mw: 'REL1_42'
-            php: 8.2
-            experimental: false
           - mw: 'REL1_43'
             php: 8.3
             experimental: false
+          - mw: 'REL1_44'
+            php: 8.3
+            experimental: false
           - mw: 'master'
             php: 8.4
             experimental: true
@@ -83,13 +74,11 @@ jobs:
 
       - name: Run PHPUnit
         run: php tests/phpunit/phpunit.php -c extensions/Maps
-        if: matrix.mw != 'REL1_43'
 
       - name: Run PHPUnit with code coverage
         run: |
           php tests/phpunit/phpunit.php -c extensions/Maps --coverage-clover coverage.xml
           bash <(curl -s https://codecov.io/bash)
-        if: matrix.mw == 'REL1_43'
 
 
 #  Psalm:

extension.json

@@ -12,10 +12,7 @@
 	"type": "parserhook",
 
 	"requires": {
-		"MediaWiki": ">= 1.40.0",
-		"platform": {
-			"php": ">= 7.4"
-		}
+		"MediaWiki": ">= 1.43.0"
 	},
 
 	"AutoloadNamespaces": {

src/GeoJsonPages/GeoJsonContentHandler.php

@@ -8,6 +8,7 @@
 use Maps\MapsFactory;
 use Maps\Presentation\OutputFacade;
 use MediaWiki\Content\Renderer\ContentParseParams;
+use MediaWiki\Title\Title;
 use ParserOutput;
 
 class GeoJsonContentHandler extends \JsonContentHandler {
@@ -47,8 +48,13 @@ protected function fillParserOutput(
 				// to avoid decoding it again in SubObjectBuilder -> getSubObjectsFromGeoJson
 				$text = json_encode( $content->getData()->getValue() );
 
+				$subjectPage = $cpoParams->getPage();
+				if ( !$subjectPage instanceof Title ) {
+					// all underlying methods expect a Title, so cast it to one
+					$subjectPage = Title::newFromPageReference( $subjectPage );
+				}
 				MapsFactory::globalInstance()
-					->newSemanticGeoJsonStore( $parserOutput, $cpoParams->getPage() )
+					->newSemanticGeoJsonStore( $parserOutput, $subjectPage )
 					->storeGeoJson( $text );
 			}