Skip to content

Commit f15a7a2

Browse files
author
Salim Terres
committed
Bug #15363 && Bug #15398 - [Search + Collect] When saving a search with multiple filters, only one filter is retained && [Search] Default filter "Archives with objects" gets unchecked.
1 parent a39b8fc commit f15a7a2

File tree

9 files changed

+110
-27
lines changed

9 files changed

+110
-27
lines changed

‎ui/ui-frontend/projects/archive-search/src/app/archive/archive-search/additional-actions-search/management-rules/management-rules.component.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ import {
6262
RuleCategoryAction,
6363
RuleSearchCriteriaDto,
6464
} from '../../../models/ruleAction.interface';
65+
import { Location } from '@angular/common';
6566

6667
const ARCHIVE_UNIT_HOLDING_UNIT = 'ARCHIVE_UNIT_HOLDING_UNIT';
6768

@@ -167,6 +168,7 @@ export class ManagementRulesComponent implements OnInit, OnChanges, OnDestroy {
167168
public dialog: MatDialog,
168169
private route: ActivatedRoute,
169170
private router: Router,
171+
private location: Location,
170172
private translate: TranslateService,
171173
private logger: Logger,
172174
private ruleService: RuleService,
@@ -662,7 +664,7 @@ export class ManagementRulesComponent implements OnInit, OnChanges, OnDestroy {
662664
.pipe(filter((result) => !!result))
663665
.subscribe(() => {
664666
this.initializeParameters();
665-
this.router.navigate(['/archive-search/tenant/', this.tenantIdentifier]);
667+
this.location.back();
666668
}),
667669
);
668670
}

‎ui/ui-frontend/projects/archive-search/src/app/archive/archive-search/archive-search.component.spec.ts‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
* The fact that you are presently reading this means that you have had
3535
* knowledge of the CeCILL-C license and that you accept its terms.
3636
*/
37+
import { Location } from '@angular/common';
3738
import { provideHttpClientTesting } from '@angular/common/http/testing';
3839
import { NO_ERRORS_SCHEMA } from '@angular/core';
3940
import { ComponentFixture, TestBed } from '@angular/core/testing';
@@ -129,7 +130,13 @@ describe('ArchiveSearchComponent', () => {
129130
};
130131

131132
const setupTest = async (queryParams: Params) => {
132-
const routerSpy = jasmine.createSpyObj('Router', ['navigate']);
133+
const routerSpy = jasmine.createSpyObj('Router', ['navigate', 'createUrlTree', 'serializeUrl', 'parseUrl']);
134+
routerSpy.createUrlTree.and.returnValue({});
135+
routerSpy.serializeUrl.and.returnValue('/test-url');
136+
routerSpy.parseUrl.and.returnValue({ queryParams: {} });
137+
138+
const locationSpy = jasmine.createSpyObj('Location', ['replaceState', 'path']);
139+
locationSpy.path.and.returnValue('/test-url');
133140

134141
spyOn(archiveServiceStub, 'searchArchiveUnitsByCriteria').and.callThrough();
135142

@@ -157,6 +164,7 @@ describe('ArchiveSearchComponent', () => {
157164
{ provide: ArchiveUnitEliminationService, useValue: archiveUnitEliminationServiceMock },
158165
{ provide: BASE_URL, useValue: '/fake-api' },
159166
{ provide: ComputeInheritedRulesService, useValue: computeInheritedRulesServiceMock },
167+
{ provide: Location, useValue: locationSpy },
160168
{ provide: MatDialog, useValue: matDialogSpy },
161169
{ provide: Router, useValue: routerSpy },
162170
{ provide: SchemaService, useValue: { getDescriptiveSchemaTree: () => of(), getSchema: () => of([]) } },

‎ui/ui-frontend/projects/archive-search/src/app/archive/archive-search/archive-search.component.ts‎

Lines changed: 30 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -421,13 +421,13 @@ export class ArchiveSearchComponent implements OnInit, OnChanges, OnDestroy, Aft
421421
this.searchCriterias = new Map();
422422
this.searchCriteriaKeys = [];
423423

424-
if (!this.route.snapshot.queryParamMap.keys.length) {
425-
this.queryParamsService
426-
.builder()
427-
.addQueryParam('archiveUnitType', 'ARCHIVE_UNIT_WITH_OBJECTS')
428-
.addQueryParam('archiveUnitType', 'ARCHIVE_UNIT_WITHOUT_OBJECTS')
429-
.navigate({ replaceUrl: true });
430-
}
424+
// Always reset to default filters on page load/reload
425+
this.queryParamsService.setQueryParams(
426+
{
427+
archiveUnitType: [encodeURIComponent('ARCHIVE_UNIT_WITH_OBJECTS'), encodeURIComponent('ARCHIVE_UNIT_WITHOUT_OBJECTS')].join(','),
428+
},
429+
{ replaceUrl: true, queryParamsHandling: '' },
430+
);
431431

432432
const searchCriteriaChange = merge(this.orderChange, this.filterChange).pipe(debounceTime(FILTER_DEBOUNCE_TIME_MS));
433433
searchCriteriaChange.subscribe(() => {
@@ -767,6 +767,9 @@ export class ArchiveSearchComponent implements OnInit, OnChanges, OnDestroy, Aft
767767
this.subscribeResetNodesOnFilingHoldingNodesChanges();
768768
this.recursiveCheck(this.nodeArray, false);
769769

770+
// Collect all criteria to update URL at once
771+
const criteriaToAddToUrl: any[] = [];
772+
770773
storedSearchCriteriaHistory.searchCriteriaList.forEach((criteria: SearchCriteriaEltements) => {
771774
this.fillTreeNodeAsSearchCriteriaHistory(criteria);
772775

@@ -789,10 +792,29 @@ export class ArchiveSearchComponent implements OnInit, OnChanges, OnDestroy, Aft
789792
category,
790793
criteria.valueTranslated,
791794
criteria.dataType,
792-
true,
795+
false,
793796
);
797+
798+
// Collect criteria for URL update (only FIELDS and NODES categories)
799+
if ([SearchCriteriaTypeEnum.FIELDS, SearchCriteriaTypeEnum.NODES].includes(category)) {
800+
criteriaToAddToUrl.push({
801+
keyElt: criteria.criteria,
802+
valueElt: value,
803+
labelElt: value.value,
804+
keyTranslated: criteria.keyTranslated,
805+
operator: criteria.operator,
806+
category,
807+
valueTranslated: criteria.valueTranslated,
808+
dataType: criteria.dataType,
809+
});
810+
}
794811
});
795812
});
813+
814+
// Update URL with all restored criteria at once
815+
if (criteriaToAddToUrl.length > 0) {
816+
this.archiveSharedDataService.addSimpleSearchCriteriaSubjects(criteriaToAddToUrl);
817+
}
796818
}
797819

798820
fillTreeNodeAsSearchCriteriaHistory(searchCriteriaList: SearchCriteriaEltements) {

‎ui/ui-frontend/projects/archive-search/src/app/archive/common-services/update-unit-management-rule.service.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,10 @@ export class UpdateUnitManagementRuleService {
165165
this.managementRulesSharedDataService.emitCriteriaSearchListToSave(criteriaSearchList);
166166
this.managementRulesSharedDataService.emitCriteriaSearchDSLQuery(criteriaSearchDSLQueryToSend);
167167

168-
router.navigate(['/archive-search/update-rules/tenant/', tenantIdentifier]);
168+
// Navigate preserving query params in URL to maintain browser history
169+
router.navigate(['/archive-search/update-rules/tenant/', tenantIdentifier], {
170+
queryParamsHandling: 'preserve',
171+
});
169172
}
170173
});
171174
}

‎ui/ui-frontend/projects/archive-search/src/app/core/archive-shared-data.service.ts‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,9 @@ export class ArchiveSharedDataService {
237237
}
238238
this.simpleSearchCriteriaAddSubject.next(searchCriteria);
239239
});
240-
builder.navigate();
240+
241+
// Update URL with query params and create history entry
242+
builder.navigate({ replaceUrl: false });
241243
}
242244

243245
addSimpleSearchCriteriaSubject(searchCriteria: SearchCriteriaAddAction) {
@@ -304,7 +306,9 @@ export class ArchiveSharedDataService {
304306
: `${searchCriteriaAction.valueElt.value}/${searchCriteriaAction.valueElt.virtualNodeRealParentId}/${searchCriteriaAction.valueElt.virtualNodeRealParentTitle}`;
305307
builder.removeQueryParam(searchCriteriaAction.valueElt.id, valueToRemove);
306308
this.searchCriteriaRemoveFromChildSubject.next(searchCriteriaAction);
307-
builder.navigate();
309+
310+
// Update URL with query params and create history entry
311+
builder.navigate({ replaceUrl: false });
308312
}
309313

310314
receiveRemoveFromChildSearchCriteriaSubject(): Observable<SearchCriteriaRemoveAction> {

‎ui/ui-frontend/projects/collect/src/app/collect/archive-search-collect/archive-search-collect.component.spec.ts‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
* The fact that you are presently reading this means that you have had
3535
* knowledge of the CeCILL-C license and that you accept its terms.
3636
*/
37+
import { Location } from '@angular/common';
3738
import { provideHttpClientTesting } from '@angular/common/http/testing';
3839
import { ComponentFixture, TestBed } from '@angular/core/testing';
3940
import { MatDialog } from '@angular/material/dialog';
@@ -134,7 +135,13 @@ describe('ArchiveSearchCollectComponent', () => {
134135
};
135136

136137
const setupTest = async (queryParams: Params, withSimpleCriteria = false) => {
137-
const routerSpy = jasmine.createSpyObj('Router', ['navigate']);
138+
const routerSpy = jasmine.createSpyObj('Router', ['navigate', 'createUrlTree', 'serializeUrl', 'parseUrl']);
139+
routerSpy.createUrlTree.and.returnValue({});
140+
routerSpy.serializeUrl.and.returnValue('/test-url');
141+
routerSpy.parseUrl.and.returnValue({ queryParams: {} });
142+
143+
const locationSpy = jasmine.createSpyObj('Location', ['replaceState', 'path']);
144+
locationSpy.path.and.returnValue('/test-url');
138145

139146
spyOn(archiveCollectServiceStub, 'searchArchiveUnitsByCriteria').and.callThrough();
140147

@@ -164,6 +171,7 @@ describe('ArchiveSearchCollectComponent', () => {
164171
{ provide: BASE_URL, useValue: '/fake-api' },
165172
{ provide: ConfigService, useValue: { config$: of() } },
166173
{ provide: ExternalParametersService, useValue: externalParametersServiceStub },
174+
{ provide: Location, useValue: locationSpy },
167175
{ provide: MatDialog, useValue: matDialogSpy },
168176
{ provide: Router, useValue: routerSpy },
169177
{ provide: SchemaService, useValue: { getDescriptiveSchemaTree: () => of(), getSchema: () => of([]) } },

‎ui/ui-frontend/projects/collect/src/app/collect/archive-search-collect/archive-search-collect.component.ts‎

Lines changed: 30 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -380,13 +380,13 @@ export class ArchiveSearchCollectComponent extends SidenavPage<any> implements O
380380
}),
381381
);
382382

383-
if (!this.route.snapshot.queryParamMap.keys.length) {
384-
this.queryParamsService
385-
.builder()
386-
.addQueryParam('archiveUnitType', 'ARCHIVE_UNIT_WITH_OBJECTS')
387-
.addQueryParam('archiveUnitType', 'ARCHIVE_UNIT_WITHOUT_OBJECTS')
388-
.navigate({ replaceUrl: true });
389-
}
383+
// Always reset to default filters on page load/reload
384+
this.queryParamsService.setQueryParams(
385+
{
386+
archiveUnitType: [encodeURIComponent('ARCHIVE_UNIT_WITH_OBJECTS'), encodeURIComponent('ARCHIVE_UNIT_WITHOUT_OBJECTS')].join(','),
387+
},
388+
{ replaceUrl: true, queryParamsHandling: '' },
389+
);
390390

391391
this.subscriptions.add(
392392
merge(this.orderChange, this.filterChange)
@@ -1160,6 +1160,9 @@ export class ArchiveSearchCollectComponent extends SidenavPage<any> implements O
11601160
// this.setFilingHoldingScheme();
11611161
// this.checkAllNodes(false);
11621162

1163+
// Collect all criteria to update URL at once
1164+
const criteriaToAddToUrl: any[] = [];
1165+
11631166
storedSearchCriteriaHistory.searchCriteriaList.forEach((criteria: SearchCriteriaEltements) => {
11641167
this.fillTreeNodeAsSearchCriteriaHistory(criteria);
11651168

@@ -1182,10 +1185,29 @@ export class ArchiveSearchCollectComponent extends SidenavPage<any> implements O
11821185
category,
11831186
criteria.valueTranslated,
11841187
criteria.dataType,
1185-
true,
1188+
false,
11861189
);
1190+
1191+
// Collect criteria for URL update (only FIELDS and NODES categories)
1192+
if ([SearchCriteriaTypeEnum.FIELDS, SearchCriteriaTypeEnum.NODES].includes(category)) {
1193+
criteriaToAddToUrl.push({
1194+
keyElt: criteria.criteria,
1195+
valueElt: value,
1196+
labelElt: value.value,
1197+
keyTranslated: criteria.keyTranslated,
1198+
operator: criteria.operator,
1199+
category,
1200+
valueTranslated: criteria.valueTranslated,
1201+
dataType: criteria.dataType,
1202+
});
1203+
}
11871204
});
11881205
});
1206+
1207+
// Update URL with all restored criteria at once
1208+
if (criteriaToAddToUrl.length > 0) {
1209+
this.archiveSharedDataService.addSimpleSearchCriteriaSubjects(criteriaToAddToUrl);
1210+
}
11891211
}
11901212

11911213
fillTreeNodeAsSearchCriteriaHistory(searchCriteriaList: SearchCriteriaEltements) {

‎ui/ui-frontend/projects/collect/src/app/collect/core/archive-shared-data.service.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,8 @@ export class ArchiveSharedDataService {
232232
}
233233
this.simpleSearchCriteriaAddSubject.next(searchCriteria);
234234
});
235-
builder.navigate();
235+
// Update URL with query params and create history entry
236+
builder.navigate({ replaceUrl: false });
236237
}
237238

238239
addSimpleSearchCriteriaSubject(searchCriteria: SearchCriteriaAddAction) {
@@ -271,7 +272,9 @@ export class ArchiveSharedDataService {
271272
: `${searchCriteriaAction.valueElt.value}/${searchCriteriaAction.valueElt.virtualNodeRealParentId}/${searchCriteriaAction.valueElt.virtualNodeRealParentTitle}`;
272273
builder.removeQueryParam(searchCriteriaAction.valueElt.id, valueToRemove);
273274
this.searchCriteriaRemoveFromChildSubject.next(searchCriteriaAction);
274-
builder.navigate();
275+
276+
// Update URL with query params and create history entry
277+
builder.navigate({ replaceUrl: false });
275278
}
276279

277280
receiveRemoveFromChildSearchCriteriaSubject(): Observable<SearchCriteriaRemoveAction> {

‎ui/ui-frontend/projects/vitamui-library/src/app/modules/url/query-params.service.ts‎

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
* knowledge of the CeCILL-C license and that you accept its terms.
3636
*/
3737
import { Injectable } from '@angular/core';
38+
import { Location } from '@angular/common';
3839
import { ActivatedRoute, NavigationExtras, Params, Router } from '@angular/router';
3940
import { Observable } from 'rxjs';
4041
import { fromPromise } from 'rxjs/internal/observable/innerFrom';
@@ -43,9 +44,14 @@ class QueryParamBuilder {
4344
#queryParams: Params = {};
4445
constructor(
4546
private router: Router,
46-
route: ActivatedRoute,
47+
private location: Location,
4748
) {
48-
this.#queryParams = { ...route.snapshot.queryParams };
49+
// Use location.path() to get current URL params instead of router.url
50+
// This ensures we get the most up-to-date params, even after Location.replaceState() calls
51+
// router.url is not updated by Location.replaceState(), but location.path() is
52+
const currentPath = this.location.path();
53+
const currentUrlTree = this.router.parseUrl(currentPath);
54+
this.#queryParams = { ...currentUrlTree.queryParams };
4955
}
5056

5157
addQueryParam(key: string, value: string): this {
@@ -62,6 +68,10 @@ class QueryParamBuilder {
6268
return this;
6369
}
6470

71+
getQueryParams(): Params {
72+
return { ...this.#queryParams };
73+
}
74+
6575
navigate(extras: NavigationExtras = {}): Observable<boolean> {
6676
return fromPromise(
6777
this.router.navigate([], {
@@ -79,6 +89,7 @@ export class QueryParamsService {
7989
constructor(
8090
private router: Router,
8191
private route: ActivatedRoute,
92+
private location: Location,
8293
) {}
8394

8495
setQueryParams(
@@ -97,7 +108,7 @@ export class QueryParamsService {
97108
}
98109

99110
builder() {
100-
return new QueryParamBuilder(this.router, this.route);
111+
return new QueryParamBuilder(this.router, this.location);
101112
}
102113

103114
getQueryParams(): Observable<Params> {

0 commit comments

Comments
 (0)