Skip to content

Improve validation result type #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2024
Merged

Improve validation result type #10

merged 2 commits into from
Dec 4, 2024

Conversation

johanbook
Copy link
Collaborator

@johanbook johanbook commented Dec 3, 2024 •
edited
Loading

A small improvement to the validation type so one can do

    const { data, isValid } = form.validate();

    if (!isValid) {
      return;
    }
 
   // `data` is now inferred to be non-null

@johanbook johanbook requested a review from agjs December 3, 2024 15:49
agjs
agjs approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@agjs agjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome, @johanbook! Thank you!

@agjs agjs merged commit 76215de into master Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agjs agjs agjs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johanbook @agjs