Merge pull request #550 from ProgressPlanner/filip/v17/fix-user-task-new-line

Prevent adding new lines in user task titles

Author: aristath

CHANGELOG.md

@@ -3,6 +3,7 @@
 Bugs we fixed:
 
 * Fix issue where "Perform all updates" task was incorrectly marked as completed.
+* Prevent new lines to be added when user task title is edited.
 
 
 = 1.6.2 =

assets/js/suggested-task.js

@@ -495,6 +495,19 @@ prplSuggestedTask = {
 		}, 300 );
 	},
 
+	/**
+	 * Prevent Enter key in contenteditable elements.
+	 *
+	 * @param {Event} event The keydown event.
+	 */
+	preventEnterKey: ( event ) => {
+		if ( event.key === 'Enter' ) {
+			event.preventDefault();
+			event.stopPropagation();
+			return false;
+		}
+	},
+
 	/**
 	 * Get the task element.
 	 *

views/js-templates/suggested-task.html

@@ -21,7 +21,7 @@
 		<# } #>
 
 		<h3 style="width: 100%;">
-			<span <# if ( 'user' === categorySlug ) { #>contenteditable="plaintext-only" onkeydown="prplSuggestedTask.updateTaskTitle( this );" data-post-id="{{ data.post.id }}"<# } #>><# if ( data.post.meta.prpl_url ) { #><a href="{{{ data.post.meta.prpl_url }}}" target="{{{ data.post.meta.prpl_url_target }}}">{{{ data.post.title.rendered }}}</a><# } else if ( data.post.meta.prpl_popover_id ) { #><a href="#" role="button" onclick="document.getElementById('{{{ data.post.meta.prpl_popover_id }}}')?.showPopover()">{{{ data.post.title.rendered }}}</a><# } else { #>{{{ data.post.title.rendered }}}<# } #></span>
+			<span <# if ( 'user' === categorySlug ) { #>contenteditable="plaintext-only" onkeydown="prplSuggestedTask.preventEnterKey( event ); prplSuggestedTask.updateTaskTitle( this );" data-post-id="{{ data.post.id }}"<# } #>><# if ( data.post.meta.prpl_url ) { #><a href="{{{ data.post.meta.prpl_url }}}" target="{{{ data.post.meta.prpl_url_target }}}">{{{ data.post.title.rendered }}}</a><# } else if ( data.post.meta.prpl_popover_id ) { #><a href="#" role="button" onclick="document.getElementById('{{{ data.post.meta.prpl_popover_id }}}')?.showPopover()">{{{ data.post.title.rendered }}}</a><# } else { #>{{{ data.post.title.rendered }}}<# } #></span>
 		</h3>
 
 		<div class="prpl-suggested-task-actions">