Skip to content

Commit 6b289b4

Browse files
Fix #25: DeSelection of skills in SkillSection
1 parent b0e6c92 commit 6b289b4

File tree

1 file changed

+39
-22
lines changed

1 file changed

+39
-22
lines changed

Frontend/components/SkillSection.js

Lines changed: 39 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -46,29 +46,46 @@ function SkillSection(props) {
4646
paddingStart: 4,
4747
marginTop: 12,
4848
}}>
49-
{searchTerm.length > 0 &&
50-
getFilteredSkills().map((skill, index) => {
51-
return (
52-
<Chip
53-
key={skill.skill_id}
54-
onPress={() => {
55-
if (skills.some(s => s.skill_id === skill.skill_id)) {
56-
setSkills(
57-
skills.filter(s => s.skill_id !== skill.skill_id),
49+
{searchTerm.length > 0
50+
? getFilteredSkills().map((skill, index) => {
51+
return (
52+
<Chip
53+
key={skill.skill_id}
54+
onPress={() => {
55+
if (skills.some(s => s.skill_id === skill.skill_id)) {
56+
setSkills(
57+
skills.filter(s => s.skill_id !== skill.skill_id),
58+
);
59+
} else {
60+
setSkills(skills.concat(skill));
61+
}
62+
}}
63+
selected={skills.some(s => s.skill_id === skill.skill_id)}
64+
style={{
65+
marginEnd: 8,
66+
marginBottom: 8,
67+
}}>
68+
{skill.skill_name}
69+
</Chip>
70+
);
71+
})
72+
: skills.map((skill, index) => {
73+
return (
74+
<Chip
75+
key={index}
76+
onPress={() => {
77+
const newSkills = skills.filter(
78+
it => it.skill_id !== skill.skill_id,
5879
);
59-
} else {
60-
setSkills(skills.concat(skill));
61-
}
62-
}}
63-
selected={skills.some(s => s.skill_id === skill.skill_id)}
64-
style={{
65-
marginEnd: 8,
66-
marginBottom: 8,
67-
}}>
68-
{skill.skill_name}
69-
</Chip>
70-
);
71-
})}
80+
setSkills(newSkills);
81+
}}
82+
style={{margin: 4}}
83+
icon="close"
84+
selected={true}>
85+
{skill.skill_name}
86+
</Chip>
87+
);
88+
})}
7289
</View>
7390
{searchTerm.length === 0 &&
7491
skillList.map((domain, index) => (

0 commit comments

Comments
 (0)