Skip to content

Commit 33e12ac

Browse files
committed
Refactor: move RECOMMENDED_PACKAGES to module level
Signed-off-by: Mohammad Amanour Rahman <[email protected]>
1 parent 3d3b0cc commit 33e12ac

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

monai/data/image_writer.py

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,16 @@
3737
require_pkg,
3838
)
3939

40+
RECOMMENDED_PACKAGES = {
41+
"png": "Pillow",
42+
"jpg": "Pillow",
43+
"jpeg": "Pillow",
44+
"nii": "nibabel or SimpleITK",
45+
"niigz": "nibabel or SimpleITK",
46+
"nrrd": "pynrrd",
47+
"tif": "Pillow or tifffile",
48+
"tiff": "Pillow or tifffile",
49+
}
4050
DEFAULT_FMT = "%(asctime)s %(levelname)s %(filename)s:%(lineno)d - %(message)s"
4151
EXT_WILDCARD = "*"
4252
logger = get_logger(module_name=__name__, fmt=DEFAULT_FMT)
@@ -116,24 +126,13 @@ def resolve_writer(ext_name, error_if_not_found=True) -> Sequence:
116126
except Exception: # other writer init errors indicating it exists
117127
avail_writers.append(_writer)
118128
if not avail_writers and error_if_not_found:
119-
recommended_packages = {
120-
"png": "Pillow",
121-
"jpg": "Pillow",
122-
"jpeg": "Pillow",
123-
"nii": "nibabel or SimpleITK",
124-
"nii.gz": "nibabel or SimpleITK",
125-
"nrrd": "pynrrd",
126-
"tif": "Pillow or tifffile",
127-
"tiff": "Pillow or tifffile",
128-
}
129-
130129
fmt_clean = fmt.lower()
131-
package_hint = recommended_packages.get(fmt_clean, "")
130+
package_hint = RECOMMENDED_PACKAGES.get(fmt_clean, "")
132131

133132
msg = f"No ImageWriter backend found for {fmt}."
134133
if package_hint:
135134
msg += f" Please install '{package_hint}' (e.g., pip install {package_hint})."
136-
135+
137136
raise OptionalImportError(msg)
138137

139138
writer_tuple = ensure_tuple(avail_writers)

0 commit comments

Comments
 (0)