TypeSetting ResNetBlock

[vikashg]

Hi, I am trying to understand the ResNet implementation and I am struggling with this one line
block: Type[Union[ResNetBlock, ResNetBottleneck]],
Resnet Implementation
As far as I understand the variable block can be of type either ResNetBlock or ResNetBottleneck. However, I am curious what does Type do in this context. Should it not be NewType or TypeVar. More info here

[Nic-Ma]

Hi @vikashg ,

Thanks for your interest here and feedback, I think it's a typo, let me try to update it ASAP.

[Nic-Ma]

OK, so I think we don't need to change anything so far, right?

Thanks.

[vikashg]

It is working fine indeed. So I don't think there is any need to change.

[ericspod]

In general we'll have to update places Type is used eventually. In this case however I think the line should be block: Union[ResNetBlock, ResNetBottleneck] since block is an instance of one of these types rather than an instance of a type class.

[Nic-Ma]

Hi @ericspod ,

I think in this case, the block is a class instead of an instance, so we used the Type:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/networks/nets/resnet.py#L340
Right?

Thanks.

[ericspod]

Ah yes that's actually a type, so yes Type is what to use.