Replies: 3 comments 8 replies
-
Hi @ellisdg, thanks for your interest and suggestion here. MONAI/monai/metrics/meandice.py Lines 30 to 32 in a4e4894 Additionally, when only single-channel class indices exist, we can also specify whether to include background. MONAI/monai/metrics/meandice.py Lines 253 to 258 in a4e4894 I hope it helps, thanks! |
Beta Was this translation helpful? Give feedback.
-
It has been convention that background was always channel 0 and this has made sense for the segmentation that we've been doing. I can see other applications where there is no background as described here so changing the name probably should be done, eg. "include_channel_zero" or something like that. This variable name is one of those, shall we say, "historical" parts of MONAI. I would still be explicit in documentation and elsewhere that the background channel is channel 0 if any. |
Beta Was this translation helpful? Give feedback.
-
I believe that using "include_channel_zero" as an alternative to "include_background" may not be the best choice due to the loss of argument semantics. In contrast, the name "include_background" directly conveys the purpose of this argument to the user. The core issue of original post is that the channel of background is confusing. One potential solution could be to introduce an optional argument, such as |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
In many of the loss classes and metrics in MONAI, the creators have put in an argument named
include_background
. To my understanding, what this argument does is include the first channel in the computations, if True, and exclude the first channel in the computations, if False.I have a few issues with the naming of the
include_background
argument:include_background=True
, which is counter-intuitive because there is no background to be included.Therefore, why isn't the argument called
include_first_channel
instead? This name says what theinclude_background
argument actually does.Beta Was this translation helpful? Give feedback.
All reactions