DICOM Seg Writer operater: Fix for case where input image is already a numpy array #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Bridge <[email protected]>
CPBridge
force-pushed
the
bug/dicom_seg_operator_numpy_input
branch
from
668e24f to
14fb7aa
Compare
Collaborator
Author
|
Not sure why I'm getting errors on this that are unrelated to my changes |
…ure correct MD SDK is used in dev env (#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <[email protected]> * Update fixed turorials Signed-off-by: M Q <[email protected]> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <[email protected]> * Updated the doc too Signed-off-by: M Q <[email protected]> * Fix linting error Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]>
|
MMelQin
approved these changes
Jan 23, 2025
Collaborator
MMelQin
left a comment
MMelQin
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Rebased to get rid of the CI errors.
At one time there was a design decision to encourage users to use the SDK's own Image object (numpy array + metadata) so that the metadata can be validated along the way before being passed down to the seg writer. If numpy array is directly used, the user then needs to ensure that it represents a image compatible with the original input image.
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jun 26, 2025
…a numpy array (Project-MONAI#515) * Fix for case where input image is already a numpy array Signed-off-by: Chris Bridge <[email protected]> * Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (Project-MONAI#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <[email protected]> * Update fixed turorials Signed-off-by: M Q <[email protected]> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <[email protected]> * Updated the doc too Signed-off-by: M Q <[email protected]> * Fix linting error Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> --------- Signed-off-by: Chris Bridge <[email protected]> Signed-off-by: M Q <[email protected]> Co-authored-by: Ming M Qin <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…a numpy array (Project-MONAI#515) * Fix for case where input image is already a numpy array Signed-off-by: Chris Bridge <[email protected]> * Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (Project-MONAI#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <[email protected]> * Update fixed turorials Signed-off-by: M Q <[email protected]> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <[email protected]> * Updated the doc too Signed-off-by: M Q <[email protected]> * Fix linting error Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> --------- Signed-off-by: Chris Bridge <[email protected]> Signed-off-by: M Q <[email protected]> Co-authored-by: Ming M Qin <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…a numpy array (Project-MONAI#515) * Fix for case where input image is already a numpy array Signed-off-by: Chris Bridge <[email protected]> * Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (Project-MONAI#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <[email protected]> * Update fixed turorials Signed-off-by: M Q <[email protected]> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <[email protected]> * Updated the doc too Signed-off-by: M Q <[email protected]> * Fix linting error Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> --------- Signed-off-by: Chris Bridge <[email protected]> Signed-off-by: M Q <[email protected]> Co-authored-by: Ming M Qin <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…a numpy array (Project-MONAI#515) * Fix for case where input image is already a numpy array Signed-off-by: Chris Bridge <[email protected]> * Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (Project-MONAI#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <[email protected]> * Update fixed turorials Signed-off-by: M Q <[email protected]> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <[email protected]> * Updated the doc too Signed-off-by: M Q <[email protected]> * Fix linting error Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> --------- Signed-off-by: Chris Bridge <[email protected]> Signed-off-by: M Q <[email protected]> Co-authored-by: Ming M Qin <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…a numpy array (Project-MONAI#515) * Fix for case where input image is already a numpy array Signed-off-by: Chris Bridge <[email protected]> * Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (Project-MONAI#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <[email protected]> * Update fixed turorials Signed-off-by: M Q <[email protected]> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <[email protected]> * Updated the doc too Signed-off-by: M Q <[email protected]> * Fix linting error Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> --------- Signed-off-by: Chris Bridge <[email protected]> Signed-off-by: M Q <[email protected]> Co-authored-by: Ming M Qin <[email protected]> Signed-off-by: Simone Bendazzoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #510 (@kavmar)