Merge pull request #267 from Project-MONAI/AI-185

adding missed validation and new test so it dont happen again

Author: neildsouth

.github/workflows/ci.yml

@@ -94,11 +94,11 @@ jobs:
   unit-test:
     runs-on: ubuntu-latest
     steps:
-      - name: Set up JDK 11
+      - name: Set up JDK 17
         uses: actions/setup-java@v3
         with:
           distribution: 'zulu'
-          java-version: '11'
+          java-version: '17'
 
       - uses: actions/setup-dotnet@v3
         with:

src/Messaging/Common/ArtifactTypes.cs

@@ -22,6 +22,7 @@ public static class ArtifactTypes
         {
             { ArtifactType.Unset, "Unset" },
             { ArtifactType.Folder, "Folders" },
+            { ArtifactType.HL7, "HL7 message" },
             { ArtifactType.AR, "Autorefract" },
             { ArtifactType.ASMT, "Content Assessment Results" },
             { ArtifactType.AU, "Audio" },

src/Messaging/Tests/Common/ArtifactTypesTests.cs

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+using System;
 using Monai.Deploy.Messaging.Common;
 using Xunit;
 
@@ -32,5 +33,27 @@ public void ArtifactTypeInvalid_ShouldReturnFalse()
         {
             Assert.False(ArtifactTypes.Validate("false"));
         }
+
+        [Fact]
+        public void ArtifactTypeNull_ShouldReturnFalse()
+        {
+            Assert.False(ArtifactTypes.Validate(null));
+        }
+
+        [Fact]
+        public void ArtifactTypes_Should_Contain_All()
+        {
+            foreach (var artifactType in Enum.GetValues(typeof(ArtifactType)))
+            {
+                Assert.True(ArtifactTypes.ListOfModularity.ContainsKey((ArtifactType)artifactType));
+            }
+        }
+
+        [Fact]
+        public void ArtifactTypes_Should_Contain_Same_Count()
+        {
+            Assert.Equal(ArtifactTypes.ListOfModularity.Count, Enum.GetValues(typeof(ArtifactType)).Length);
+        }
+
     }
 }