Various fixes

Author: MarcelloPerathoner

docs/areas.md

@@ -76,7 +76,7 @@ Example of a process_way function:
 ```lua
 function process_way(profile, way, result, relations)
   ...
-  if way:get_value_by_key('highway') == 'pedestrian' then
+  if way:get_value_by_key('highway') == 'pedestrian' and way:get_value_by_key('area') == 'yes' then
     -- register the way
     area_manager:way(way)
   end
@@ -86,6 +86,7 @@ function process_way(profile, way, result, relations)
     -- we have to set at least one defining tag
     local rel = relations:relation(rel_id)
     data.highway = rel:get_value_by_key('highway')
+    WayHandlers.names(profile, rel, result, data)
   end
   ...
 end

features/foot/area_mesh.feature

@@ -4,7 +4,7 @@ Feature: Foot - Pedestrian areas
     Background:
         Given the profile "foot_area"
         Given a grid size of 50 meters
-        Given the extract extra arguments "--verbosity DEBUG"
+        # Given the extract extra arguments "--verbosity DEBUG"
         Given the query options
             | annotations | nodes |
 
@@ -31,6 +31,29 @@ Feature: Foot - Pedestrian areas
             | h    | f  | hdbf    |
             | f    | h  | fbdh    |
 
+    Scenario: Foot - Do not route across a closed way w/o area
+        Given the node map
+            """
+            e-a---b-f
+              |   |
+            h-d---c-g
+            """
+
+        And the ways
+            | nodes | highway    |
+            | abcda | pedestrian |
+            | ea    | pedestrian |
+            | bf    | pedestrian |
+            | hd    | pedestrian |
+            | cg    | pedestrian |
+
+        When I route I should get
+            | from | to | a:nodes |
+            | e    | g  | eabcg   |
+            | g    | e  | gcbae   |
+            | h    | f  | hdabf   |
+            | f    | h  | fbadh   |
+
     Scenario: Foot - Route across a multipolygon area
         Given the node map
             """

include/util/coordinate.hpp

@@ -33,12 +33,13 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include <boost/numeric/conversion/cast.hpp>
 
 #include <cstdint>
+#include <osmium/osm/location.hpp>
 #include <type_traits>
 
 namespace osrm
 {
 
-constexpr const double COORDINATE_PRECISION = 1e6;
+constexpr const double COORDINATE_PRECISION = 1e6; // (double)osmium::detail::coordinate_precision;
 
 namespace util
 {

profiles/foot_area.lua

@@ -195,7 +195,7 @@ function process_way(profile, way, result, relations)
     public_transport = way:get_value_by_key('public_transport')
   }
 
-  if data.highway == 'pedestrian' then
+  if data.highway == 'pedestrian' and way:get_value_by_key('area') == 'yes' then
     area_manager:way(way)
   end
 

src/extractor/extractor.cpp

@@ -35,7 +35,6 @@
 #include "util/timing_util.hpp"
 
 // Keep debug include to make sure the debug header is in sync with types.
-// NOLINTNEXTLINE(unused-includes)
 #include "util/debug.hpp"
 
 #include <boost/assert.hpp>