Remove superflous iostreams include from header files (#6901)

DennisOSRM · web-flow · commit 8306ed8ae3e8 · 2024-05-25T09:17:45.000+02:00
diff --git a/include/nodejs/node_osrm_support.hpp b/include/nodejs/node_osrm_support.hpp
@@ -24,7 +24,6 @@
 #include <boost/optional.hpp>
 
 #include <algorithm>
-#include <iostream>
 #include <iterator>
 #include <sstream>
 #include <stdexcept>
diff --git a/include/storage/io.hpp b/include/storage/io.hpp
@@ -18,6 +18,7 @@
 
 #include <cerrno>
 #include <cstring>
+#include <iostream>
 #include <tuple>
 #include <type_traits>
 
diff --git a/include/util/debug.hpp b/include/util/debug.hpp
@@ -12,7 +12,7 @@
 #include "util/typedefs.hpp"
 
 #include <iomanip>
-#include <iostream>
+#include <ostream>
 #include <sstream>
 #include <string>
 #include <vector>
diff --git a/include/util/exception.hpp b/include/util/exception.hpp
@@ -30,7 +30,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include <array>
 #include <exception>
-#include <iostream>
 #include <string>
 #include <utility>
 
diff --git a/include/util/exception_utils.hpp b/include/util/exception_utils.hpp
@@ -1,6 +1,8 @@
-#ifndef SOURCE_MACROS_HPP
-#define SOURCE_MACROS_HPP
+#ifndef EXCEPTION_UTILS_HPP
+#define EXCEPTION_UTILS_HPP
+
 #include <cstring>
+#include <string>
 
 // Helper macros, don't use these ones
 // STRIP the OSRM_PROJECT_DIR from the front of a filename.  Expected to come
@@ -12,4 +14,4 @@
 // This is the macro to use
 #define SOURCE_REF (OSRM_SOURCE_FILE_ + ":" + std::to_string(__LINE__))
 
-#endif // SOURCE_MACROS_HPP
+#endif // EXCEPTION_UTILS_HPP
diff --git a/include/util/lua_util.hpp b/include/util/lua_util.hpp
@@ -10,7 +10,6 @@ extern "C"
 
 #include <boost/filesystem.hpp>
 
-#include <iostream>
 #include <string>
 
 namespace osrm::util
diff --git a/include/util/node_based_graph.hpp b/include/util/node_based_graph.hpp
@@ -9,7 +9,6 @@
 
 #include <tbb/parallel_sort.h>
 
-#include <iostream>
 #include <memory>
 #include <utility>
 
diff --git a/src/benchmarks/packed_vector.cpp b/src/benchmarks/packed_vector.cpp
@@ -5,6 +5,7 @@
 
 #include <algorithm>
 #include <iomanip>
+#include <iostream>
 #include <numeric>
 #include <random>
 #include <string>
diff --git a/src/extractor/compressed_edge_container.cpp b/src/extractor/compressed_edge_container.cpp
@@ -9,8 +9,6 @@
 #include <limits>
 #include <string>
 
-#include <iostream>
-
 namespace osrm::extractor
 {
 
diff --git a/src/extractor/extractor.cpp b/src/extractor/extractor.cpp
@@ -50,7 +50,6 @@
 #include <atomic>
 #include <bitset>
 #include <chrono>
-#include <iostream>
 #include <memory>
 #include <thread>
 #include <tuple>
diff --git a/src/partitioner/bisection_graph_view.cpp b/src/partitioner/bisection_graph_view.cpp
@@ -1,6 +1,5 @@
 #include "partitioner/bisection_graph_view.hpp"
 
-#include <iostream>
 #include <iterator>
 
 #include <boost/assert.hpp>
diff --git a/src/storage/storage.cpp b/src/storage/storage.cpp
@@ -31,7 +31,6 @@
 #include <cstdint>
 
 #include <fstream>
-#include <iostream>
 #include <iterator>
 #include <new>
 #include <string>
diff --git a/src/storage/storage_config.cpp b/src/storage/storage_config.cpp
@@ -3,6 +3,9 @@
 #include "util/exception_utils.hpp"
 #include <boost/algorithm/string/case_conv.hpp>
 
+#include <istream>
+#include <string>
+
 namespace osrm::storage
 {
 std::istream &operator>>(std::istream &in, FeatureDataset &datasets)
diff --git a/src/tools/extract.cpp b/src/tools/extract.cpp
@@ -9,6 +9,7 @@
 
 #include <cstdlib>
 #include <exception>
+#include <iostream>
 #include <new>
 #include <thread>
 
diff --git a/src/util/coordinate.cpp b/src/util/coordinate.cpp
@@ -1,16 +1,8 @@
-#include "util/coordinate_calculation.hpp"
-
-#ifndef NDEBUG
-#include "util/log.hpp"
-#endif
 #include "osrm/coordinate.hpp"
 
-#ifndef NDEBUG
-#include <bitset>
-#endif
-#include <iomanip>
-#include <iostream>
-#include <limits>
+#include "util/coordinate_calculation.hpp"
+
+#include <cstdint>
 
 namespace osrm::util
 {
diff --git a/src/util/exception.cpp b/src/util/exception.cpp
@@ -1,7 +1,5 @@
 #include "util/exception.hpp"
 
-#include <utility>
-
 // This function exists to 'anchor' the class, and stop the compiler from
 // copying vtable and RTTI info into every object file that includes
 // this header. (Caught by -Wweak-vtables under Clang.)
diff --git a/src/util/guidance/turn_lanes.cpp b/src/util/guidance/turn_lanes.cpp
@@ -1,11 +1,7 @@
 #include "util/guidance/turn_lanes.hpp"
 
-#include <algorithm>
-#include <iostream>
 #include <tuple>
 
-#include <boost/assert.hpp>
-
 namespace osrm::util::guidance
 {
 LaneTuple::LaneTuple() : lanes_in_turn(0), first_lane_from_the_right(INVALID_LANEID)

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,6 @@`
`9`	`9`	`#include <limits>`
`10`	`10`	`#include <string>`
`11`	`11`
`12`		`-#include <iostream>`
`13`		`-`
`14`	`12`	`namespace osrm::extractor`
`15`	`13`	`{`
`16`	`14`