Skip to content

Commit a1ccedb

Browse files
author
Moritz Kobitzsch
committed
re-introduce space into summaries
1 parent 189f8c3 commit a1ccedb

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

features/car/summaries.feature

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ Feature: Basic Routing
2323
| df | street |
2424

2525
When I route I should get
26-
| waypoints | route | summary |
27-
| a,e | road,,1 st,1 st | road,1 st |
28-
| a,d,f | road,,,street,street | road;street |
29-
| a,e,f | road,,1 st,1 st,1 st,street,street | road,1 st;1 st,street |
26+
| waypoints | route | summary |
27+
| a,e | road,,1 st,1 st | road, 1 st |
28+
| a,d,f | road,,,street,street | road;street |
29+
| a,e,f | road,,1 st,1 st,1 st,street,street | road, 1 st;1 st, street |
3030

3131
Scenario: Name Empty
3232
Given the node map
@@ -51,8 +51,8 @@ Feature: Basic Routing
5151
| bc | | 101 |
5252

5353
When I route I should get
54-
| waypoints | route | summary |
55-
| a,c | road, | road,101 |
54+
| waypoints | route | summary |
55+
| a,c | road, | road, 101 |
5656

5757
Scenario: Only Refs
5858
Given the node map
@@ -64,8 +64,8 @@ Feature: Basic Routing
6464
| bc | | 101 |
6565

6666
When I route I should get
67-
| waypoints | route | summary |
68-
| a,c | , | 100,101 |
67+
| waypoints | route | summary |
68+
| a,c | , | 100, 101 |
6969

7070
Scenario: Single Ref
7171
Given the node map

features/testbot/summary.feature

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ Feature: Basic Routing
1818
| de |
1919

2020
When I route I should get
21-
| from | to | route | summary |
22-
| a | e | ab,bc,cd,de,de | ab,bc |
23-
| e | a | de,cd,bc,ab,ab | de,bc |
24-
| a | b | ab,ab | ab |
25-
| b | d | bc,cd,cd | bc,cd |
26-
| 1 | c | bc,bc | bc |
21+
| from | to | route | summary |
22+
| a | e | ab,bc,cd,de,de | ab, bc |
23+
| e | a | de,cd,bc,ab,ab | de, bc |
24+
| a | b | ab,ab | ab |
25+
| b | d | bc,cd,cd | bc, cd |
26+
| 1 | c | bc,bc | bc |
2727

2828
@smallest
2929
Scenario: Check handling empty values
@@ -40,8 +40,8 @@ Feature: Basic Routing
4040
| df | df |
4141

4242
When I route I should get
43-
| from | to | route | summary |
44-
| e | a | de,,bc,ab,ab | de,bc |
43+
| from | to | route | summary |
44+
| e | a | de,,bc,ab,ab | de, bc |
4545

4646
@smallest @todo
4747
Scenario: Summaries when routing on a simple network
@@ -74,6 +74,6 @@ Feature: Basic Routing
7474
| xey | cross |we need this because phantom node segments are not considered for the summary |
7575

7676
When I route I should get
77-
| from | to | route | summary |
78-
| a | 1 | first,first,second,second | first,second |
77+
| from | to | route | summary |
78+
| a | 1 | first,first,second,second | first, second |
7979

include/engine/guidance/assemble_leg.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ inline RouteLeg assembleLeg(const datafacade::BaseDataFacade &facade,
198198

199199
const auto summary_names = summary_array | boost::adaptors::transformed(name_id_to_string) |
200200
boost::adaptors::filtered(not_empty);
201-
summary = boost::algorithm::join(summary_names, ",");
201+
summary = boost::algorithm::join(summary_names, ", ");
202202
}
203203

204204
return RouteLeg{duration, distance, summary, {}};

0 commit comments

Comments
 (0)