Skip to content

Commit aa4e6b1

Browse files
Apply micro-optimisation for Nearest API (#6944)
1 parent de2f392 commit aa4e6b1

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
- NodeJS:
2525
- CHANGED: Use node-api instead of NAN. [#6452](https://github.com/Project-OSRM/osrm-backend/pull/6452)
2626
- Misc:
27+
- CHANGED: Apply micro-optimisation for Nearest API. [#6944](https://github.com/Project-OSRM/osrm-backend/pull/6944)
2728
- CHANGED: Avoid copy of intersection in totalTurnAngle. [#6938](https://github.com/Project-OSRM/osrm-backend/pull/6938)
2829
- CHANGED: Use std::unordered_map::emplace instead of operator[] when producing JSONs. [#6936](https://github.com/Project-OSRM/osrm-backend/pull/6936)
2930
- CHANGED: Avoid copy of vectors in MakeRoute function. [#6939](https://github.com/Project-OSRM/osrm-backend/pull/6939)

include/engine/api/nearest_api.hpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,23 +100,23 @@ class NearestAPI final : public BaseAPI
100100
auto waypoint = MakeWaypoint({phantom_node});
101101

102102
util::json::Array nodes;
103+
nodes.values.reserve(2);
103104

104105
auto node_values = MakeNodes(phantom_node);
105106

106-
nodes.values.push_back(node_values.first);
107-
nodes.values.push_back(node_values.second);
108-
waypoint.values["nodes"] = std::move(nodes);
109-
107+
nodes.values.emplace_back(node_values.first);
108+
nodes.values.emplace_back(node_values.second);
109+
waypoint.values.emplace("nodes", std::move(nodes));
110110
return waypoint;
111111
});
112-
response.values["waypoints"] = std::move(waypoints);
112+
response.values.emplace("waypoints", std::move(waypoints));
113113
}
114114

115-
response.values["code"] = "Ok";
115+
response.values.emplace("code", "Ok");
116116
auto data_timestamp = facade.GetTimestamp();
117117
if (!data_timestamp.empty())
118118
{
119-
response.values["data_version"] = data_timestamp;
119+
response.values.emplace("data_version", data_timestamp);
120120
}
121121
}
122122

0 commit comments

Comments
 (0)