Skip to content

Commit b76dbfb

Browse files
wip
1 parent 4897275 commit b76dbfb

File tree

3 files changed

+8
-1040
lines changed

3 files changed

+8
-1040
lines changed

.github/workflows/osrm-backend.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ jobs:
568568
fi
569569
popd
570570
- name: Build example
571-
if: ${{ matrix.NODE_PACKAGE_TESTS_ONLY != 'ON' }}
571+
if: ${{ matrix.NODE_PACKAGE_TESTS_ONLY != 'ON' && matrix.ENABLE_CONAN != 'ON' }}
572572
run: |
573573
mkdir example/build && pushd example/build
574574
cmake .. -DCMAKE_BUILD_TYPE=${BUILD_TYPE}

CMakeLists.txt

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,6 @@ find_package(Lua 5.2 REQUIRED)
332332
if (ENABLE_CONAN)
333333
add_dependency_includes(${Boost_INCLUDE_DIRS})
334334
set(BOOST_LIBRARIES ${Boost_LIBRARIES})
335-
336335
add_dependency_includes(${TBB_INCLUDE_DIR})
337336
set(TBB_LIBRARIES ${TBB_LIBRARIES})
338337

@@ -626,20 +625,15 @@ list(APPEND DEPENDENCIES_INCLUDE_DIRS "${PKGCONFIG_INCLUDE_DIR}")
626625
list(APPEND DEPENDENCIES_INCLUDE_DIRS "${PKGCONFIG_INCLUDE_DIR}/osrm")
627626
JOIN("-I${DEPENDENCIES_INCLUDE_DIRS}" " -I" PKGCONFIG_OSRM_INCLUDE_FLAGS)
628627

629-
# Boost uses imported targets, we need to use a generator expression to extract
630-
# the link libraries to be written to the pkg-config file.
631-
# Conan & TBB define dependencies as CMake targets too, that's why we do the same for them.
628+
# # Boost uses imported targets, we need to use a generator expression to extract
629+
# # the link libraries to be written to the pkg-config file.
630+
# # Conan & TBB define dependencies as CMake targets too, that's why we do the same for them.
632631
foreach(engine_lib ${ENGINE_LIBRARIES})
633-
message(STATUS "Adding ${engine_lib} to pkg-config dependencies")
634-
# if("${engine_lib}" MATCHES "^boost.*" OR "${engine_lib}" MATCHES "^CONAN_LIB.*" OR "${engine_lib}" MATCHES "^TBB.*")
635-
# list(APPEND PKGCONFIG_DEPENDENT_LIBRARIES "$<TARGET_LINKER_FILE:${engine_lib}>")
636-
# else()
637-
# list(APPEND PKGCONFIG_DEPENDENT_LIBRARIES "${engine_lib}")
638-
# endif()
639-
list(APPEND PKGCONFIG_DEPENDENT_LIBRARIES "${engine_lib}")
632+
message(STATUS "Adding ${engine_lib} to pkg-config dependencies ")
633+
list(APPEND PKGCONFIG_DEPENDENT_LIBRARIES "$<TARGET_LINKER_FILE:${engine_lib}>")
640634
endforeach(engine_lib)
641-
# #message(FATAL_ERROR "XXX")
642-
JOIN("${PKGCONFIG_DEPENDENT_LIBRARIES}" " " PKGCONFIG_OSRM_DEPENDENT_LIBRARIES)
635+
#message(FATAL_ERROR "XXX")
636+
# JOIN("${PKGCONFIG_DEPENDENT_LIBRARIES}" " " PKGCONFIG_OSRM_DEPENDENT_LIBRARIES)
643637

644638
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/cmake/pkgconfig.in pkgconfig.configured @ONLY)
645639
file(GENERATE

0 commit comments

Comments
 (0)