Dual core off by default (again), minimum netplay buffer 2>3 to comp for Rush

Author: Motobug

Source/Core/Core/Config/MainSettings.cpp

@@ -55,8 +55,8 @@ const Info<bool> MAIN_SMOOTH_EARLY_PRESENTATION{{System::Main, "Core", "SmoothEa
 // Currently enabled by default on Android because the performance boost is really needed.
 constexpr bool DEFAULT_CPU_THREAD = true;
 #else
-// P+ change: enable dual core for desktop, as we're targeting low end machines for default settings
-constexpr bool DEFAULT_CPU_THREAD = true;
+// Turned back off after testing showed dual core increases input lag on some machines
+constexpr bool DEFAULT_CPU_THREAD = false;
 #endif
 const Info<bool> MAIN_CPU_THREAD{{System::Main, "Core", "CPUThread"}, DEFAULT_CPU_THREAD};
 const Info<bool> MAIN_SYNC_ON_SKIP_IDLE{{System::Main, "Core", "SyncOnSkipIdle"}, true};

Source/Core/Core/Config/NetplaySettings.cpp

@@ -43,8 +43,8 @@ const Info<bool> NETPLAY_ENABLE_CHUNKED_UPLOAD_LIMIT{
     {System::Main, "NetPlay", "EnableChunkedUploadLimit"}, false};
 const Info<u32> NETPLAY_CHUNKED_UPLOAD_LIMIT{{System::Main, "NetPlay", "ChunkedUploadLimit"}, 3000};
 
-const Info<u32> NETPLAY_MINIMUM_BUFFER_SIZE{{System::Main, "NetPlay", "MinimumBufferSize"}, 2};
-const Info<u32> NETPLAY_PLAYER_BUFFER_SIZE{{System::Main, "NetPlay", "PlayerBufferSize"}, 2};
+const Info<u32> NETPLAY_MINIMUM_BUFFER_SIZE{{System::Main, "NetPlay", "MinimumBufferSize"}, 3};
+const Info<u32> NETPLAY_PLAYER_BUFFER_SIZE{{System::Main, "NetPlay", "PlayerBufferSize"}, 3};
 const Info<u32> NETPLAY_CLIENT_BUFFER_SIZE{{System::Main, "NetPlay", "BufferSizeClient"}, 1};
 
 const Info<bool> NETPLAY_BRAWL_MUSIC_OFF{{System::Main, "NetPlay", "BrawlMusicOff"}, false};

Source/Core/Core/NetPlayServer.cpp

@@ -173,7 +173,7 @@ NetPlayServer::NetPlayServer(const u16 port, const bool forward_port, NetPlayUI*
     is_connected = true;
     m_do_loop = true;
     m_thread = std::thread(&NetPlayServer::ThreadFunc, this);
-    m_minimum_buffer_size = 2;
+    m_minimum_buffer_size = 3;
     m_chunked_data_thread = std::thread(&NetPlayServer::ChunkedDataThreadFunc, this);
 
 #ifdef USE_UPNP

Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp

@@ -273,7 +273,7 @@ void AdvancedWidget::AddDescriptions()
   static const char TR_CACHE_CUSTOM_TEXTURE_DESCRIPTION[] = QT_TR_NOOP(
       "Caches custom textures to system RAM on startup.<br><br>This can require exponentially "
       "more RAM but fixes possible stuttering.<br><br><dolphin_emphasis>If unsure, leave this "
-      "unchecked.</dolphin_emphasis>");
+      "checked.</dolphin_emphasis>");
   static const char TR_DUMP_EFB_DESCRIPTION[] =
       QT_TR_NOOP("Dumps the contents of EFB copies to User/Dump/Textures/.<br><br>"
                  "<dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>");

Source/Core/DolphinQt/Config/Graphics/GeneralWidget.cpp

@@ -258,7 +258,7 @@ void GeneralWidget::AddDescriptions()
       "<br><br><b>Custom (Stretch)</b>: Similar to `Custom`, but stretches the image to the "
       "specified aspect ratio. This will usually distort the image's proportions, and should not "
       "be used under normal circumstances."
-      "<br><br><dolphin_emphasis>If unsure, select Auto.</dolphin_emphasis>");
+      "<br><br><dolphin_emphasis>If unsure, select Force 69:40 (P+ Widescreen).</dolphin_emphasis>");
   static const char TR_VSYNC_DESCRIPTION[] = QT_TR_NOOP(
       "Waits for vertical blanks in order to prevent tearing.<br><br>Decreases performance "
       "if emulation speed is below 100%.<br><br><dolphin_emphasis>If unsure, leave "
@@ -267,7 +267,7 @@ void GeneralWidget::AddDescriptions()
   static const char TR_SHADER_COMPILE_SPECIALIZED_DESCRIPTION[] =
       QT_TR_NOOP("Ubershaders are never used. Stuttering will occur during shader "
                  "compilation, but GPU demands are low.<br><br>Recommended for low-end hardware. "
-                 "<br><br><dolphin_emphasis>If unsure, select this mode.</dolphin_emphasis>");
+                 "<br><br><dolphin_emphasis>Not recommended, use other options.</dolphin_emphasis>");
   // The "very powerful GPU" mention below is by 2021 PC GPU standards
   static const char TR_SHADER_COMPILE_EXCLUSIVE_UBER_DESCRIPTION[] = QT_TR_NOOP(
       "Ubershaders will always be used. Provides a near stutter-free experience at the cost of "
@@ -282,15 +282,15 @@ void GeneralWidget::AddDescriptions()
   static const char TR_SHADER_COMPILE_SKIP_DRAWING_DESCRIPTION[] = QT_TR_NOOP(
       "Prevents shader compilation stuttering by not rendering waiting objects. Can work in "
       "scenarios where Ubershaders doesn't, at the cost of introducing visual glitches and broken "
-      "effects.<br><br><dolphin_emphasis>Not recommended, only use if the other "
-      "options give poor results.</dolphin_emphasis>");
+      "effects.<br><br><dolphin_emphasis>Use this option if you encounter excessive stuttering "
+      "with other options.</dolphin_emphasis>");
   static const char TR_SHADER_COMPILE_BEFORE_START_DESCRIPTION[] =
       QT_TR_NOOP("Waits for all shaders to finish compiling before starting a game. Enabling this "
                  "option may reduce stuttering or hitching for a short time after the game is "
                  "started, at the cost of a longer delay before the game starts. For systems with "
                  "two or fewer cores, it is recommended to enable this option, as a large shader "
                  "queue may reduce frame rates.<br><br><dolphin_emphasis>Otherwise, if "
-                 "unsure, leave this unchecked.</dolphin_emphasis>");
+                 "unsure, leave this checked.</dolphin_emphasis>");
 
   m_backend_combo->SetTitle(tr("Backend"));
   m_backend_combo->SetDescription(

Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp

@@ -203,7 +203,7 @@ void HacksWidget::AddDescriptions()
       "expect all XFB copies to be displayed. However, turning this setting on reduces latency."
       "<br><br>Enabling this also forces an effect equivalent to the "
       "Skip Presenting Duplicate Frames setting."
-      "<br><br><dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>");
+      "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>");
   static const char TR_SKIP_DUPLICATE_XFBS_DESCRIPTION[] = QT_TR_NOOP(
       "Skips presentation of duplicate frames (XFB copies) in 25fps/30fps games. "
       "This may improve performance on low-end devices, while making frame pacing less consistent."

Source/Core/DolphinQt/Settings/GeneralPane.cpp

@@ -373,7 +373,7 @@ void GeneralPane::AddDescriptions()
                  "burden by spreading Dolphin's heaviest load across two cores, which usually "
                  "improves performance. However, it can result in glitches and crashes."
                  "<br><br>This setting cannot be changed while emulation is active."
-                 "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>");
+                 "<br><br><dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>");
   static constexpr char TR_CHEATS_DESCRIPTION[] = QT_TR_NOOP(
       "Enables the use of AR and Gecko cheat codes which can be used to modify games' behavior. "
       "These codes can be configured with the Cheats Manager in the Tools menu."