Add toggle for adapter poll rate warning

Author: Motobug

Source/Core/Core/Config/MainSettings.cpp

@@ -411,6 +411,7 @@ const Info<bool> MAIN_USE_HIGH_CONTRAST_TOOLTIPS{
 const Info<bool> MAIN_USE_PANIC_HANDLERS{{System::Main, "Interface", "UsePanicHandlers"}, false};
 const Info<bool> MAIN_ABORT_ON_PANIC_ALERT{{System::Main, "Interface", "AbortOnPanicAlert"}, false};
 const Info<bool> MAIN_OSD_MESSAGES{{System::Main, "Interface", "OnScreenDisplayMessages"}, true};
+const Info<bool> MAIN_SHOW_ADAPTER_WARNING{{System::Main, "Interface", "ShowAdapterWarning"}, true};
 const Info<bool> MAIN_SKIP_NKIT_WARNING{{System::Main, "Interface", "SkipNKitWarning"}, false};
 const Info<bool> MAIN_CONFIRM_ON_STOP{{System::Main, "Interface", "ConfirmStop"}, false};
 const Info<ShowCursor> MAIN_SHOW_CURSOR{{System::Main, "Interface", "CursorVisibility"},

Source/Core/Core/Config/MainSettings.h

@@ -239,6 +239,7 @@ extern const Info<bool> MAIN_USE_HIGH_CONTRAST_TOOLTIPS;
 extern const Info<bool> MAIN_USE_PANIC_HANDLERS;
 extern const Info<bool> MAIN_ABORT_ON_PANIC_ALERT;
 extern const Info<bool> MAIN_OSD_MESSAGES;
+extern const Info<bool> MAIN_SHOW_ADAPTER_WARNING;
 extern const Info<bool> MAIN_SKIP_NKIT_WARNING;
 extern const Info<bool> MAIN_CONFIRM_ON_STOP;
 

Source/Core/DolphinQt/Settings/InterfacePane.cpp

@@ -198,6 +198,8 @@ void InterfacePane::CreateInGame()
       new ConfigBool(tr("Use Panic Handlers"), Config::MAIN_USE_PANIC_HANDLERS);
   m_checkbox_enable_osd =
       new ConfigBool(tr("Show On-Screen Display Messages"), Config::MAIN_OSD_MESSAGES);
+  m_checkbox_adapter_warning = 
+      new ConfigBool(tr("Show Adapter Poll Rate Warning"), Config::MAIN_SHOW_ADAPTER_WARNING);
   m_checkbox_show_active_title =
       new ConfigBool(tr("Show Active Title in Window Title"), Config::MAIN_SHOW_ACTIVE_TITLE);
   m_checkbox_pause_on_focus_lost =
@@ -228,6 +230,7 @@ void InterfacePane::CreateInGame()
   groupbox_layout->addWidget(m_checkbox_confirm_on_stop);
   groupbox_layout->addWidget(m_checkbox_use_panic_handlers);
   groupbox_layout->addWidget(m_checkbox_enable_osd);
+  groupbox_layout->addWidget(m_checkbox_adapter_warning);
   groupbox_layout->addWidget(m_checkbox_show_active_title);
   groupbox_layout->addWidget(m_checkbox_pause_on_focus_lost);
   groupbox_layout->addWidget(mouse_groupbox);
@@ -372,6 +375,11 @@ void InterfacePane::AddDescriptions()
       QT_TR_NOOP("Shows on-screen display messages over the render window. These messages "
                  "disappear after several seconds."
                  "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>");
+  static constexpr char TR_ADAPTER_WARNING_DESCRIPTION[] =
+      QT_TR_NOOP("This setting makes Dolphin warn and show a message when inputs are being read at a reduced rate when an adapter problem is detected."
+        " This should only occur when your adapter returns something other than LIBUSB_SUCCESS."
+        " Before turning this off, try reinstalling drivers and switching USB ports."
+        "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>");
   static constexpr char TR_SHOW_ACTIVE_TITLE_DESCRIPTION[] =
       QT_TR_NOOP("Shows the active game title in the render window's title bar."
                  "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>");
@@ -420,6 +428,8 @@ void InterfacePane::AddDescriptions()
   m_checkbox_use_panic_handlers->SetDescription(tr(TR_USE_PANIC_HANDLERS_DESCRIPTION));
 
   m_checkbox_enable_osd->SetDescription(tr(TR_ENABLE_OSD_DESCRIPTION));
+  
+  m_checkbox_adapter_warning->SetDescription(tr(TR_ADAPTER_WARNING_DESCRIPTION));
 
   m_checkbox_show_active_title->SetDescription(tr(TR_SHOW_ACTIVE_TITLE_DESCRIPTION));
 

Source/Core/DolphinQt/Settings/InterfacePane.h

@@ -54,6 +54,7 @@ class InterfacePane final : public QWidget
   ConfigBool* m_checkbox_confirm_on_stop;
   ConfigBool* m_checkbox_use_panic_handlers;
   ConfigBool* m_checkbox_enable_osd;
+  ConfigBool* m_checkbox_adapter_warning;
   ConfigBool* m_checkbox_show_active_title;
   ConfigBool* m_checkbox_pause_on_focus_lost;
   ConfigRadioInt* m_radio_cursor_visible_movement;

Source/Core/VideoCommon/OnScreenUI.cpp

@@ -333,27 +333,25 @@ void OnScreenUI::DrawDebugText()
     ImGui::TextUnformatted(profile_output.c_str());
 
   // P+ change: warn if adapter is being read at reduced rate
-  if (GCAdapter::IsReadingAtReducedRate())
+  if (GCAdapter::IsReadingAtReducedRate() && Config::Get(Config::MAIN_SHOW_ADAPTER_WARNING))
   {
     ImGui::TextWrapped(
-        "Your GameCube Controller Adapter is reading inputs at a reduced rate.\n"
-        "You can still play normally but you will experience higher input lag.\n"
-        "This indicates a potential hardware issue.\n"
-        "\n"
-        "Go to the Dolphin -> Controllers page, click 'Configure' next to your "
-        "controller's port, then check what your pollrate is."
-        "\n"
-        "If it is considerably lower than 125 hz, keep trying different USB ports until it "
-        "is around 125 hz."
-        "\n"
-        "For more help, please ask in the official P+ Discord server.");
+      "Your GameCube Controller Adapter is reading inputs at a reduced rate.\n"
+      "You can still play normally but you will experience higher input lag.\n"
+      "This indicates a potential hardware or driver issue.\n"
+      "\n"
+      "If you're using a computer with an AMD Ryzen processor:\n"
+      "Try connecting the black plug of your adapter to a USB 3.0/3.1 Gen 1 port on your motherboard.\n"
+      "These ports are usually blue or say \"SS\" (SuperSpeed). USB 3.2 (light blue) or USB 2.0 (black) will NOT work.\n"
+      "\n"
+      "The recommended driver on Windows is WinUSB. If you're using another driver in Zadig try switching to WinUSB.\n"
+      "\n"
+      "You can turn this message off by going to \"Config\" and then \"Advanced\".\n"
+      "Under \"Troubleshooting\", uncheck \"Show a message when inputs are being read at a reduced rate\".");
 
   }
 }
 
- 
-
-
 void OnScreenUI::DrawChallengesAndLeaderboards()
 {
   if (!Config::Get(Config::MAIN_OSD_MESSAGES))