Fix implementation of per-player pad buffer

Fix implementation of per-player pad buffer

Author: Motobug

Source/Core/Core/NetPlayClient.cpp

@@ -334,14 +334,19 @@ void NetPlayClient::AdjustPlayerPadBufferSize(u32 buffer)
   m_local_player->buffer = buffer;
   if (m_local_player->buffer < m_minimum_buffer_size)
     m_local_player->buffer = m_minimum_buffer_size;
-  
-  // need to rewrite this area
-  
-  /* auto spac = std::make_unique<sf::Packet>();
-  *spac << static_cast <MessageID>(OnPadBufferPlayer);
-  *spac << local_player->buffer;
-  SendAsync(std::move(spac)); */ 
 
+
+	 // not needed on clients with host input authority
+  if (!m_host_input_authority)
+  {
+    // tell clients to change buffer size
+    sf::Packet spac;
+    spac << MessageID::PadBufferPlayer;
+    spac << m_local_player->buffer;
+
+    SendAsync(std::move(spac));
+  }
+  
   m_dialog->OnPlayerPadBufferChanged(m_local_player->buffer);
 }
 
@@ -2263,7 +2268,7 @@ bool NetPlayClient::PollLocalPad(const int local_pad, sf::Packet& packet)
   {
     // adjust the buffer either up or down
     // inserting multiple padstates or dropping states
-    while (m_pad_buffer[ingame_pad].Size() <= m_minimum_buffer_size)
+    while (m_pad_buffer[ingame_pad].Size() <= BufferSizeForPort(ingame_pad))
     {
       // add to buffer
       m_pad_buffer[ingame_pad].Push(pad_status);

Source/Core/Core/NetPlayServer.cpp

@@ -454,6 +454,7 @@ ConnectionError NetPlayServer::OnConnect(ENetPeer* incoming_connection, sf::Pack
   Client new_player{};
   new_player.pid = GiveFirstAvailableIDTo(incoming_connection);
   new_player.socket = incoming_connection;
+  new_player.buffer = m_minimum_buffer_size;
 
   received_packet >> new_player.revision;
   received_packet >> new_player.name;
@@ -499,6 +500,9 @@ ConnectionError NetPlayServer::OnConnect(ENetPeer* incoming_connection, sf::Pack
 
     SendResponseToPlayer(new_player, MessageID::GameStatus, existing_player.pid,
                          static_cast<u8>(existing_player.game_status));
+						 
+	SendResponseToPlayer(new_player, MessageID::PadBufferPlayer, existing_player.pid,
+                         static_cast<u8>(existing_player.buffer));
   }
 
   if (Config::Get(Config::NETPLAY_ENABLE_QOS))
@@ -778,6 +782,22 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)
     SendToClients(spac, player.pid);
   }
   break;
+  
+  case MessageID::PadBufferPlayer:
+  {
+	u32 buffer;
+	packet >> buffer;
+
+	player.buffer = buffer;
+
+	sf::Packet spac;
+	spac << MessageID::PadBufferPlayer;
+	spac << player.pid;
+	spac << buffer;
+
+	SendToClients(spac, player.pid);
+	}
+  break;
 
   case MessageID::ChunkedDataProgress:
   {

Source/Core/Core/NetPlayServer.h

@@ -93,7 +93,7 @@ class NetPlayServer : public Common::TraversalClientClient
     ENetPeer* socket = nullptr;
     u32 ping = 0;
     u32 current_game = 0;
-    unsigned int m_player_buffer_size = 0;
+    unsigned int buffer;
 
     Common::QoSSession qos_session;