Unofficial card script fixes

- Attachment Dragon: Changing the monster's battle position should be part of the equipping effect.
- Dark Psycho Eye: Also check that the target is face-up on resolution + the effect shouldn't be considered an effect that would change control if there's no appropriate target.
- Greedy Venom Fusion Dragon (Anime): Shouldn't be able to target a monster with 0 ATK that already has its effects negated. Fixed an issue when the negation effect targets itself. Should also destroy itself if it's back on the field on resolution. Don't break timing if the total ATK of both players' destroyed monsters is 0. Treat the damage dealt as simultaneous. The gained effect shouldn't be usable in the Damage Step. Apply the restriction even if you don't successfully Special Summon. The gained effect should also check that it was "Greedy Venom Fusion Dragon" on the field.
- Judgment of Anubis (Anime): Shouldn't count the ATK of any monster that wasn't destroyed or that was face-down when destroyed.
- Master and Servant's Resolve: Prevent a script error. General script overhaul. Use the monsters' ATK on field before being destroyed. Snapshot the ATK values when this effect activates rather than referencing them on resolution. Treat the damage as simultaneous if both players take damage at the same time.
- Orichalcos Gigas: The "cannot draw" effect is a separate effect that is applied while the card is face-up in the Monster Zone.
- Plasma Eel: The equipping effect should trigger on summon.
- Refracting Prism: Handle aliased cards + divide the ATK/DEF by the number you're going to summon + remove the original in the process of splitting.
- Zero Gazer: Draw 1 card when this effect resolves, not after damage calculation + draw regardless of what happens to the monster.

Author: pyrQ

official/c21848500.lua

@@ -4,7 +4,7 @@
 local s,id=GetID()
 function s.initial_effect(c)
 	c:EnableReviveLimit()
-	--Link materials: 3 monsters, including a "Maliss" monster
+	--Link Summon procedure: 3 monsters, including a "Maliss" monster
 	Link.AddProcedure(c,nil,3,3,s.lcheck)
 	--Shuffle 1 of your banished "Maliss" monsters into the Deck, and if you do, banish 1 card on the field
 	local e1=Effect.CreateEffect(c)
@@ -31,15 +31,15 @@ function s.initial_effect(c)
 		ge2:SetCode(EFFECT_CANNOT_DISEFFECT)
 		Duel.RegisterEffect(ge2,0)
 	end)
-	--Special Summon this card
+	--Special Summon this card and double its ATK
 	local e2=Effect.CreateEffect(c)
 	e2:SetDescription(aux.Stringid(id,1))
 	e2:SetCategory(CATEGORY_SPECIAL_SUMMON+CATEGORY_ATKCHANGE)
 	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
 	e2:SetProperty(EFFECT_FLAG_DELAY)
 	e2:SetCode(EVENT_REMOVE)
 	e2:SetCountLimit(1,{id,1})
-	e2:SetCost(aux.PayLPCost(900))
+	e2:SetCost(Cost.PayLP(900))
 	e2:SetTarget(s.sptg)
 	e2:SetOperation(s.spop)
 	c:RegisterEffect(e2)
@@ -84,17 +84,14 @@ function s.sptg(e,tp,eg,ep,ev,re,r,rp,chk)
 end
 function s.spop(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
-	if c:IsRelateToEffect(e) then
-		local atk=c:GetAttack()*2
-		if Duel.SpecialSummonStep(c,0,tp,tp,false,false,POS_FACEUP) then
-			--Its ATK becomes doubled
-			local e1=Effect.CreateEffect(c)
-			e1:SetType(EFFECT_TYPE_SINGLE)
-			e1:SetCode(EFFECT_SET_ATTACK)
-			e1:SetValue(atk)
-			e1:SetReset(RESET_EVENT|RESETS_STANDARD_DISABLE)
-			c:RegisterEffect(e1,true)
-			end
-		Duel.SpecialSummonComplete()
+	if c:IsRelateToEffect(e) and Duel.SpecialSummonStep(c,0,tp,tp,false,false,POS_FACEUP) then
+		--Its ATK becomes doubled
+		local e1=Effect.CreateEffect(c)
+		e1:SetType(EFFECT_TYPE_SINGLE)
+		e1:SetCode(EFFECT_SET_ATTACK)
+		e1:SetValue(c:GetAttack()*2)
+		e1:SetReset(RESET_EVENT|RESETS_STANDARD_DISABLE)
+		c:RegisterEffect(e1,true)
 	end
+	Duel.SpecialSummonComplete()
 end

unofficial/c100000033.lua

@@ -2,26 +2,28 @@
 --Dark Psycho Eye
 local s,id=GetID()
 function s.initial_effect(c)
-	--Gain control of 1 opponent's face-up monster until the End Phase
+	--Take control of 1 face-up monster your opponent controls until the End Phase
 	local e1=Effect.CreateEffect(c)
 	e1:SetCategory(CATEGORY_CONTROL)
 	e1:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_F)
 	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetCode(EVENT_DESTROYED)
-	e1:SetTarget(s.target)
-	e1:SetOperation(s.operation)
+	e1:SetTarget(s.ctrltg)
+	e1:SetOperation(s.ctrlop)
 	c:RegisterEffect(e1)
 end
-function s.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
+function s.ctrltg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
 	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsFaceup() and chkc:IsControler(1-tp) and chkc:IsControlerCanBeChanged() end
 	if chk==0 then return true end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_CONTROL)
 	local g=Duel.SelectTarget(tp,aux.FaceupFilter(Card.IsControlerCanBeChanged),tp,0,LOCATION_MZONE,1,1,nil)
-	Duel.SetOperationInfo(0,CATEGORY_CONTROL,g,1,0,0)
+	if #g>0 then
+		Duel.SetOperationInfo(0,CATEGORY_CONTROL,g,1,tp,0)
+	end
 end
-function s.operation(e,tp,eg,ep,ev,re,r,rp)
+function s.ctrlop(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
-	if tc and tc:IsRelateToEffect(e) and tc:IsControlerCanBeChanged() then
+	if tc and tc:IsRelateToEffect(e) and tc:IsFaceup() then
 		Duel.GetControl(tc,tp,PHASE_END,1)
 	end
-end
+end

unofficial/c170000171.lua

@@ -1,64 +1,54 @@
+--オレイカルコス・ギガース
 --Orichalcos Gigas
 local s,id=GetID()
 function s.initial_effect(c)
-	--special summon
-	local e1=Effect.CreateEffect(c)
-	e1:SetCategory(CATEGORY_SPECIAL_SUMMON)
-	e1:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
-	e1:SetProperty(EFFECT_FLAG_DAMAGE_STEP)
-	e1:SetCode(EVENT_DESTROYED)
-	e1:SetCost(s.cost)
-	e1:SetTarget(s.target)
-	e1:SetOperation(s.operation)
-	e1:SetLabel(0)
-	c:RegisterEffect(e1)
+	--While this card is face-up on the field, you cannot draw a card(s)
+	local e1a=Effect.CreateEffect(c)
+	e1a:SetType(EFFECT_TYPE_FIELD)
+	e1a:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
+	e1a:SetCode(EFFECT_CANNOT_DRAW)
+	e1a:SetRange(LOCATION_MZONE)
+	e1a:SetTargetRange(1,0)
+	c:RegisterEffect(e1a)
+	local e1b=e1a:Clone()
+	e1b:SetCode(EFFECT_DRAW_COUNT)
+	e1b:SetValue(0)
+	c:RegisterEffect(e1b)
+	--Special Summon this card, but it cannot attack this turn
+	local e2=Effect.CreateEffect(c)
+	e2:SetDescription(aux.Stringid(id,0))
+	e2:SetCategory(CATEGORY_SPECIAL_SUMMON)
+	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
+	e2:SetCode(EVENT_DESTROYED)
+	e2:SetTarget(s.sptg)
+	e2:SetOperation(s.spop)
+	c:RegisterEffect(e2)
+	--This card gains 500 ATK x the number of times it was Special Summoned by its own effect during this Duel
 	local e3=Effect.CreateEffect(c)
 	e3:SetType(EFFECT_TYPE_SINGLE)
 	e3:SetProperty(EFFECT_FLAG_SINGLE_RANGE)
-	e3:SetRange(LOCATION_MZONE)
 	e3:SetCode(EFFECT_UPDATE_ATTACK)
-	e3:SetValue(s.val)
-	e3:SetLabelObject(e1)
+	e3:SetRange(LOCATION_MZONE)
+	e3:SetValue(function(e,c) return e2:GetLabel()*500 end)
 	c:RegisterEffect(e3)
 end
-function s.cost(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then return true end
-	local e1=Effect.CreateEffect(e:GetHandler())
-	e1:SetType(EFFECT_TYPE_FIELD)
-	e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_OATH+EFFECT_FLAG_PLAYER_TARGET)
-	e1:SetTargetRange(1,0)
-	e1:SetCode(EFFECT_SKIP_DP)
-	if Duel.GetTurnPlayer()==tp and Duel.GetCurrentPhase()==PHASE_DRAW then
-		e1:SetLabel(Duel.GetTurnCount())
-		e1:SetCondition(s.skipcon)
-		e1:SetReset(RESET_PHASE+PHASE_DRAW+RESET_SELF_TURN,2)
-	else
-		e1:SetReset(RESET_PHASE+PHASE_DRAW+RESET_SELF_TURN)
-	end
-	Duel.RegisterEffect(e1,tp)
-end
-function s.skipcon(e)
-	return Duel.GetTurnCount()~=e:GetLabel()
-end
-function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
+function s.sptg(e,tp,eg,ep,ev,re,r,rp,chk)
+	local c=e:GetHandler()
 	if chk==0 then return Duel.GetLocationCount(tp,LOCATION_MZONE)>0
-		and e:GetHandler():IsCanBeSpecialSummoned(e,0,tp,false,false) end
-	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,e:GetHandler(),1,0,0)
+		and c:IsCanBeSpecialSummoned(e,0,tp,false,false) end
+	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,c,1,tp,0)
 end
-function s.operation(e,tp,eg,ep,ev,re,r,rp)
+function s.spop(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
-	if Duel.GetLocationCount(tp,LOCATION_MZONE)<=0 then return end
-	if c:IsRelateToEffect(e) then
-		Duel.SpecialSummon(c,0,tp,tp,false,false,POS_FACEUP)
+	if c:IsRelateToEffect(e) and Duel.SpecialSummon(c,0,tp,tp,false,false,POS_FACEUP)>0 then
 		e:SetLabel(e:GetLabel()+1)
+		--It cannot attack this turn
 		local e1=Effect.CreateEffect(c)
+		e1:SetDescription(3206)
 		e1:SetType(EFFECT_TYPE_SINGLE)
+		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_CLIENT_HINT)
 		e1:SetCode(EFFECT_CANNOT_ATTACK)
-		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
-		e1:SetReset(RESET_EVENT+RESETS_STANDARD+RESET_PHASE+PHASE_END)
+		e1:SetReset(RESETS_STANDARD_PHASE_END)
 		c:RegisterEffect(e1)
 	end
-end
-function s.val(e,c)
-	return e:GetLabelObject():GetLabel()*500
-end
+end

unofficial/c511000163.lua

@@ -2,97 +2,85 @@
 --Plasma Eel
 local s,id=GetID()
 function s.initial_effect(c)
-	--equip
+	--This card cannot be destroyed by battle
 	local e1=Effect.CreateEffect(c)
-	e1:SetDescription(aux.Stringid(id,0))
-	e1:SetCategory(CATEGORY_EQUIP)
-	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
-	e1:SetType(EFFECT_TYPE_QUICK_O)
-	e1:SetCode(EVENT_FREE_CHAIN)
-	e1:SetRange(LOCATION_MZONE)
-	e1:SetCondition(s.eqcon)
-	e1:SetTarget(s.eqtg)
-	e1:SetOperation(s.eqop)
+	e1:SetType(EFFECT_TYPE_SINGLE)
+	e1:SetCode(EFFECT_INDESTRUCTABLE_BATTLE)
+	e1:SetValue(1)
 	c:RegisterEffect(e1)
-	--indes battle
+	--Equip this card to a monster on your opponent's side of the field as an Equip Card
 	local e2=Effect.CreateEffect(c)
-	e2:SetType(EFFECT_TYPE_SINGLE)
-	e2:SetCode(EFFECT_INDESTRUCTABLE_BATTLE)
-	e2:SetValue(1)
+	e2:SetDescription(aux.Stringid(id,0))
+	e2:SetCategory(CATEGORY_EQUIP+CATEGORY_ATKCHANGE)
+	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
+	e2:SetProperty(EFFECT_FLAG_CARD_TARGET)
+	e2:SetCode(EVENT_SUMMON_SUCCESS)
+	e2:SetRange(LOCATION_MZONE)
+	e2:SetTarget(s.eqtg)
+	e2:SetOperation(s.eqop)
 	c:RegisterEffect(e2)
-end
-function s.eqcon(e,tp,eg,ep,ev,re,r,rp)
-	return not e:GetHandler():IsStatus(STATUS_CHAINING)
+	local e3=e2:Clone()
+	e3:SetCode(EVENT_FLIP_SUMMON_SUCCESS)
+	c:RegisterEffect(e3)
+	local e4=e2:Clone()
+	e4:SetCode(EVENT_SPSUMMON_SUCCESS)
+	c:RegisterEffect(e4)
 end
 function s.eqtg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
 	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsControler(1-tp) and chkc:IsFaceup() end
 	if chk==0 then return Duel.GetLocationCount(tp,LOCATION_SZONE)>0
 		and Duel.IsExistingTarget(Card.IsFaceup,tp,0,LOCATION_MZONE,1,nil) end
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_FACEUP)
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TARGET)
 	Duel.SelectTarget(tp,Card.IsFaceup,tp,0,LOCATION_MZONE,1,1,nil)
-	Duel.SetOperationInfo(0,CATEGORY_EQUIP,e:GetHandler(),1,0,0)
-end
-function s.eqlimit(e,c)
-	return e:GetOwner()==c
+	Duel.SetOperationInfo(0,CATEGORY_EQUIP,e:GetHandler(),1,tp,0)
 end
 function s.eqop(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
-	if Duel.GetLocationCount(tp,LOCATION_SZONE)<=0 then return end
+	if not c:IsRelateToEffect(e) then return end
 	local tc=Duel.GetFirstTarget()
-	if c:IsRelateToEffect(e) and c:IsFaceup() then
-		if tc:IsFaceup() and tc:IsRelateToEffect(e) then
-			Duel.Equip(tp,c,tc,true)
-			--Add Equip limit
-			local e1=Effect.CreateEffect(tc)
-			e1:SetType(EFFECT_TYPE_SINGLE)
-			e1:SetCode(EFFECT_EQUIP_LIMIT)
-			e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
-			e1:SetReset(RESET_EVENT+RESETS_STANDARD)
-			e1:SetValue(s.eqlimit)
-			c:RegisterEffect(e1)
-			local e2=Effect.CreateEffect(tc)
-			e2:SetType(EFFECT_TYPE_EQUIP)
-			e2:SetCode(EFFECT_UNRELEASABLE_SUM)
-			e2:SetValue(1)
-			e2:SetReset(RESET_EVENT+RESETS_STANDARD)
-			c:RegisterEffect(e2)
-			local e3=e2:Clone()
-			e3:SetCode(EFFECT_UNRELEASABLE_NONSUM)
-			c:RegisterEffect(e3)
-			--atkdown
-			local e4=Effect.CreateEffect(c)
-			e4:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
-			e4:SetCode(EVENT_PHASE+PHASE_END)
-			e4:SetRange(LOCATION_SZONE)
-			e4:SetCountLimit(1)
-			e4:SetCondition(s.atkcon)
-			e4:SetOperation(s.atkop)
-			c:RegisterEffect(e4)
-		else
-			Duel.SendtoGrave(c,REASON_EFFECT)
-		end
+	if not (tc:IsFaceup() and tc:IsRelateToEffect(e) and Duel.GetLocationCount(tp,LOCATION_SZONE)>0) then
+		return Duel.SendtoGrave(c,REASON_RULE)
 	end
-end
-function s.atkcon(e,tp,eg,ep,ev,re,r,rp)
-	return Duel.GetTurnPlayer()==1-tp
-end
-function s.atkop(e,tp,eg,ep,ev,re,r,rp)
-	local c=e:GetHandler()
-	if c:GetFlagEffect(id)==0 then
+	if Duel.Equip(tp,c,tc) then
+		--Equip limit
+		local e0=Effect.CreateEffect(c)
+		e0:SetType(EFFECT_TYPE_SINGLE)
+		e0:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+		e0:SetCode(EFFECT_EQUIP_LIMIT)
+		e0:SetValue(function(e,c) return c==tc end)
+		e0:SetReset(RESET_EVENT|RESETS_STANDARD)
+		c:RegisterEffect(e0)
+		--The equipped monster cannot be Tributed
 		local e1=Effect.CreateEffect(c)
 		e1:SetType(EFFECT_TYPE_EQUIP)
-		e1:SetCode(EFFECT_UPDATE_ATTACK)
-		e1:SetValue(-500)
-		e1:SetReset(RESET_EVENT+RESETS_STANDARD)
+		e1:SetCode(EFFECT_UNRELEASABLE_SUM)
+		e1:SetValue(1)
+		e1:SetReset(RESET_EVENT|RESETS_STANDARD)
 		c:RegisterEffect(e1)
-		c:RegisterFlagEffect(id,RESET_EVENT+RESETS_STANDARD,0,1)
-		e:SetLabelObject(e1)
-		e:SetLabel(2)
-	else
-		local ct=e:GetLabel()
-		e:SetLabel(ct+1)
-		local pe=e:GetLabelObject()
-		if not pe or e:GetLabelObject():IsDeleted() then return end
-		pe:SetValue(ct*-500)
+		local e2=e1:Clone()
+		e2:SetCode(EFFECT_UNRELEASABLE_NONSUM)
+		c:RegisterEffect(e2)
+		--The equipped monster loses 500 ATK during each of your opponent's End Phases
+		local e3=Effect.CreateEffect(c)
+		e3:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
+		e3:SetCode(EVENT_PHASE+PHASE_END)
+		e3:SetRange(LOCATION_SZONE)
+		e3:SetCountLimit(1)
+		e3:SetCondition(function(e,tp) return Duel.IsTurnPlayer(1-tp) end)
+		e3:SetOperation(s.atkop)
+		e3:SetReset(RESET_EVENT|RESETS_STANDARD)
+		c:RegisterEffect(e3)
 	end
 end
+function s.atkop(e,tp,eg,ep,ev,re,r,rp)
+	Duel.Hint(HINT_CARD,0,id)
+	local c=e:GetHandler()
+	--The equipped monster loses 500 ATK
+	local e1=Effect.CreateEffect(c)
+	e1:SetType(EFFECT_TYPE_SINGLE)
+	e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+	e1:SetCode(EFFECT_UPDATE_ATTACK)
+	e1:SetValue(-500)
+	e1:SetReset(RESET_EVENT|RESETS_STANDARD)
+	c:GetEquipTarget():RegisterEffect(e1)
+end