Various script fixes

- Amazoness Princess: Simplify the zone checking for the cost.
- Hieratic Dragon of Gebeb: Shouldn't set the ATK/DEF to 0 with its 2nd effect.
- Hieratic Seal From the Ashes: The 2nd effect should target and select the card on activation. The 3rd effect should activate even if there's no valid target since it's mandatory.
- Mysterion the Dragon Crown: Should do nothing if the target is face-down on resolution.
- Numeron Creation: Don't apply the effect if it's somehow already been applied by the time the card resolves.
- Penguin Cleric: Should trigger even if the "Penguin" monster was face-down in the Monster Zone.
- Phantom Fortress Enterblathnir: Should be able to chain the effect of "Ghost Belle & Haunted Mansion" if its GY banishing effect is used + removed "Spirit Elimination" handling.
- The Agent of Mystery - Earth: Simplify the logic for searching "Master Hyperion".
- The Despair Uranus: Simplify the logic for choosing what to Set.

Author: pyrQ

official/c13735899.lua

@@ -3,8 +3,8 @@
 --Scripted by Eerie Code
 local s,id=GetID()
 function s.initial_effect(c)
-	--Fusion Summon
 	c:EnableReviveLimit()
+	--Fusion Materials: 1 Spellcaster monster + 1 Dragon monster
 	Fusion.AddProcMix(c,true,true,aux.FilterBoolFunctionEx(Card.IsRace,RACE_SPELLCASTER),aux.FilterBoolFunctionEx(Card.IsRace,RACE_DRAGON))
 	--Cannot be used as Fusion Material
 	local e0=Effect.CreateEffect(c)
@@ -13,37 +13,38 @@ function s.initial_effect(c)
 	e0:SetCode(EFFECT_CANNOT_BE_FUSION_MATERIAL)
 	e0:SetValue(1)
 	c:RegisterEffect(e0)
-	--Decreak ATK by 100 per banished card
+	--This card loses 100 ATK for each of your banished cards
 	local e1=Effect.CreateEffect(c)
 	e1:SetType(EFFECT_TYPE_SINGLE)
-	e1:SetCode(EFFECT_UPDATE_ATTACK)
 	e1:SetProperty(EFFECT_FLAG_SINGLE_RANGE)
+	e1:SetCode(EFFECT_UPDATE_ATTACK)
 	e1:SetRange(LOCATION_MZONE)
 	e1:SetValue(function(e,cc) return Duel.GetFieldGroupCount(e:GetHandlerPlayer(),LOCATION_REMOVED,0)*-100 end)
 	c:RegisterEffect(e1)
-	--Banish monsters
-	local e2=Effect.CreateEffect(c)
-	e2:SetDescription(aux.Stringid(id,0))
-	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
-	e2:SetProperty(EFFECT_FLAG_DELAY+EFFECT_FLAG_CARD_TARGET)
-	e2:SetCode(EVENT_CUSTOM+id)
-	e2:SetRange(LOCATION_MZONE)
-	e2:SetCountLimit(1,id)
-	e2:SetTarget(s.rmtg)
-	e2:SetOperation(s.rmop)
-	c:RegisterEffect(e2)
-	local g=Group.CreateGroup()
-	g:KeepAlive()
-	e2:SetLabelObject(g)
-	--Register summons
+	--Banish 1 Special Summoned monster, also banish all monsters from the field with its same original Type
 	local e2a=Effect.CreateEffect(c)
-	e2a:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
-	e2a:SetCode(EVENT_SPSUMMON_SUCCESS)
-	e2a:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+	e2a:SetDescription(aux.Stringid(id,0))
+	e2a:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
+	e2a:SetProperty(EFFECT_FLAG_DELAY+EFFECT_FLAG_CARD_TARGET)
+	e2a:SetCode(EVENT_CUSTOM+id)
 	e2a:SetRange(LOCATION_MZONE)
-	e2a:SetLabelObject(e2)
-	e2a:SetOperation(s.regop)
+	e2a:SetCountLimit(1,id)
+	e2a:SetCondition(function() return not Duel.IsPhase(PHASE_DAMAGE) end)
+	e2a:SetTarget(s.rmtg)
+	e2a:SetOperation(s.rmop)
 	c:RegisterEffect(e2a)
+	local g=Group.CreateGroup()
+	g:KeepAlive()
+	e2a:SetLabelObject(g)
+	--Register summons
+	local e2b=Effect.CreateEffect(c)
+	e2b:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
+	e2b:SetCode(EVENT_SPSUMMON_SUCCESS)
+	e2b:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+	e2b:SetRange(LOCATION_MZONE)
+	e2b:SetLabelObject(e2a)
+	e2b:SetOperation(s.regop)
+	c:RegisterEffect(e2b)
 end
 function s.tgfilter(c,rc,e)
 	return c:IsLocation(LOCATION_MZONE) and (rc==c or (c:IsFaceup() and rc:IsOriginalRace(c:GetOriginalRace())))
@@ -57,7 +58,6 @@ function s.rmtg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
 	local g=e:GetLabelObject():Filter(s.tgfilter2,nil,e)
 	if chkc then return g:IsContains(chkc) and s.tgfilter(chkc,nil) end
 	if chk==0 then return #g>0 end
-	Duel.RegisterFlagEffect(tp,id,RESET_PHASE|PHASE_END,0,1)
 	local tc=nil
 	if #g==1 then
 		tc=g:GetFirst()
@@ -67,21 +67,18 @@ function s.rmtg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
 		tc=g:Select(tp,1,1,nil)
 		Duel.SetTargetCard(tc)
 	end
-	Duel.SetOperationInfo(0,CATEGORY_REMOVE,tc,1,0,0)
+	Duel.SetOperationInfo(0,CATEGORY_REMOVE,tc,1,tp,0)
 end
 function s.rmop(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
-	if tc:IsRelateToEffect(e) then
-		local g=Group.FromCards(tc)
-		if tc:IsFaceup() then
-			g=g+Duel.GetMatchingGroup(aux.FaceupFilter(Card.IsOriginalRace,tc:GetOriginalRace()),tp,LOCATION_MZONE,LOCATION_MZONE,tc)
-		end
+	if tc:IsRelateToEffect(e) and tc:IsFaceup() then
+		local g=Duel.GetMatchingGroup(aux.FaceupFilter(Card.IsOriginalRace,tc:GetOriginalRace()),tp,LOCATION_MZONE,LOCATION_MZONE,tc)+tc
 		Duel.Remove(g,POS_FACEUP,REASON_EFFECT)
 	end
 end
 function s.regop(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
-	if Duel.HasFlagEffect(tp,id) or eg:IsContains(c) then return end
+	if eg:IsContains(c) then return end
 	local rc=re:GetHandler()
 	if not (re and re:IsActivated() and re:IsMonsterEffect() and rc) then return end
 	local tg=eg:Filter(s.tgfilter,nil,rc)

official/c32588805.lua

@@ -1,66 +1,50 @@
---The despair URANUS
+--Ｔｈｅ ｄｅｓｐａｉｒ ＵＲＡＮＵＳ
 --The Despair Uranus
 local s,id=GetID()
 function s.initial_effect(c)
-	--set
+	--Your opponent declares either Continuous Spell or Continuous Trap, then you Set 1 card of that type from your Deck
 	local e1=Effect.CreateEffect(c)
 	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
 	e1:SetCode(EVENT_SUMMON_SUCCESS)
-	e1:SetCondition(s.setcon)
+	e1:SetCondition(function(e,tp) return e:GetHandler():IsTributeSummoned() and not Duel.IsExistingMatchingCard(Card.IsSpellTrap,tp,LOCATION_ONFIELD,0,1,nil) end)
 	e1:SetTarget(s.settg)
 	e1:SetOperation(s.setop)
 	c:RegisterEffect(e1)
-	--atkup
+	--This card gains 300 ATK for each face-up Spell/Trap you control
 	local e2=Effect.CreateEffect(c)
 	e2:SetType(EFFECT_TYPE_SINGLE)
 	e2:SetProperty(EFFECT_FLAG_SINGLE_RANGE)
 	e2:SetCode(EFFECT_UPDATE_ATTACK)
 	e2:SetRange(LOCATION_MZONE)
-	e2:SetValue(s.atkval)
+	e2:SetValue(function(e,c) return Duel.GetMatchingGroupCount(aux.FaceupFilter(Card.IsSpellTrap),e:GetHandlerPlayer(),LOCATION_ONFIELD,0,nil)*300 end)
 	c:RegisterEffect(e2)
-	--indes
+	--Face-up cards in your Spell & Trap Zone cannot be destroyed by card effects
 	local e3=Effect.CreateEffect(c)
 	e3:SetType(EFFECT_TYPE_FIELD)
 	e3:SetCode(EFFECT_INDESTRUCTABLE_EFFECT)
 	e3:SetRange(LOCATION_MZONE)
-	e3:SetTargetRange(LOCATION_SZONE,0)
-	e3:SetTarget(s.indtg)
+	e3:SetTargetRange(LOCATION_STZONE,0)
+	e3:SetTarget(function(e,c) return c:IsFaceup() end)
 	e3:SetValue(1)
 	c:RegisterEffect(e3)
 end
-function s.setcon(e,tp,eg,ep,ev,re,r,rp)
-	return e:GetHandler():IsTributeSummoned()
-		and not Duel.IsExistingMatchingCard(Card.IsSpellTrap,tp,LOCATION_ONFIELD,0,1,nil)
-end
-function s.setfilter1(c)
-	return c:IsType(TYPE_CONTINUOUS) and c:IsSSetable()
+function s.setfilter(c)
+	return c:IsContinuousSpellTrap() and c:IsSSetable()
 end
 function s.settg(e,tp,eg,ep,ev,re,r,rp,chk)
 	if chk==0 then return Duel.GetLocationCount(tp,LOCATION_SZONE)>0
-		and Duel.IsExistingMatchingCard(s.setfilter1,tp,LOCATION_DECK,0,1,nil) end
-end
-function s.setfilter2(c,typ)
-	return c:GetType()==typ and c:IsSSetable()
+		and Duel.IsExistingMatchingCard(s.setfilter,tp,LOCATION_DECK,0,1,nil) end
 end
 function s.setop(e,tp,eg,ep,ev,re,r,rp)
 	if Duel.GetLocationCount(tp,LOCATION_SZONE)<=0 then return end
-	Duel.Hint(HINT_SELECTMSG,1-tp,HINTMSG_OPTION)
-	local op=Duel.SelectOption(1-tp,71,72)
+	local op=Duel.SelectOption(1-tp,aux.Stringid(id,1),aux.Stringid(id,2))
+	local g=Duel.GetMatchingGroup(s.setfilter,tp,LOCATION_DECK,0,nil)
+	if #g==0 then return end
+	local filter=op==0 and Card.IsContinuousSpell or Card.IsContinuousTrap
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SET)
-	local g=nil
-	if op==0 then g=Duel.SelectMatchingCard(tp,s.setfilter2,tp,LOCATION_DECK,0,1,1,nil,TYPE_SPELL+TYPE_CONTINUOUS)
-	else g=Duel.SelectMatchingCard(tp,s.setfilter2,tp,LOCATION_DECK,0,1,1,nil,TYPE_TRAP+TYPE_CONTINUOUS) end
-	if #g>0 then
-		Duel.SSet(tp,g:GetFirst())
+	local sg=g:FilterSelect(tp,filter,1,1,nil)
+	if #sg>0 then
+		Duel.SSet(tp,sg)
 	end
-end
-function s.atkfilter(c)
-	return c:IsSpellTrap() and c:IsFaceup()
-end
-function s.atkval(e,c)
-	return Duel.GetMatchingGroupCount(s.atkfilter,e:GetHandlerPlayer(),LOCATION_ONFIELD,0,nil)*300
-end
-function s.indtg(e,c)
-	return c:GetSequence()<5 and c:IsFaceup()
 end

official/c42378577.lua

@@ -3,36 +3,35 @@
 local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
+	local e0=Effect.CreateEffect(c)
+	e0:SetType(EFFECT_TYPE_ACTIVATE)
+	e0:SetCode(EVENT_FREE_CHAIN)
+	c:RegisterEffect(e0)
+	--Special Summon 1 card from your Pendulum Zone
 	local e1=Effect.CreateEffect(c)
-	e1:SetType(EFFECT_TYPE_ACTIVATE)
+	e1:SetDescription(aux.Stringid(id,0))
+	e1:SetCategory(CATEGORY_SPECIAL_SUMMON)
+	e1:SetType(EFFECT_TYPE_QUICK_O)
+	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetCode(EVENT_FREE_CHAIN)
-	e1:SetHintTiming(0,TIMING_END_PHASE)
+	e1:SetRange(LOCATION_SZONE)
+	e1:SetHintTiming(0,TIMING_STANDBY_PHASE|TIMING_MAIN_END|TIMINGS_CHECK_MONSTER_E)
+	e1:SetCountLimit(1,id)
+	e1:SetTarget(s.sptg)
+	e1:SetOperation(s.spop)
 	c:RegisterEffect(e1)
-	--special summon
+	--Place 1 Pendulum Monster from your Monster Zone in your Pendulum Zone
 	local e2=Effect.CreateEffect(c)
-	e2:SetDescription(aux.Stringid(id,0))
-	e2:SetCategory(CATEGORY_SPECIAL_SUMMON)
+	e2:SetDescription(aux.Stringid(id,1))
 	e2:SetType(EFFECT_TYPE_QUICK_O)
 	e2:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e2:SetCode(EVENT_FREE_CHAIN)
 	e2:SetRange(LOCATION_SZONE)
-	e2:SetHintTiming(0,TIMING_END_PHASE)
+	e2:SetHintTiming(0,TIMING_STANDBY_PHASE|TIMING_MAIN_END|TIMINGS_CHECK_MONSTER_E)
 	e2:SetCountLimit(1,id)
-	e2:SetTarget(s.sptg)
-	e2:SetOperation(s.spop)
+	e2:SetTarget(s.pentg)
+	e2:SetOperation(s.penop)
 	c:RegisterEffect(e2)
-	--place in pendulum zone
-	local e3=Effect.CreateEffect(c)
-	e3:SetDescription(aux.Stringid(id,1))
-	e3:SetType(EFFECT_TYPE_QUICK_O)
-	e3:SetCode(EVENT_FREE_CHAIN)
-	e3:SetProperty(EFFECT_FLAG_CARD_TARGET)
-	e3:SetRange(LOCATION_SZONE)
-	e3:SetHintTiming(0,TIMING_END_PHASE)
-	e3:SetCountLimit(1,id)
-	e3:SetTarget(s.pentg)
-	e3:SetOperation(s.penop)
-	c:RegisterEffect(e3)
 end
 function s.spfilter(c,e,tp)
 	return c:IsCanBeSpecialSummoned(e,0,tp,false,false)
@@ -43,28 +42,24 @@ function s.sptg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
 		and Duel.IsExistingTarget(s.spfilter,tp,LOCATION_PZONE,0,1,nil,e,tp) end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
 	local g=Duel.SelectTarget(tp,s.spfilter,tp,LOCATION_PZONE,0,1,1,nil,e,tp)
-	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,g,1,0,0)
+	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,g,1,tp,0)
 end
 function s.spop(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
 	if tc:IsRelateToEffect(e) then
 		Duel.SpecialSummon(tc,0,tp,tp,false,false,POS_FACEUP)
 	end
 end
-function s.filter(c)
-	return c:IsFaceup() and c:IsType(TYPE_PENDULUM)
-end
 function s.pentg(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsControler(tp) and s.filter(chkc) end
+	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsControler(tp) and chkc:IsType(TYPE_PENDULUM) and chkc:IsFaceup() end
 	if chk==0 then return Duel.CheckPendulumZones(tp)
-		and Duel.IsExistingTarget(s.filter,tp,LOCATION_MZONE,0,1,nil) end
-	Duel.Hint(HINT_SELECTMSG,tp,aux.Stringid(id,2))
-	local g=Duel.SelectTarget(tp,s.filter,tp,LOCATION_MZONE,0,1,1,nil)
+		and Duel.IsExistingTarget(aux.FaceupFilter(Card.IsType,TYPE_PENDULUM),tp,LOCATION_MZONE,0,1,nil) end
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TOFIELD)
+	Duel.SelectTarget(tp,aux.FaceupFilter(Card.IsType,TYPE_PENDULUM),tp,LOCATION_MZONE,0,1,1,nil)
 end
 function s.penop(e,tp,eg,ep,ev,re,r,rp)
-	if not Duel.CheckPendulumZones(tp) then return end
 	local tc=Duel.GetFirstTarget()
-	if tc:IsFaceup() and tc:IsRelateToEffect(e) then
+	if tc:IsRelateToEffect(e) and tc:IsFaceup() then
 		Duel.MoveToField(tc,tp,tp,LOCATION_PZONE,POS_FACEUP,true)
 	end
 end

official/c46382143.lua

@@ -3,8 +3,9 @@
 --Scripted by Larry126
 local s,id=GetID()
 function s.initial_effect(c)
-	--Activate
+	--Special Summon 1 "Number" Dragon Xyz Monster from your Extra Deck, then attach this card on the field to it as material
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetCategory(CATEGORY_SPECIAL_SUMMON)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_FREE_CHAIN)
@@ -14,28 +15,30 @@ function s.initial_effect(c)
 	c:RegisterEffect(e1)
 end
 s.listed_series={SET_GALAXY_EYES,SET_NUMBER}
-function s.cfilter(c)
-	return c:IsFaceup() and c:IsRace(RACE_DRAGON) and c:IsAttribute(ATTRIBUTE_LIGHT) and c:GetBaseAttack()>=3000
+function s.confilter(c)
+	return c:IsAttribute(ATTRIBUTE_LIGHT) and c:IsRace(RACE_DRAGON) and c:GetBaseAttack()>=3000 and c:IsFaceup()
 end
 function s.condition(e,tp,eg,ep,ev,re,r,rp)
-	return Duel.GetMatchingGroupCount(s.cfilter,tp,LOCATION_MZONE,LOCATION_MZONE,nil)>=3
+	return Duel.IsExistingMatchingCard(s.confilter,tp,LOCATION_MZONE,LOCATION_MZONE,3,nil)
 end
 function s.spfilter(c,e,tp)
-	return c:IsRace(RACE_DRAGON) and c:IsSetCard(SET_NUMBER) and c:IsType(TYPE_XYZ) and Duel.GetLocationCountFromEx(tp,tp,nil,c)>0
+	return c:IsSetCard(SET_NUMBER) and c:IsRace(RACE_DRAGON) and c:IsType(TYPE_XYZ) and Duel.GetLocationCountFromEx(tp,tp,nil,c)>0
 		and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
 end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then return Duel.GetFlagEffect(tp,id)==0 and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_EXTRA,0,1,nil,e,tp) end
+	if chk==0 then return not Duel.HasFlagEffect(tp,id)
+		and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_EXTRA,0,1,nil,e,tp) end
 	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,LOCATION_EXTRA)
 end
 function s.activate(e,tp,eg,ep,ev,re,r,rp)
+	if Duel.HasFlagEffect(tp,id) then return end
 	Duel.RegisterFlagEffect(tp,id,RESET_PHASE|PHASE_END,0,1)
 	local c=e:GetHandler()
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
-	local tc=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_EXTRA,0,1,1,nil,e,tp):GetFirst()
-	if tc and Duel.SpecialSummon(tc,0,tp,tp,false,false,POS_FACEUP)>0 and c:IsRelateToEffect(e) then
+	local sc=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_EXTRA,0,1,1,nil,e,tp):GetFirst()
+	if sc and Duel.SpecialSummon(sc,0,tp,tp,false,false,POS_FACEUP)>0 and c:IsRelateToEffect(e) then
 		Duel.BreakEffect()
 		c:CancelToGrave()
-		Duel.Overlay(tc,c)
+		Duel.Overlay(sc,c)
 	end
 end