Unofficial card script fixes

- Evil Hero Infernal Prodigy (Anime): Its draw effect should trigger if sent to the GY in any way and should negate the drawn card's effects for that turn.
- Exchanging Notes: Overhauled the script and fixed script errors. Should skip the BP only if a monster is exchanged. Any effects applied on the exchanged cards should disappear if they leave the hand. Also added various strings.
- Judgment of Anubis (Anime): All of the damage should be inflicted to the opponent. Shouldn't be able to use it without any monsters to destroy on the field.
- Link Recovery: Heavily simplify the script, prevent some potential script errors, and add a hint on the summoned card and the player.
- One-on-One Fight: Have the turn player choose a monster that can attack. Add proper checks to prevent script errors if there isn't a monster to select on resolution.
- Salamangreat Sparks: The equipped monster shouldn't have its ATK changed if it battles your monster. Update the Special Summoning effect and simplify the prompts. Also added various strings.

Author: pyrQ

unofficial/c511000476.lua

@@ -1,36 +1,35 @@
+--一騎討ち
 --One-on-One Fight
 local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_FREE_CHAIN)
+	e1:SetHintTiming(0,TIMING_STANDBY_PHASE|TIMING_MAIN_END|TIMINGS_CHECK_MONSTER_E)
 	e1:SetTarget(s.target)
 	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
 end
-function s.filter(c)
-	return c:IsFaceup()
-end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then return Duel.IsExistingMatchingCard(Card.IsFaceup,tp,0,LOCATION_MZONE,1,nil) and Duel.IsExistingMatchingCard(Card.IsFaceup,tp,LOCATION_MZONE,0,1,nil) end
-end
-function s.activate(e,tp,eg,ep,ev,re,r,rp)
-	local g1=Duel.GetMatchingGroup(Card.IsFaceup,Duel.GetTurnPlayer(),LOCATION_MZONE,0,nil)
-	local sg1=nil
-	if #g1>0 then
-		local tg=g1:GetMaxGroup(Card.GetAttack)
-		sg1=tg:Select(Duel.GetTurnPlayer(),1,1,nil)
-		Duel.HintSelection(sg1)
-	end
-	local g2=Duel.GetMatchingGroup(Card.IsFaceup,1-Duel.GetTurnPlayer(),LOCATION_MZONE,0,nil)
-	local sg2=nil
-	if #g2>0 then
-		local tg=g2:GetMaxGroup(Card.GetAttack)
-		sg2=tg:Select(1-Duel.GetTurnPlayer(),1,1,nil)
-		Duel.HintSelection(sg2)
-	end
-	if #sg1>0 and #sg2>0 then
-		Duel.CalculateDamage(sg1:GetFirst(),sg2:GetFirst())
+	if chk==0 then
+		local turn_player=Duel.GetTurnPlayer()
+		return Duel.IsExistingMatchingCard(aux.FaceupFilter(Card.CanAttack),turn_player,LOCATION_MZONE,0,1,nil)
+			and Duel.IsExistingMatchingCard(Card.IsFaceup,turn_player,0,LOCATION_MZONE,1,nil)
 	end
 end
+function s.activate(e,tp,eg,ep,ev,re,r,rp)
+	local turn_player=Duel.GetTurnPlayer()
+	local g1=Duel.GetMatchingGroup(aux.FaceupFilter(Card.CanAttack),turn_player,LOCATION_MZONE,0,nil)
+	if #g1==0 then return end
+	local g2=Duel.GetMatchingGroup(Card.IsFaceup,turn_player,0,LOCATION_MZONE,nil)
+	if #g2==0 then return end
+	Duel.Hint(HINT_SELECTMSG,turn_player,HINTMSG_SELF)
+	local bc1=(g1:GetMaxGroup(Card.GetAttack):Select(turn_player,1,1,nil)):GetFirst()
+	Duel.HintSelection(bc1)
+	Duel.Hint(HINT_SELECTMSG,1-turn_player,HINTMSG_SELF)
+	local bc2=(g2:GetMaxGroup(Card.GetAttack):Select(1-turn_player,1,1,nil)):GetFirst()
+	Duel.HintSelection(bc2)
+	Duel.CalculateDamage(bc1,bc2)
+end

unofficial/c511002446.lua

@@ -1,40 +1,31 @@
---アヌビスの裁き
+--アヌビスの裁き (Anime)
+--Judgment of Anubis (Anime)
 local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetCategory(CATEGORY_DISABLE+CATEGORY_DESTROY+CATEGORY_DAMAGE)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_CHAINING)
-	e1:SetCondition(s.condition)
+	e1:SetCondition(function(e,tp,eg,ep,ev,re,r,rp) return rp==1-tp and re:IsSpellEffect() and re:IsHasType(EFFECT_TYPE_ACTIVATE) and Duel.IsChainDisablable(ev) end)
 	e1:SetTarget(s.target)
 	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
 end
-function s.condition(e,tp,eg,ep,ev,re,r,rp)
-	return rp~=tp and re:IsHasType(EFFECT_TYPE_ACTIVATE) and re:IsActiveType(TYPE_SPELL) and Duel.IsChainDisablable(ev)
-end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then return true end
-	Duel.SetOperationInfo(0,CATEGORY_DISABLE,eg,1,0,0)
-	local g=Duel.GetMatchingGroup(Card.IsDestructable,tp,LOCATION_MZONE,LOCATION_MZONE,nil)
-	Duel.SetOperationInfo(0,CATEGORY_DESTROY,g,#g,0,0)
-	Duel.SetOperationInfo(0,CATEGORY_DAMAGE,nil,0,PLAYER_ALL,0)
-end
-function s.filter(c,tp)
-	return c:IsPreviousControler(tp)
+	local g=Duel.GetMatchingGroup(nil,tp,LOCATION_MZONE,LOCATION_MZONE,nil)
+	if chk==0 then return #g>0 end
+	Duel.SetOperationInfo(0,CATEGORY_DISABLE,eg,1,tp,0)
+	Duel.SetOperationInfo(0,CATEGORY_DESTROY,g,#g,tp,0)
+	Duel.SetOperationInfo(0,CATEGORY_DAMAGE,nil,0,1-tp,g:GetSum(Card.GetAttack))
 end
 function s.activate(e,tp,eg,ep,ev,re,r,rp)
-	Duel.NegateEffect(ev)
-	local sg=Duel.GetMatchingGroup(Card.IsDestructable,tp,LOCATION_MZONE,LOCATION_MZONE,nil)
-	if Duel.Destroy(sg,REASON_EFFECT)>0 then
-		local dg=Duel.GetOperatedGroup()
-		local sg1=dg:Filter(Card.IsPreviousControler,nil,tp)
-		local sg2=dg:Filter(Card.IsPreviousControler,nil,1-tp)
-		local sum1=sg1:GetSum(Card.GetAttack)/2
-		local sum2=sg2:GetSum(Card.GetAttack)/2
-		Duel.Damage(tp,sum1,REASON_EFFECT,true)
-		Duel.Damage(1-tp,sum2,REASON_EFFECT,true)
-		Duel.RDComplete()
+	if not Duel.NegateEffect(ev) then return end
+	local g=Duel.GetMatchingGroup(nil,tp,LOCATION_MZONE,LOCATION_MZONE,nil)
+	if #g==0 then return end
+	local dam=g:GetSum(Card.GetAttack)/2
+	if Duel.Destroy(g,REASON_EFFECT)>0 and dam>0 then
+		Duel.Damage(1-tp,dam,REASON_EFFECT)
 	end
-end
+end

unofficial/c511004431.lua

@@ -1,68 +1,77 @@
+--青春の交換日記
 --Exchanging Notes
---cleaned up by MLD
 local s,id=GetID()
+local SET_GUTSMASTER=0x526
 function s.initial_effect(c)
-	--activate
+	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
+	e1:SetCategory(CATEGORY_DRAW+CATEGORY_TOHAND)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_FREE_CHAIN)
-	e1:SetCondition(s.condition)
+	e1:SetCondition(function(e,tp) return Duel.IsExistingMatchingCard(aux.FaceupFilter(Card.IsSetCard,SET_GUTSMASTER),tp,LOCATION_MZONE,0,1,nil) end)
 	e1:SetTarget(s.target)
 	e1:SetOperation(s.operation)
 	c:RegisterEffect(e1)
 end
-s.listed_series={0x526}
-function s.condition(e,tp,eg,ev,ep,re,r,rp)
-	return Duel.IsExistingMatchingCard(aux.FaceupFilter(Card.IsSetCard,0x526),tp,LOCATION_MZONE,0,1,nil)
-end
+s.listed_series={SET_GUTSMASTER}
 function s.target(e,tp,eg,ev,ep,re,r,rp,chk)
 	if chk==0 then return Duel.IsPlayerCanDraw(tp,2) end
 	Duel.SetOperationInfo(0,CATEGORY_DRAW,nil,0,tp,2)
 end
 function s.operation(e,tp,eg,ev,ep,re,r,rp)
-	if Duel.Draw(tp,2,REASON_EFFECT)==2 then
-		local g=Duel.GetOperatedGroup()
-		Duel.SendtoHand(g,1-tp,REASON_EFFECT)
+	if Duel.Draw(tp,2,REASON_EFFECT)~=2 then return end
+	local sg=nil
+	local g=Duel.GetOperatedGroup()
+	if Duel.SendtoHand(g,1-tp,REASON_EFFECT)>0 then
+		Duel.ShuffleHand(1-tp)
 		local hg=Duel.GetFieldGroup(tp,0,LOCATION_HAND)
+		Duel.BreakEffect()
 		Duel.ConfirmCards(tp,hg)
-		local sg=hg:Select(tp,2,2,nil)
-		Duel.SendtoHand(sg,tp,REASON_EFFECT)
-		g:Merge(sg)
-		g:KeepAlive()
-		local e1=Effect.CreateEffect(e:GetHandler())
-		e1:SetType(EFFECT_TYPE_FIELD)
-		e1:SetCode(EFFECT_SKIP_BP)
-		e1:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
-		e1:SetTargetRange(1,0)
-		e1:SetReset(RESET_PHASE+PHASE_END)
-		Duel.RegisterEffect(e1,tp)
-		local e2=Effect.CreateEffect(e:GetHandler())
-		e2:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
-		e2:SetCode(EVENT_PHASE+PHASE_END)
-		e2:SetLabelObject(g1)
-		e2:SetCountLimit(1)
-		e2:SetReset(RESET_PHASE+PHASE_END)
-		e2:SetOperation(s.retop)
-		Duel.RegisterEffect(e2,tp)
-		local tg=sg:Filter(Card.IsMonster,nil)
-		local gc=tg:GetFirst()
-		while gc do
-			local e1=Effect.CreateEffect(e:GetHandler())
+		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATOHAND)
+		sg=hg:Select(tp,2,2,nil)
+		if #sg>0 then
+			Duel.SendtoHand(sg,tp,REASON_EFFECT)
+			Duel.ShuffleHand(tp)
+		end
+	end
+	local c=e:GetHandler()
+	local exch_g=g+sg
+	local mon_g=exch_g:Filter(Card.IsMonster,nil)
+	if #mon_g>0 then
+		for tc in mon_g:Iter() do
+			--If a monster(s) was exchanged by this effect, they cannot be Normal or Special Summoned
+			local e1=Effect.CreateEffect(c)
 			e1:SetType(EFFECT_TYPE_SINGLE)
 			e1:SetCode(EFFECT_CANNOT_SUMMON)
-			e1:SetReset(RESET_PHASE+PHASE_END)
-			gc:RegisterEffect(e1)
+			e1:SetReset(RESET_EVENT|RESETS_STANDARD)
+			tc:RegisterEffect(e1)
 			local e2=e1:Clone()
 			e2:SetCode(EFFECT_CANNOT_SPECIAL_SUMMON)
-			gc:RegisterEffect(e2)
-			gc=tg:GetNext()
+			tc:RegisterEffect(e2)
 		end
+		--Skip this turn's Battle Phase
+		local e3=Effect.CreateEffect(c)
+		e3:SetDescription(aux.Stringid(id,1))
+		e3:SetType(EFFECT_TYPE_FIELD)
+		e3:SetProperty(EFFECT_FLAG_PLAYER_TARGET+EFFECT_FLAG_CLIENT_HINT)
+		e3:SetCode(EFFECT_SKIP_BP)
+		e3:SetTargetRange(1,0)
+		e3:SetReset(RESET_PHASE|PHASE_END)
+		Duel.RegisterEffect(e3,Duel.GetTurnPlayer())
 	end
-end
-function s.retop(e,tp,eg,ep,ev,re,r,rp)
-	local g=e:GetLabelObject()
-	if g and #g>0 then
-		Duel.SendtoHand(g,nil,REASON_EFFECT)
+	if #exch_g>0 then
+		--Cards exchanged by this effect are returned to their owner's hand during the End Phase of this turn
+		aux.DelayedOperation(exch_g,PHASE_END,id,e,tp,s.thop,nil,nil,nil,aux.Stringid(id,2))
 	end
-	g:DeleteGroup()
 end
+function s.thop(ag)
+	local turn_player=Duel.GetTurnPlayer()
+	local ag1,ag2=ag:Split(Card.IsOwner,nil,turn_player)
+	if #ag1>0 then
+		Duel.SendtoHand(ag1,turn_player,REASON_EFFECT)
+	end
+	if #ag2>0 then
+		Duel.SendtoHand(ag2,1-turn_player,REASON_EFFECT)
+	end
+end

unofficial/c511009738.lua

@@ -1,105 +1,72 @@
 --リンク・リカバリー
 --Link Recovery
---fixed by Larry126 & MLD
 local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetCategory(CATEGORY_SPECIAL_SUMMON+CATEGORY_DRAW)
-	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
+	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetTarget(s.target)
 	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
 end
-function s.filter(c,e,tp)
+function s.spfilter(c,e,tp)
 	return c:IsLinkMonster() and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
 end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsControler(tp) and chkc:IsLocation(LOCATION_GRAVE) and s.filter(chkc,e,tp) end
+	if chkc then return chkc:IsControler(tp) and chkc:IsLocation(LOCATION_GRAVE) and s.spfilter(chkc,e,tp) end
 	if chk==0 then return Duel.GetLocationCount(tp,LOCATION_MZONE)>0
-		and Duel.IsExistingTarget(s.filter,tp,LOCATION_GRAVE,0,1,nil,e,tp) end
+		and Duel.IsExistingTarget(s.spfilter,tp,LOCATION_GRAVE,0,1,nil,e,tp) end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
-	local tc=Duel.SelectTarget(tp,s.filter,tp,LOCATION_GRAVE,0,1,1,nil,e,tp):GetFirst()
+	local tc=Duel.SelectTarget(tp,s.spfilter,tp,LOCATION_GRAVE,0,1,1,nil,e,tp):GetFirst()
 	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,tc,1,tp,LOCATION_GRAVE)
 	local ct=tc:GetLink()-Duel.GetFieldGroupCount(tp,0,LOCATION_MZONE,nil)
 	if ct>0 then
 		Duel.SetOperationInfo(0,CATEGORY_DRAW,nil,0,1-tp,ct)
 	end
+	Duel.SetPossibleOperationInfo(0,CATEGORY_DRAW,nil,0,1-tp,1)
 end
 function s.activate(e,tp,eg,ep,ev,re,r,rp)
 	local tc=Duel.GetFirstTarget()
-	if tc and tc:IsRelateToEffect(e) and Duel.SpecialSummon(tc,0,tp,tp,false,false,POS_FACEUP)>0 then
-		local c=e:GetHandler()
+	if tc:IsRelateToEffect(e) and Duel.SpecialSummon(tc,0,tp,tp,false,false,POS_FACEUP)>0 then
 		local ct=tc:GetLink()-Duel.GetFieldGroupCount(tp,0,LOCATION_MZONE,nil)
 		if ct>0 then
 			Duel.Draw(1-tp,ct,REASON_EFFECT)
 		end
-		tc:RegisterFlagEffect(id,RESET_EVENT+RESETS_STANDARD,0,1)
+		local c=e:GetHandler()
+		--You cannot conduct your Battle Phase the turn the Special Summoned monster is used as material for a Link Summon
 		local e1=Effect.CreateEffect(c)
-		e1:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
+		e1:SetDescription(aux.Stringid(id,1))
+		e1:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_CONTINUOUS)
+		e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_CLIENT_HINT)
 		e1:SetCode(EVENT_BE_MATERIAL)
-		e1:SetCondition(s.con)
-		e1:SetOperation(s.op)
-		Duel.RegisterEffect(e1,tp)
+		e1:SetCondition(function(e,tp,eg,ep,ev,re,r,rp) return r==REASON_LINK end)
+		e1:SetOperation(s.cannotbpop)
+		e1:SetReset(RESET_EVENT|RESETS_STANDARD&~(RESET_TOGRAVE|RESET_REMOVE|RESET_LEAVE))
+		tc:RegisterEffect(e1,true)
+		--This card cannot be used as material for a Link Summon the turn that you conduct your Battle Phase
 		local e2=Effect.CreateEffect(c)
-		e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_CONTINUOUS)
-		e2:SetCode(EVENT_LEAVE_FIELD_P)
-		e2:SetLabelObject(e1)
-		e2:SetOperation(s.checkop)
-		e2:SetReset(RESET_EVENT+RESETS_STANDARD)
-		tc:RegisterEffect(e2)
-		local e3=Effect.CreateEffect(c)
-		e3:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
-		e3:SetCode(EVENT_PHASE+PHASE_BATTLE_START)
-		e3:SetCountLimit(1)
-		e3:SetLabelObject(tc)
-		e3:SetCondition(s.startcon)
-		e3:SetOperation(s.startop)
-		Duel.RegisterEffect(e3,tp)
-		e1:SetLabelObject(e3)
+		e2:SetType(EFFECT_TYPE_SINGLE)
+		e2:SetProperty(EFFECT_FLAG_CANNOT_DISABLE)
+		e2:SetCode(EFFECT_CANNOT_BE_LINK_MATERIAL)
+		e2:SetCondition(function() return Duel.GetActivityCount(tp,ACTIVITY_BATTLE_PHASE)>0 end)
+		e2:SetValue(1)
+		e2:SetReset(RESET_EVENT|RESETS_STANDARD)
+		tc:RegisterEffect(e2,true)
 	end
 end
-function s.checkop(e,tp,eg,ep,ev,re,r,rp)
-	if e:GetLabelObject() then
-		e:GetLabelObject():SetLabel(1)
-	end
-end
-function s.con(e,tp,eg,ep,ev,re,r,rp)
-	if r==REASON_LINK and e:GetLabelObject() then
-		return e:GetLabel()==1
-	else
-		e:Reset()
-		if e:GetLabelObject() and not e:GetLabelObject():IsDeleted() then
-			e:GetLabelObject():Reset()
-		end
-		return false
-	end
-end
-function s.op(e,tp,eg,ep,ev,re,r,rp)
+function s.cannotbpop(e,tp,eg,ep,ev,re,r,rp)
+	e:Reset()
+	--You cannot conduct your Battle Phase this turn
 	local e1=Effect.CreateEffect(e:GetHandler())
+	e1:SetDescription(aux.Stringid(id,2))
 	e1:SetType(EFFECT_TYPE_FIELD)
+	e1:SetProperty(EFFECT_FLAG_PLAYER_TARGET+EFFECT_FLAG_CLIENT_HINT)
 	e1:SetCode(EFFECT_CANNOT_BP)
-	e1:SetProperty(EFFECT_FLAG_PLAYER_TARGET+EFFECT_FLAG_OATH)
 	e1:SetTargetRange(1,0)
-	e1:SetReset(RESET_PHASE+PHASE_END)
+	e1:SetReset(RESET_PHASE|PHASE_END)
 	Duel.RegisterEffect(e1,tp)
-	e:SetLabel(0)
-	e:Reset()
-	e:GetLabelObject():Reset()
-end
-function s.startcon(e,tp,eg,ep,ev,re,r,rp)
-	local tc=e:GetLabelObject()
-	if not tc or tc:GetFlagEffect(id)==0 then e:Reset() return false end
-	return Duel.GetTurnPlayer()==tp
-end
-function s.startop(e,tp,eg,ep,ev,re,r,rp)
-	local tc=e:GetLabelObject()
-	local e1=Effect.CreateEffect(e:GetHandler())
-	e1:SetType(EFFECT_TYPE_SINGLE)
-	e1:SetCode(EFFECT_CANNOT_BE_LINK_MATERIAL)
-	e1:SetValue(1)
-	e1:SetReset(RESET_EVENT+RESETS_STANDARD+RESET_PHASE+PHASE_END)
-	tc:RegisterEffect(e1,true)
-end
+end