Update "Bonds of Hope"

- Should be able to use even if no Xyz Monsters on your field have material
- Optimized handling of moving materials from 1 Xyz Monster to another/adding handling for the above change
- General script polish/modernization

Author: TheRazgriz

unofficial/c511005023.lua

@@ -1,79 +1,69 @@
+--希望の絆
 --Bonds of Hope
 --scripted by Shad3, fixed by MLD
 local s,id=GetID()
 function s.initial_effect(c)
-	--Activate
+	--Special Summon 1 Xyz Monster from your GY, then attach this card and all materials from 1 Xyz Monster on your field to 1 other Xyz Monster on the field
 	local e1=Effect.CreateEffect(c)
 	e1:SetCategory(CATEGORY_SPECIAL_SUMMON)
-	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
+	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetCode(EVENT_SPSUMMON_SUCCESS)
-	e1:SetCategory(CATEGORY_SPECIAL_SUMMON)
-	e1:SetCondition(s.condition)
+	e1:SetCondition(function(e,tp,eg,ep,ev,re,r,rp) return eg:IsExists(s.cfilter,1,nil,tp) end)
 	e1:SetTarget(s.target)
-	e1:SetOperation(s.activate)
+	e1:SetOperation(s.operation)
 	c:RegisterEffect(e1)
 end
 function s.cfilter(c,tp)
 	return c:IsType(TYPE_XYZ) and c:IsControler(tp)
 end
-function s.condition(e,tp,eg,ep,ev,re,r,rp)
-	return eg:IsExists(s.cfilter,1,nil,tp)
-end
-function s.filter(c,e,tp)
+function s.spfilter(c,e,tp)
 	return c:IsType(TYPE_XYZ) and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
 end
-function s.filter2(c)
-	return c:IsType(TYPE_XYZ) and c:IsFaceup() and c:GetOverlayCount()~=0
-end
-function s.filter3(c)
-	return c:IsType(TYPE_XYZ) and c:IsFaceup()
+function s.detachfilter(c,tp)
+	return c:IsFaceup() and c:IsType(TYPE_XYZ) and c:CheckRemoveOverlayCard(tp,1,REASON_EFFECT)
 end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsControler(tp) and chkc:IsLocation(LOCATION_GRAVE) and s.filter(chkc,e,tp) end
+	if chkc then return chkc:IsControler(tp) and chkc:IsLocation(LOCATION_GRAVE) and s.spfilter(chkc,e,tp) end
 	if chk==0 then return Duel.GetLocationCount(tp,LOCATION_MZONE)>0 and e:IsHasType(EFFECT_TYPE_ACTIVATE)
-		and Duel.IsExistingTarget(s.filter,tp,LOCATION_GRAVE,0,1,e:GetHandler(),e,tp)
-		and Duel.IsExistingMatchingCard(s.filter2,tp,LOCATION_MZONE,0,1,nil)
+		and Duel.IsExistingTarget(s.spfilter,tp,LOCATION_GRAVE,0,1,nil,e,tp)
 	end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
-	local g=Duel.SelectTarget(tp,s.filter,tp,LOCATION_GRAVE,0,1,1,nil,e,tp)
-	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,g,1,0,0)
+	local g=Duel.SelectTarget(tp,s.spfilter,tp,LOCATION_GRAVE,0,1,1,nil,e,tp)
+	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,g,1,tp,LOCATION_GRAVE)
 end
-function s.activate(e,tp,eg,ep,ev,re,r,rp)
+function s.operation(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
 	local tc=Duel.GetFirstTarget()
 	if not tc or not tc:IsRelateToEffect(e) or Duel.SpecialSummon(tc,0,tp,tp,false,false,POS_FACEUP)<=0 then return end
-	local xc
-	local og=Group.CreateGroup()
-	if c:IsRelateToEffect(e) then
-		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_REMOVEXYZ)
-		local xg=Duel.SelectMatchingCard(tp,s.filter2,tp,LOCATION_MZONE,0,1,1,nil,TYPE_XYZ)
-		if #xg>0 then
-			Duel.HintSelection(xg)
-			xc=xg:GetFirst()
-			og=xc:GetOverlayGroup()
-			c:CancelToGrave()
-			og:AddCard(c)
-		end
-	end
-	if #og>0 then
-		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TARGET)
-		local ng=Duel.SelectMatchingCard(tp,s.filter3,tp,LOCATION_MZONE,0,1,1,xc)
-		Duel.HintSelection(ng)
-		local nc=ng:GetFirst()
-		Duel.Overlay(nc,og)
+	Duel.BreakEffect()
+	local tg=Duel.GetMatchingGroup(s.detachfilter,tp,LOCATION_MZONE,0,nil,tp)
+	if #tg>0 then
+		c:CancelToGrave()
+		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_DEATTACHFROM)
+		local detachxyz=tg:FilterSelect(tp,Card.CheckRemoveOverlayCard,1,1,nil,tp,1,REASON_EFFECT):GetFirst()
+		local attachxyz=Duel.SelectMatchingCard(tp,aux.FaceupFilter(Card.IsType,TYPE_XYZ),tp,LOCATION_MZONE,0,1,1,detachxyz):GetFirst()
+		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATTACH)
+		local attach_group=detachxyz:GetOverlayGroup()
+		if #attach_group>0 and c:IsOnField() then attach_group:AddCard(c) end
+		Duel.Overlay(attachxyz,attach_group)
+		Duel.RaiseSingleEvent(detachxyz,EVENT_DETACH_MATERIAL,e,0,0,0,0)
+	else
+		c:CancelToGrave()
+		local attachxyz=Duel.SelectMatchingCard(tp,aux.FaceupFilter(Card.IsType,TYPE_XYZ),tp,LOCATION_MZONE,0,1,1,nil):GetFirst()
+		Duel.Overlay(attachxyz,c)
 	end
 	local e1=Effect.CreateEffect(c)
 	e1:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
-	e1:SetCode(EVENT_PHASE+PHASE_END)
 	e1:SetProperty(EFFECT_FLAG_IGNORE_IMMUNE)
-	e1:SetReset(RESET_PHASE+PHASE_END)
+	e1:SetCode(EVENT_PHASE+PHASE_END)
 	e1:SetCountLimit(1)
-	e1:SetOperation(s.desop)
 	e1:SetLabelObject(tc)
+	e1:SetOperation(s.desop)
+	e1:SetReset(RESET_PHASE|PHASE_END)
 	Duel.RegisterEffect(e1,tp)
 end
 function s.desop(e,tp,eg,ep,ev,re,r,rp)
 	local tc=e:GetLabelObject()
 	if tc and tc:IsOnField() then Duel.Destroy(tc,REASON_EFFECT) end
-end
+end