Update cards without hint messages before card selections + various script fixes

Added hint messages to the selection prompts of various cards that were missing them. Also includes the following specific card fixes:
- Breaking of the World: Added missing effect categories. Should show a card on resolution, not on activation. Should check that the target is still face-up on resolution.
- Charged-Up Heraldry: Handle checking for available Monster Zones in the case of applying this card's effect through another effect. Shouldn't apply the restriction if it's not a card activation.
- Dogmatika Encounter: The second bullet point should be negated by "Necrovalley".
- Endymion, the Magistus of Mastery: Added missing effect category. Also check that the card to equip can be placed on that player's field.
- Fortune Lady Every: Added missing effect category. The effect should activate even if she's Level 12 or higher.
- Generation Shift: Don't destroy the target if you don't control it on resolution.
- Joker's Wild: Shouldn't be able to apply its effect with another card.
- Machina Citadel: Should check for the destroyed card's name on the field rather than after it's destroyed.
- Orcustrated Core: Shouldn't be able to use a 2nd "Orcustrated Core" to apply the effect on a card that already has the effect applied to it.
- Ruddy Rose Witch: Shouldn't be able to use its effect if you don't have a Plant to place on top of the Deck. Shouldn't be able to Normal Summon if you don't successfully add a card to the hand and place a Plant on top of the Deck.
- Sprind the Irondash Dragon: Should select the zones on resolution.
- Stardust Illumination: Should also check for "Stardust Dragon" in the Spell & Trap Zone.
- Starry Knight Ceremony: Place the revealed card on the bottom of the owner's Deck rather than the current possessor's.
- Super Quantal Alphan Spike: Also check for an available zone to summon from the Extra Deck.
- The Grand Spellbook Tower: Placing on the bottom of the Deck and drawing are simultaneous in the OCG.
- Thunder Ball: Shouldn't be able to use its 1st effect if damage calculation isn't conducted. The destroy effect should resolve doing nothing if this card has already left the field when it resolves. Shouldn't roll a die if the target has already left the GY when it resolves.
- Valkyrie Erste: Added missing targeting flag. Should check that the effect that Special Summoned it was a Spell effect rather than check that the card that Special Summoned it is currently a Spell. Don't consider face-down "Valkyrie" monsters for the condition. The ATK change should go away if the card's effects are negated later.
- Vendread Daybreak: Shouldn't destroy itself if it's still the same card on resolution.
- Voloferniges, the Darkest Dragon Doomrider: The OPT should be shared between the non-Quick version and the Quick version. Shouldn't be able to use the Quick version during the Damage Step. If the activation of the effect is negated then this card should be able to attack that turn.

And many many more small script fixes, updates, and/or modernisations (58 cards in total).

Author: NaimSantos

official/c11082056.lua

@@ -2,51 +2,55 @@
 --The Fang of Critias
 local s,id=GetID()
 function s.initial_effect(c)
-	--Activate
+	--This card is also always treated as "Legendary Dragon Critias"
+	local e0=Effect.CreateEffect(c)
+	e0:SetType(EFFECT_TYPE_SINGLE)
+	e0:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_UNCOPYABLE)
+	e0:SetCode(EFFECT_ADD_CODE)
+	e0:SetValue(10000060)
+	c:RegisterEffect(e0)
+	--Send 1 Trap from your hand or field to the GY, that is listed on a Fusion Monster that can only be Special Summoned with "The Fang of Critias" (if that card is Set, reveal it), then Special Summon that Fusion Monster from your Extra Deck
 	local e1=Effect.CreateEffect(c)
-	e1:SetCategory(CATEGORY_SPECIAL_SUMMON)
+	e1:SetDescription(aux.Stringid(id,0))
+	e1:SetCategory(CATEGORY_TOGRAVE+CATEGORY_SPECIAL_SUMMON)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetCountLimit(1,id,EFFECT_COUNT_CODE_OATH)
 	e1:SetTarget(s.target)
 	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
-	--add code
-	local e2=Effect.CreateEffect(c)
-	e2:SetType(EFFECT_TYPE_SINGLE)
-	e2:SetCode(EFFECT_ADD_CODE)
-	e2:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_UNCOPYABLE)
-	e2:SetValue(10000060)
-	c:RegisterEffect(e2)
 end
-function s.tgfilter(c,e,tp,rp)
-	return c:IsTrap() and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_EXTRA,0,1,nil,e,tp,c:GetCode(),rp)
+s.listed_names={10000060,id} --"Legendary Dragon Critias"
+function s.tgfilter(c,e,tp)
+	return c:IsTrap() and c:IsAbleToGrave() and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_EXTRA,0,1,nil,e,tp,c:GetCode())
 end
-function s.spfilter(c,e,tp,code,rp)
-	return c:IsType(TYPE_FUSION) and c.material_trap and Duel.GetLocationCountFromEx(tp,rp,nil,c)>0 and c:IsCanBeSpecialSummoned(e,0,tp,true,false) and code==c.material_trap
+function s.spfilter(c,e,tp,code)
+	return c:IsType(TYPE_FUSION) and c.material_trap and code==c.material_trap and Duel.GetLocationCountFromEx(tp,tp,nil,c)>0
+		and c:IsCanBeSpecialSummoned(e,0,tp,true,false)
 end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then return Duel.IsExistingMatchingCard(s.tgfilter,tp,LOCATION_HAND|LOCATION_SZONE,0,1,nil,e,tp,rp) end
+	if chk==0 then return Duel.IsExistingMatchingCard(s.tgfilter,tp,LOCATION_HAND|LOCATION_ONFIELD,0,1,nil,e,tp) end
+	Duel.SetOperationInfo(0,CATEGORY_TOGRAVE,nil,1,tp,LOCATION_HAND|LOCATION_ONFIELD)
 	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,LOCATION_EXTRA)
 end
 function s.activate(e,tp,eg,ep,ev,re,r,rp)
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_FMATERIAL)
-	local g=Duel.SelectMatchingCard(tp,s.tgfilter,tp,LOCATION_HAND|LOCATION_SZONE,0,1,1,nil,e,tp,rp)
-	local tc=g:GetFirst()
-	if tc and not tc:IsImmuneToEffect(e) then
-		if tc:IsOnField() and tc:IsFacedown() then Duel.ConfirmCards(1-tp,tc) end
-		Duel.SendtoGrave(tc,REASON_EFFECT)
-		if not tc:IsLocation(LOCATION_GRAVE) then return end
-		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
-		local sg=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_EXTRA,0,1,1,nil,e,tp,tc:GetCode())
-		if tc:IsPreviousLocation(LOCATION_SZONE) and tc:IsPreviousPosition(POS_FACEUP) then 
-			sg=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_EXTRA,0,1,1,nil,e,tp,tc:GetPreviousCodeOnField())
+	local mc=Duel.SelectMatchingCard(tp,s.tgfilter,tp,LOCATION_HAND|LOCATION_ONFIELD,0,1,1,nil,e,tp):GetFirst()
+	if mc and not mc:IsImmuneToEffect(e) then
+		if mc:IsOnField() and mc:IsFacedown() then
+			Duel.ConfirmCards(1-tp,mc)
+		end
+		if Duel.SendtoGrave(mc,REASON_EFFECT)==0 or not mc:IsLocation(LOCATION_GRAVE) then return end
+		local code=mc:GetCode()
+		if mc:IsPreviousLocation(LOCATION_ONFIELD) and mc:IsPreviousPosition(POS_FACEUP) then 
+			code=mc:GetPreviousCodeOnField()
 		end
-		local sc=sg:GetFirst()
+		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
+		local sc=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_EXTRA,0,1,1,nil,e,tp,code):GetFirst()
 		if sc then
 			Duel.BreakEffect()
-			Duel.SpecialSummon(sc,0,tp,tp,true,false,POS_FACEUP)
+			if Duel.SpecialSummon(sc,0,tp,tp,true,false,POS_FACEUP)==0 then return end
 			sc:CompleteProcedure()
 		end
 	end
-end
+end

official/c12292422.lua

@@ -5,6 +5,7 @@ local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_FREE_CHAIN)
 	e1:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
@@ -38,6 +39,7 @@ function s.filter(c,typ,lv)
 	return c:IsRace(typ) and c:IsLevel(lv) and c:IsAbleToGrave()
 end
 function s.activate(e,tp,eg,ep,ev,re,r,rp)
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TOGRAVE)
 	local tc=Duel.SelectMatchingCard(tp,s.tgyfilter,tp,LOCATION_HAND,0,1,1,nil):GetFirst()
 	if tc and Duel.SendtoGrave(tc,REASON_EFFECT)~=0 and tc:IsLocation(LOCATION_GRAVE) then
 		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_RACE)
@@ -46,7 +48,7 @@ function s.activate(e,tp,eg,ep,ev,re,r,rp)
 		local lv=Duel.AnnounceLevel(tp,1,12)
 		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TOGRAVE)
 		local g=Duel.SelectMatchingCard(1-tp,s.filter,1-tp,LOCATION_HAND|LOCATION_DECK,0,1,1,nil,typ,lv)
-			if #g>0 then
+		if #g>0 then
 			Duel.SendtoGrave(g,REASON_EFFECT)
 		end
 	end

official/c18478530.lua

@@ -8,7 +8,7 @@ function s.initial_effect(c)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_FREE_CHAIN)
 	c:RegisterEffect(e1)
-	--Cannot attack
+	--Monsters your opponent controls with 2000 or less ATK cannot attack
 	local e2=Effect.CreateEffect(c)
 	e2:SetType(EFFECT_TYPE_FIELD)
 	e2:SetCode(EFFECT_CANNOT_ATTACK)
@@ -17,7 +17,7 @@ function s.initial_effect(c)
 	e2:SetCondition(s.atkcon)
 	e2:SetTarget(aux.TargetBoolFunction(Card.IsAttackBelow,2000))
 	c:RegisterEffect(e2)
-	--Special Summon 1 "Valkyrie" monster from Deck or hand
+	--Special Summon 1 Level 5 or higher "Valkyrie" monster from your hand or Deck
 	local e3=Effect.CreateEffect(c)
 	e3:SetCategory(CATEGORY_SPECIAL_SUMMON)
 	e3:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
@@ -33,7 +33,7 @@ function s.atkcon(e,c)
 	local tp=e:GetHandlerPlayer()
 	return Duel.IsExistingMatchingCard(aux.FaceupFilter(Card.IsSetCard,SET_VALKYRIE),tp,LOCATION_MZONE,0,1,nil)
 end
-function s.filter(c,e,tp)
+function s.spfilter(c,e,tp)
 	return c:IsLevelAbove(5) and c:IsSetCard(SET_VALKYRIE) and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
 end
 function s.spcon(e,tp,eg,ep,ev,re,r,rp)
@@ -42,13 +42,13 @@ function s.spcon(e,tp,eg,ep,ev,re,r,rp)
 end
 function s.sptg(e,tp,eg,ep,ev,re,r,rp,chk)
 	if chk==0 then return Duel.GetLocationCount(tp,LOCATION_MZONE)>0
-	and Duel.IsExistingMatchingCard(s.filter,tp,LOCATION_DECK|LOCATION_HAND,0,1,nil,e,tp) end
+	and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_DECK|LOCATION_HAND,0,1,nil,e,tp) end
 	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,LOCATION_DECK|LOCATION_HAND)
 end
 function s.spop(e,tp,eg,ep,ev,re,r,rp)
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
 	if Duel.GetLocationCount(tp,LOCATION_MZONE)<=0 then return end
-	local g=Duel.SelectMatchingCard(tp,s.filter,tp,LOCATION_DECK|LOCATION_HAND,0,1,1,nil,e,tp)
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
+	local g=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_DECK|LOCATION_HAND,0,1,1,nil,e,tp)
 	if #g>0 then
 		Duel.SpecialSummon(g,0,tp,tp,false,false,POS_FACEUP)
 	end

official/c1906812.lua

@@ -1,16 +1,16 @@
 --灰燼竜バスタード
 --Sprind the Irondash Dragon
---Logical Nonsense
---Substitute ID
+--scripted by Logical Nonsense
 local s,id=GetID()
 function s.initial_effect(c)
 	--Must be properly summoned before reviving
 	c:EnableReviveLimit()
-	--Fusion summon procedure
+	--Fusion Materials: "Fallen of Albaz" + 1 Effect Monster Special Summoned this turn
 	Fusion.AddProcMix(c,true,true,CARD_ALBAZ,aux.FilterBoolFunctionEx(s.filter))
-	--Move itself to 1 of your unused MMZ
+	--Move this card you control to another of your Main Monster Zones, then you can destroy all other face-up cards in this card's column
 	local e1=Effect.CreateEffect(c)
 	e1:SetDescription(aux.Stringid(id,0))
+	e1:SetCategory(CATEGORY_DESTROY)
 	e1:SetType(EFFECT_TYPE_IGNITION)
 	e1:SetRange(LOCATION_MZONE)
 	e1:SetCountLimit(1)
@@ -25,38 +25,32 @@ function s.initial_effect(c)
 	e2:SetOperation(s.regop)
 	c:RegisterEffect(e2)
 end
-	--Lists "Sprigguns" archetype
 s.listed_series={SET_SPRINGANS}
-	--Specifically lists "Fallen of Albaz"
 s.listed_names={CARD_ALBAZ}
-	--Check for an effect that was special summoned this turn
 function s.filter(c)
 	return c:IsLocation(LOCATION_MZONE) and c:IsType(TYPE_EFFECT) and c:IsStatus(STATUS_SPSUMMON_TURN)
 end
-	--Activation legality
 function s.seqtg(e,tp,eg,ep,ev,re,r,rp,chk)
 	if chk==0 then return Duel.GetLocationCount(tp,LOCATION_MZONE)>0 end
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TOZONE)
-	local seq=Duel.SelectDisableField(tp,1,LOCATION_MZONE,0,0)
-	Duel.Hint(HINT_ZONE,tp,seq)
-	e:SetLabel(math.log(seq,2))
+	Duel.SetPossibleOperationInfo(0,CATEGORY_DESTROY,nil,1,tp,LOCATION_ONFIELD)
 end
-	--Move itself to 1 of your unused MMZ, then destroy all face-up cards in its new column
 function s.seqop(e,tp,eg,ep,ev,re,r,rp,chk)
 	local c=e:GetHandler()
-	local seq=e:GetLabel()
-	if not c:IsRelateToEffect(e) or c:IsControler(1-tp) or not Duel.CheckLocation(tp,LOCATION_MZONE,seq) then return end
+	if not c:IsRelateToEffect(e) or c:IsControler(1-tp) then return end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TOZONE)
-	Duel.MoveSequence(c,seq)
-	local dg=c:GetColumnGroup():Filter(Card.IsFaceup,c,nil) --Check for face-up cards in its current column, except itself
-	if #dg>0 and Duel.SelectYesNo(tp,aux.Stringid(id,1)) then
-		Duel.BreakEffect()
-		Duel.Destroy(dg,REASON_EFFECT)
+	local seq=Duel.SelectDisableField(tp,1,LOCATION_MZONE,0,0)
+	if seq then
+		Duel.MoveSequence(c,math.log(seq,2))
+		local dg=c:GetColumnGroup():Filter(Card.IsFaceup,c,nil)
+		if #dg>0 and Duel.SelectYesNo(tp,aux.Stringid(id,1)) then
+			Duel.BreakEffect()
+			Duel.Destroy(dg,REASON_EFFECT)
+		end
 	end
 end
-	--Add or special summon 1 "Sprigguns" monster or "Fallen of Albaz" from deck
 function s.regop(e,tp,eg,ep,ev,re,r,rp)
 	local c=e:GetHandler()
+	--Add to your hand, or Special Summon, 1 "Springans" monster or 1 "Fallen of Albaz" from your Deck
 	local e1=Effect.CreateEffect(c)
 	e1:SetDescription(aux.Stringid(id,2))
 	e1:SetCategory(CATEGORY_TOHAND+CATEGORY_SEARCH)
@@ -69,22 +63,19 @@ function s.regop(e,tp,eg,ep,ev,re,r,rp)
 	e1:SetReset(RESETS_STANDARD_PHASE_END)
 	c:RegisterEffect(e1)
 end
-	--Check for a "Sprigguns" monster or "Fallen of Albaz"
 function s.thfilter(c,e,tp,ft)
 	return c:IsMonster() and (c:IsSetCard(SET_SPRINGANS) or c:IsCode(CARD_ALBAZ))
 		and (c:IsAbleToHand() or (c:IsCanBeSpecialSummoned(e,0,tp,false,false) and ft>0))
 end
-	--Activation legality
 function s.thtg(e,tp,eg,ep,ev,re,r,rp,chk)
 	local ft=Duel.GetLocationCount(tp,LOCATION_MZONE)
 	if chk==0 then return Duel.IsExistingMatchingCard(s.thfilter,tp,LOCATION_DECK,0,1,nil,e,tp,ft) end
 	Duel.SetOperationInfo(0,CATEGORY_TOHAND,nil,1,tp,LOCATION_DECK)
 	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,LOCATION_DECK)
 end
-	--Add or special summon 1 "Sprigguns" monster or "Fallen of Albaz" from deck
 function s.thop(e,tp,eg,ep,ev,re,r,rp)
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATOHAND)
 	local ft=Duel.GetLocationCount(tp,LOCATION_MZONE)
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATOHAND)
 	local tc=Duel.SelectMatchingCard(tp,s.thfilter,tp,LOCATION_DECK,0,1,1,nil,e,tp,ft):GetFirst()
 	if tc then
 		aux.ToHandOrElse(tc,tp,function(c)

official/c19307353.lua

@@ -3,7 +3,7 @@
 --scripted by pyrQ
 local s,id=GetID()
 function s.initial_effect(c)
-	--Search
+	--Add 1 monster from your Deck to your hand
 	local e1=Effect.CreateEffect(c)
 	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetCategory(CATEGORY_SEARCH+CATEGORY_TOHAND)
@@ -42,8 +42,8 @@ function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
 	Duel.SetOperationInfo(0,CATEGORY_TOHAND,nil,1,tp,LOCATION_DECK)
 end
 function s.operation(e,tp,eg,ep,ev,re,r,rp)
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATOHAND)
 	local total=e:GetLabel()
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_ATOHAND)
 	local g=Duel.SelectMatchingCard(tp,s.thfilter,tp,LOCATION_DECK,0,1,1,nil,total)
 	if #g>0 then
 		Duel.SendtoHand(g,nil,REASON_EFFECT)

official/c21147203.lua

@@ -66,8 +66,8 @@ function s.decksptg(e,tp,eg,ep,ev,re,r,rp,chk)
 end
 function s.deckspop(e,tp,eg,ep,ev,re,r,rp)
 	if Duel.GetLocationCount(tp,LOCATION_MZONE)<=0 then return end
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
 	local rac,att,lvl=e:GetLabel()
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
 	local g=Duel.SelectMatchingCard(tp,s.deckspfilter,tp,LOCATION_DECK,0,1,1,nil,e,tp,rac,att,lvl)
 	if #g>0 then
 		Duel.SpecialSummon(g,0,tp,tp,false,false,POS_FACEUP)

official/c23020408.lua

@@ -3,7 +3,7 @@
 --Scripted by Larry126
 local s,id=GetID()
 function s.initial_effect(c)
-	--Activate
+	--Place 1 card on top of the Deck from your hand, Deck, or GY, that is "Dark Magician" or mentions "Dark Magician" or "Dark Magician Girl"
 	local e1=Effect.CreateEffect(c)
 	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetCategory(CATEGORY_TODECK)
@@ -13,7 +13,7 @@ function s.initial_effect(c)
 	e1:SetTarget(s.target)
 	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
-	--Draw
+	--Draw cards equal to the number of "Palladium" monsters, "Dark Magician", and/or "Dark Magician Girl" with different names
 	local e2=Effect.CreateEffect(c)
 	e2:SetDescription(aux.Stringid(id,1))
 	e2:SetCategory(CATEGORY_DRAW)
@@ -36,8 +36,8 @@ function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
 	Duel.SetOperationInfo(0,CATEGORY_TODECK,nil,1,tp,LOCATION_HAND|LOCATION_GRAVE)
 end
 function s.activate(e,tp,eg,ep,ev,re,r,rp)
-	Duel.Hint(HINT_SELECTMSG,tp,aux.Stringid(id,2))
 	local ct=Duel.GetFieldGroupCount(tp,LOCATION_DECK,0)
+	Duel.Hint(HINT_SELECTMSG,tp,aux.Stringid(id,2))
 	local tc=Duel.SelectMatchingCard(tp,aux.NecroValleyFilter(s.filter),tp,LOCATION_HAND|LOCATION_DECK|LOCATION_GRAVE,0,1,1,nil,ct):GetFirst()
 	if tc then
 		if tc:IsLocation(LOCATION_DECK) then